Re: [Ipmitool-devel] Regarding Retries/Timeout for LAN/LANPLUS interface

2011-10-17 Thread Harshad Prabhu (hprabhu)
>On Mon, Oct 10, 2011 at 8:44 PM, Zdenek Styblik > wrote: >[...] >> It is good you're using strtol() function rather than atoi(), because >> it does (kind of) validation for you. >> However I think you should check whether the last processed character >> was '\0' and whether there >> was not over

Re: [Ipmitool-devel] Regarding Retries/Timeout for LAN/LANPLUS interface

2011-10-17 Thread Zdenek Styblik
On Mon, Oct 10, 2011 at 8:44 PM, Zdenek Styblik wrote: [...] > It is good you're using strtol() function rather than atoi(), because > it does (kind of) validation for you. > However I think you should check whether the last processed character > was '\0' and whether there > was not overflow. > >>