Re: [Ipmitool-devel] PATCH - # ipmitool sunoem sshkey; buffer overflow/input validation - ID: 3411421

2012-05-03 Thread Duncan Idaho
On Sun, Apr 29, 2012 at 5:36 PM, Duncan Idaho wrote: > Hello folks, > > attached is patch to handle input validation in 'lib/ipmi_sunoem.c'. > Looking at the source, one can expected more of these. > > What the patch does: > * long lines(= lines longer than 80chars) > * validate input in 'lib/ipmi

[Ipmitool-devel] Need a --with-debug autotool flag to disable strip'ing - ID: 1614904

2012-05-03 Thread Duncan Idaho
Hello, attached is a patch to 'configure.in' which adds '--with-debug' option. This option, if enabled, adds '-g' CFLAG. I don't think it is necessary to disable stripping in # make install; as it doesn't seem to be called anyway. Also: ~~~ # file ./ipmitool ipmitool: ELF 64-bit LSB executable, x

Re: [Ipmitool-devel] Correct Threshold/Discrete/Analog Display

2012-05-03 Thread Hank Bruning
Jim, We tested the patch on Kontron, Radisys and and Motorolla ATCA blades. Looks good, no problems that we can see. Hank On Mon, Apr 9, 2012 at 3:51 PM, Jim Mankovich wrote: > All, > > Anyone care to code review this before I submit this to the CVS repository? > I'm planning on submitting this