On Tue, Jul 2, 2013 at 10:41 AM, Dmitry Bazhenov <dim...@pigeonpoint.com> wrote: > Hello, Zdenek, > > The FRU information sections are hardly a subject for change in the near > future. So, I guess we can skip this issue. > > I updated the formatting of the patch according to your comments and removed > the restricted FRU info access entirely since the implemented algorithm > reduces the read/write size while it is not accepted. > > Please, review. > > Regards, > Dmitry >
Alright Dmitry, I agree. Mostly because I don't have time to play around with it right now. I'll give a diff look sooner or later(say in a week max). Regards, Z. > 28.06.2013 18:51, Zdenek Styblik пишет: > >> On Thu, Jun 27, 2013 at 6:06 PM, Dmitry Bazhenov <dim...@pigeonpoint.com> >> wrote: >> [...] >>>> >>>> 1] ``const char *section_id[4]'' - is there no chance at all this is >>>> going to be extended at some point in future? If it is, I'd be for >>>> better solution. My point is ``for (i = 0; i < 4; i++)'' and if it >>>> gets extended so must code which follows/is using/iterate over it. But >>>> may be I'm wrong. >>> >>> Is 'for ( i = 0; i < sizeof(section_id) / siceof(section_id[0]); i++)' >>> solves the issue? >> >> >> Dmitry, >> >> I'm not sure if there was an issue to begin with. But to be honest, >> this one looks scary. Please, let me think about it a bit, try >> something; I'll try to come up with some constructive(= better?). If I >> can't think of anything better, I guess, I shouldn't ask you to. I >> mean, I don't know. I'll think about it, try stuff, we'll see, ok? :) >> >> Have a nice weekend, >> Z. >> > ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
