Re: [Ipmitool-devel] cxoem commands for ipmitool

2013-07-24 Thread Jeffrey Bastian
On Wed, Jul 24, 2013 at 10:10:06AM -0400, Ales Ledvinka wrote: From: Zdenek Styblik zdenek.styb...@gmail.com However, changes to ipmi_lanp.{c,h} aren't as discussed 5 months ago, because they replace one, resp. existing, OEM functionality with another. Were you able to locate the OEM

Re: [Ipmitool-devel] ID: 65 - Fixes for configure.in for cross compilation

2013-07-24 Thread Dan Gora
0001-Re-work-of-ipmi_ek_display_fru_header_detail.patch This looks ok... It's not necessary to change ipmi_ek_display_fru_header_detail to return int, especially since you don't check the return code at all. Also the added storing of the return code for fseek at the bottom, but not checking the

[Ipmitool-devel] Code Review: ID: 212 - 'lib/ipmi_dcmi.c' - possible int *flow

2013-07-24 Thread Zdenek Styblik
Hi, attached is a patch to mitigate possible int *flows via user input. It's pretty much no brainer except those shifts. Therefore I'd appreciate if somebody could give it a look. Are those shifts correct? Will they work correctly on big endian too? Thanks, Z. ipmi_dcmi.c-fix_flows.diff