Re: [Ipmitool-devel] [PATCH] Add bswap.h to ipmi_chassis.c and ipmi_pef.c

2013-04-25 Thread Zdenek Styblik
On Thu, Apr 25, 2013 at 12:16 AM, Dan Gora wrote: > Here's a quick patch to fix this. > > thanks > dan > Hello Dan, you're absolutely correct. I've checked other files whether there is some better way, but it seems 'bswap.h' gets included unconditionally even though it's not needed at all in som

Re: [Ipmitool-devel] [PATCH] Add bswap.h to ipmi_chassis.c and ipmi_pef.c

2013-04-24 Thread Dan Gora
Here's a quick patch to fix this. thanks dan commit b1f38c34edc679eac03613b6ceb5825deca2e854 Author: Dan Gora Date: Wed Apr 24 19:09:54 2013 -0300 [debian] ipmitool: Fix compilation bug on big endian machines. On big endian machines the compilation would fail because BSWAP_32 was

Re: [Ipmitool-devel] [PATCH] Add bswap.h to ipmi_chassis.c and ipmi_pef.c

2013-04-24 Thread Dan Gora
Hi Zdenek, It turns out that this bug is not a duplicate after all.. The TOB of the CVS tree as of today still has the same compilation failure on big endian machines. The problem is the include files in ipmi_pef.c and ipmi_chassis.c #include #include #include #if WORDS_BIGENDIAN # include

Re: [Ipmitool-devel] [PATCH] Add bswap.h to ipmi_chassis.c and ipmi_pef.c

2013-04-04 Thread Zdenek Styblik
On Thu, Apr 4, 2013 at 7:21 PM, Dan Gora wrote: > Ok, never mind.. it was.. Sorry about that.. I originally did all the > changes against 1.8.12, then ported them to the tip of the CVS tree. > I didn't see that this was already fixed. > > thanks > dan > No worries. Z. > > On Thu, Apr 4, 2013 at

Re: [Ipmitool-devel] [PATCH] Add bswap.h to ipmi_chassis.c and ipmi_pef.c

2013-04-04 Thread Dan Gora
Ok, never mind.. it was.. Sorry about that.. I originally did all the changes against 1.8.12, then ported them to the tip of the CVS tree. I didn't see that this was already fixed. thanks dan On Thu, Apr 4, 2013 at 2:19 PM, Dan Gora wrote: > On Thu, Apr 4, 2013 at 8:57 AM, Zdenek Styblik > wr

Re: [Ipmitool-devel] [PATCH] Add bswap.h to ipmi_chassis.c and ipmi_pef.c

2013-04-04 Thread Dan Gora
On Thu, Apr 4, 2013 at 8:57 AM, Zdenek Styblik wrote: > On Fri, Mar 22, 2013 at 1:08 AM, Dan Gora wrote: >> The BSWAP_32 macro was added for big endian machines in these files, >> but the author forgot to include the necessary header file which >> defines it. >> >> Signed-off-by: Dan Gora > > Th

Re: [Ipmitool-devel] [PATCH] Add bswap.h to ipmi_chassis.c and ipmi_pef.c

2013-04-04 Thread Zdenek Styblik
On Fri, Mar 22, 2013 at 1:08 AM, Dan Gora wrote: > The BSWAP_32 macro was added for big endian machines in these files, > but the author forgot to include the necessary header file which > defines it. > > Signed-off-by: Dan Gora This is already fixed. Z. > --- > ipmitool/lib/ipmi_chassis.c |

[Ipmitool-devel] [PATCH] Add bswap.h to ipmi_chassis.c and ipmi_pef.c

2013-03-21 Thread Dan Gora
The BSWAP_32 macro was added for big endian machines in these files, but the author forgot to include the necessary header file which defines it. Signed-off-by: Dan Gora --- ipmitool/lib/ipmi_chassis.c |1 + ipmitool/lib/ipmi_pef.c |1 + 2 files changed, 2 insertions(+), 0 deletions(