Re: [Ipmitool-devel] SEL output for sensor number when zero

2012-05-18 Thread Jim Mankovich
Jon, I can't see any real reason for the special case to avoid printing zero and I don't have any problem with removing it. Does anyone have any objection to making this change? -- Jim Mankovich | jm...@hp.com -- On 5/11/2012 4:16 AM, Jon Bamber wrote: Hi There is code in ipmi_sel.c line

Re: [Ipmitool-devel] SEL output for sensor number when zero

2012-05-11 Thread Duncan Idaho
On Fri, May 11, 2012 at 10:16 AM, Jon Bamber wrote: > Hi > >   There is code in ipmi_sel.c line 1070 introduce 7 years ago in 1.39  which > excludes writing the sensor number out in the sel list output when the > sensor number is zero. > > i.e >   if (evt->sel_type.standard_type.sensor_num

[Ipmitool-devel] SEL output for sensor number when zero

2012-05-11 Thread Jon Bamber
Hi There is code in ipmi_sel.c line 1070 introduce 7 years ago in 1.39 which excludes writing the sensor number out in the sel list output when the sensor number is zero. i.e if (evt->sel_type.standard_type.sensor_num != 0) printf(" #0x%02x", evt->se