Re: [Ipmitool-devel] [PATCH 0/2] Some minor enhancements to SOL and event printing

2013-03-25 Thread Ales Ledvinka
25, 2013 3:41:25 PM Subject: Re: [Ipmitool-devel] [PATCH 0/2] Some minor enhancements to SOL and event printing Beware, excavations below. Looking at the proposed change and at the values already printed... The new: (evt->sel_type.standard_type.event_dir ? "Deasserted&qu

Re: [Ipmitool-devel] [PATCH 0/2] Some minor enhancements to SOL and event printing

2013-03-25 Thread Ales Ledvinka
the old line's event_data[0]... with the event_dir and keep the short ">" : "<" form. Is there anyone who can confirm this? - Original Message - From: "Corey Minyard" To: "Ales Ledvinka" Cc: ipmitool-devel@lists.sourceforge.net Sent: Frida

Re: [Ipmitool-devel] [PATCH 0/2] Some minor enhancements to SOL and event printing

2013-03-25 Thread Zdenek Styblik
On Fri, Mar 22, 2013 at 2:39 PM, Corey Minyard wrote: > I sent both of these in previously and I didn't hear anything. These are > some minor enhancements to ipmitool > > -corey > Hello Corey, I'm almost sure I've ignored these, because I have no access to servers with SOL support. And I did it

Re: [Ipmitool-devel] [PATCH 0/2] Some minor enhancements to SOL and event printing

2013-03-22 Thread Corey Minyard
On 03/22/2013 11:50 AM, Ales Ledvinka wrote: > Similar issue with ancient patch. > https://sourceforge.net/tracker/?func=detail&aid=2221609&group_id=95200&atid=610552 > Please check whether the comment there is relevant to your change as well. > > This is neither ACK nor NACK. Did not check your pa

Re: [Ipmitool-devel] [PATCH 0/2] Some minor enhancements to SOL and event printing

2013-03-22 Thread Ales Ledvinka
Similar issue with ancient patch. https://sourceforge.net/tracker/?func=detail&aid=2221609&group_id=95200&atid=610552 Please check whether the comment there is relevant to your change as well. This is neither ACK nor NACK. Did not check your patch yet. Just pointing out that there might be few mor