Re: [Ipmitool-devel] [Dell] [Patch 1/6] Dell Extension commands and Bug Fixes

2012-02-13 Thread Zdenek Styblik
Hello, wouldn't it make more sense to ask person whom has merged patches into CVS? Also, if these patches are already merged in, would it be possible to close feature requests in question at SF.net? Thanks and regards, Z. On Mon, Feb 13, 2012 at 5:48 AM, srinivas_g_go...@dell.com wrote: Not

[Ipmitool-devel] 'lib/ipmi_lanp.c' and use of atoi()

2012-02-13 Thread Zdenek Styblik
Hello, could somebody, please, ACK or NAK attached patch. Thanks, Z. -- Zdenek Styblik email: zdenek.styb...@gmail.com jabber: zdenek.styb...@gmail.com @@ -447,7 +459,7 @@ uint8_t chan, uint8_t * ival) { struct lan_param *lp; - uint8_t interval; + uint8_t interval = 0; int rc = 0;

Re: [Ipmitool-devel] ipmitool fix to display percentage units correctly

2012-02-13 Thread Jim Mank
Z, Yes it should return be returning a static char. I'll fix this. -- Jim Mankovich | jm...@hp.com -- On 2/9/2012 10:18 PM, Zdenek Styblik wrote: Hi, it looks fine by me. One thing though. Since it returns pointer to static char, should it be: static char *

Re: [Ipmitool-devel] ipmitool fix to display percentage units correctly

2012-02-13 Thread Jim Mank
Z, Here is the external include file declaration, and the new function declaration in the source file to cover the fact that the function returns a pointer to a static character array. I have attached a patch file with my complete set of changes. Let me know if there is anything else I