Re: [Ipmitool-devel] Code Review - ID: 3600926 - 'lib/ipmi_lanp.c' - check LAN param

2013-03-12 Thread Zdenek Styblik
On Mon, Mar 11, 2013 at 6:55 PM, Ales Ledvinka aledv...@redhat.com wrote: Oh and noticed the tracker comment about the bigger issue. Yes, get_lan_param_select() may return NULL, yet it's not being checked what the returned value is, resp. whether it's NULL or isn't. NULL reference in 3 ... 2 ...

Re: [Ipmitool-devel] Code Review - ID: 3600926 - 'lib/ipmi_lanp.c' - check LAN param

2013-03-12 Thread Ales Ledvinka
Planned though the report/patch I have for the double free does not match current cvs. Contains open tracker items (not yet commited) and does not include some new changes. Unfortunatly my setup to rescan the code needs few fixes so that was just a notice that if you are seeing weird things

Re: [Ipmitool-devel] OEM LAN params was:[Re: Code Review - ID: 3600926 - 'lib/ipmi_lanp.c' - check LAN param]

2013-03-12 Thread Zdenek Styblik
On Tue, Mar 12, 2013 at 11:12 AM, Ales Ledvinka aledv...@redhat.com wrote: Correct me if I am overlooking something, but the current 192+ codes are unreachable, right? It's seem so, yes. It's annotated as the 1.1 initial revision but I do not see it used nowdays anywhere in the code

Re: [Ipmitool-devel] Code Review - ID: 3600926 - 'lib/ipmi_lanp.c' - check LAN param

2013-03-12 Thread Jim Mankovich
Z, The patch looks good to me. It certainly fixes the reported problem. -- Jim Mankovich | jm...@hp.com (MST) -- On 3/8/2013 1:45 PM, Zdenek Styblik wrote: Hello all, attached is a diff of proposed change to 'lib/ipmi_lanp.c'. This bug has been reported by Ales Ledvinka a the problem is