Re: [Iprdd-devel] [PATCH 2/2] iprutils: Fix up setting write cache policy for JBODs

Thanks Brian, much better approach than my simplistic/naive way heheh Feel free to add my: Reviewed-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> But I noticed something weird: seems you worked this patch on top of my patch (see the last hunk). However I just fetched iprutil

[Iprdd-devel] [PATCH] iprutils/trivial: improve README documentation

Added more packages as required to perform build process, like libtool, autoconf and automake. Pointed name differences of devel packages on Ubuntu (compared with RHEL-based distros). Also, fixed a typo on README file. Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> ---

Re: [Iprdd-devel] [PATCH] ipruitls: Add reserved bits in page 2 of ses device

de details for "Guilherme G. Piccoli" ---03/02/2017 01:20:36 > PM---On 03/02/2017 02:20 PM, wenxi...@linux.vnet.ibm.co"Guilherme G. > Piccoli" ---03/02/2017 01:20:36 PM---On 03/02/2017 02:20 PM, > wenxi...@linux.vnet.ibm.com wrote: > From: Wen Xiong <w

Re: [Iprdd-devel] [PATCH] ipruitls: Add reserved bits in page 2 of ses device

On 03/02/2017 02:20 PM, wenxi...@linux.vnet.ibm.com wrote: > From: Wen Xiong > > The length of Page 2 with Slider SFF is 0x2A4. Add reserved bits in > structure of Page 2. > > Signed-off-by: Wen Xiong > --- > iprlib.h |1 + > 1

Re: [Iprdd-devel] [PATCH v2] iprutils: Enable time configuration for SES enclosures.

On 03/29/2016 12:38 PM, Gabriel Krisman Bertazi wrote: > Thanks for your review! > > yes, you are correct. I added a return value for this function and > changed the return type for init_ses_dev, as you suggested. Very nice Gabriel, thank you. > >>> +int ipr_ses_get_time(struct ipr_dev *dev,

Re: [Iprdd-devel] [PATCH] iprutils: Enable time configuration for SES enclosures.

Nice patch Gabriel! Some questions/comments below: On 03/29/2016 11:02 AM, Gabriel Krisman Bertazi wrote: > Some new external drawers like ESLS have an internal clock, used by the > internal microcode. This patch enables iprinit to configure the clock > at boot time, and allow users to fetch