Re: [Iprdd-devel] [RFC] [PATCH 02/10] ipr: Remove redundant messages at adapter init time

2016-09-08 Thread Gabriel Krisman Bertazi
Brian King writes: > Whenever multiple HRRQs are enabled, which is the default > setting now, we end up seeing the following message logged > prior to initialization of each HRRQ: > > Starting IOA initialization sequence > > This results in 16 of these messages on most adapters, which > serves li

Re: [Iprdd-devel] [RFC] [PATCH 01/10] ipr: Don't log unnecessary 9084 error details

2016-09-08 Thread Gabriel Krisman Bertazi
Brian King writes: > A 9084 error gets logged by the ipr adapter when adapter raw mode > gets enabled. A bunch of unformatted hex data also gets logged > for this error, which is of little use, so let's avoid logging > it by default in order to avoid the log getting polluted with > useless data.

Re: [Iprdd-devel] [RFC] [PATCH 04/10] ipr: Use libata new EH

2016-09-08 Thread Gabriel Krisman Bertazi
Brian King writes: > Converts ipr to use the new EH API of libata, removing the > last user of this API, allowing for its ultimate removal from > the kernel. > > Sending this out only as an RFC for now. The patch will need > significantly more testing, but I can now detect and initialize > a SATA

Re: [Iprdd-devel] [RFC] [PATCH 06/10] ipr: Add scsi multi-queue support

2016-09-08 Thread Gabriel Krisman Bertazi
Brian King writes: > From: Wen Xiong > > Add scsi multi-queue support in ipr driver. > > Signed-off-by: Brian King Patch looks good, very simple :) Missing a sign-off from Wendy, though. > --- > > drivers/scsi/ipr.c | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) >

Re: [Iprdd-devel] [RFC] [PATCH 07/10] ipr: Remove free/pending queues

2016-09-08 Thread Gabriel Krisman Bertazi
Brian King writes: > Removes the free and pending ipr_cmd queues. This is the first patch in a > series > to make queuecommand lockless for the ipr driver. Creates a bitarray for each > hardware queue so we can track whether an ipr_cmd struct is free or not. Also > adds an atomic flag on each ip

Re: [Iprdd-devel] [RFC] [PATCH 09/10] ipr: Lockless queuecommand

2016-09-08 Thread Gabriel Krisman Bertazi
Brian King writes: > This patch removes all spinlocks from ipr's queuecommand path. > > Signed-off-by: Brian King > --- > > drivers/scsi/ipr.c | 70 > +++-- > drivers/scsi/ipr.h | 52 +-- > 2 files changed,

Re: [Iprdd-devel] [RFC] [PATCH 03/10] scsi: Export SCSI EH commands

2016-09-08 Thread Gabriel Krisman Bertazi
Brian King writes: > Export the following EH commands so that ipr can be converted to > use libata's new EH. > lgtm. -- Gabriel Krisman Bertazi -- ___ Iprdd-devel mailing li

Re: [Iprdd-devel] [RFC] [PATCH 10/10] ipr: percpu_refcount queuecommand

2016-09-08 Thread Gabriel Krisman Bertazi
Brian King writes: > This converts ipr's queuecommand path to use percpu refcounts > rather than atomics. > > Signed-off-by: Brian King > --- > > drivers/scsi/ipr.c | 111 > ++--- > drivers/scsi/ipr.h | 53 +++-- > 2 files

Re: [Iprdd-devel] [RFC] [PATCH 05/10] ipr: Add module parameter to disable attaching SATA devices

2016-09-08 Thread Gabriel Krisman Bertazi
Brian King writes: > This adds a module parameter that, when set, will prevent > ipr from attaching any SATA devices, and only attach SAS > devices. > lgtm. -- Gabriel Krisman Bertazi -- _

Re: [Iprdd-devel] [RFC] [PATCH 08/10] ipr: Optimize locking for MSI-X

2016-09-08 Thread Gabriel Krisman Bertazi
Brian King writes: > We can avoid grabbing any locks in the interrupt path for MSI-X interrupts > and simply schedule the iopoll thread. > looks good. -- Gabriel Krisman Bertazi -- ___