Re: [Iprdd-devel] [PATCH v2] iprutils: Enable time configuration for SES enclosures.
On 03/29/2016 10:38 AM, Gabriel Krisman Bertazi wrote:
> +
> static const struct {
> char *cmd;
> int min_args;
> @@ -19270,6 +19319,8 @@ static const struct {
> { "resume-disk-enclosure", 1, 0, 1, resume_disk_enclosure,
> "sg8 "},
> { "show-perf", 1, 0, 1, show_perf, "sg8"},
> { "dump", 0, 0, 0, dump, "" },
> + { "get-ses-time", 1, 0, 1, get_ses_time, "sg8"},
> + { "set-ses-time", 3, 0, 3, set_ses_time, "sg8
> -MM-DD HH:MM:SS"},
Given that we are setting this from iprinit, do we still want to expose an
option in
iprconfig for the user to manually read / modify this? Could be useful for
debugging,
but doesn't seem like something we'd typically want a user to do. I think I'd
prefer to
keep things simple and not expose this in iprconfig, unless you can think of a
good
use case.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
___
Iprdd-devel mailing list
Iprdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iprdd-devel
Re: [Iprdd-devel] [PATCH v2] iprutils: Enable time configuration for SES enclosures.
On 03/29/2016 12:38 PM, Gabriel Krisman Bertazi wrote: > Thanks for your review! > > yes, you are correct. I added a return value for this function and > changed the return type for init_ses_dev, as you suggested. Very nice Gabriel, thank you. > >>> +int ipr_ses_get_time(struct ipr_dev *dev, u64* timestamp, int *origin); >>> +int ipr_ses_set_time(struct ipr_dev *dev, u64 timestamp); >> >> Indentation seems weird here, but it's possibly my email client heheh > > hmm, indentation looks correct here. > > Please check the re-spin below. > > Thanks, It's fine, for sure it's my email client playing tricks on me heheh Thanks, Guilherme -- Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785471=/4140 ___ Iprdd-devel mailing list Iprdd-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/iprdd-devel
