[IPsec] Genart last call review of draft-ietf-ipsecme-yang-iptfs-06

2022-07-21 Thread Joel Halpern via Datatracker
Reviewer: Joel Halpern Review result: Ready I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more

Re: [IPsec] [Lwip] Paul Wouters' Discuss on draft-ietf-lwig-minimal-esp-08: (with DISCUSS and COMMENT)

2022-07-21 Thread Daniel Migault
Hi Tero, This is correct. When reading Paul's comment I had in mind the text was about the SN roll over. However, re-reading the full section this is not the case and the SN roll over mechanism is described later in the section. I propose to simply remove the current text "Note ... " Yours,

[IPsec] AD Review of draft-ietf-ipsecme-mib-iptfs-03

2022-07-21 Thread Roman Danyliw
Hi! I performed an AD review of draft-ietf-ipsecme-mib-iptfs-03. Thanks for this companion document to the YANG module for IP-TFS management. Below is my feedback: To the idea that this MIB is redrived from the YANG modules: ** Consider if you want to use the same names for field values.