Re: [ipxe-devel] [PATCH 1/2] iscsi: Parse IPv6 address for rootpath

2018-03-01 Thread Michael Brown
On 05/02/18 08:38, Hannes Reinecke wrote: The 'rootpath' variable might contain an IPv6 address in brackets [XX:XX::XX]. So update the parser to handle this address correctly. Applied with some simplifications (since ipv6_sock_aton() will accept an address that still contains the '[]'

Re: [ipxe-devel] [PATCH 2/3] ethernet: do not construct EUI-64 identifier for empty MAC

2018-03-01 Thread Michael Brown
On 01/03/18 12:53, Hannes Reinecke wrote: An empty MAC address will cause other problems. If the driver expects the possibility of an empty MAC address, it should be using eth_random_addr() to construct a locally-assigned address. Which driver ended up providing an empty MAC address? igbvf.

Re: [ipxe-devel] [PATCH 2/3] ethernet: do not construct EUI-64 identifier for empty MAC

2018-03-01 Thread Hannes Reinecke
On 03/01/2018 01:44 PM, Michael Brown wrote: > On 05/02/18 08:36, Hannes Reinecke wrote: >> If the MAC address is empty we should not construct an EUI-64 >> identifier, but rather return an error. > > An empty MAC address will cause other problems.  If the driver expects > the possibility of an

Re: [ipxe-devel] [PATCH 3/3] ndp: make IPv6 prefix user-settable

2018-03-01 Thread Geert Stappers
On Thu, Mar 01, 2018 at 12:26:40PM +, Michael Brown wrote: > On 07/02/18 18:41, Michael Brown wrote: > >On 07/02/18 07:16, Hannes Reinecke wrote: > >>On 02/07/2018 03:06 AM, Michael Brown wrote: > >>>Could you give an example of how this might be used? > >>> > >>Simple; botched IPv6

Re: [ipxe-devel] [PATCH 2/3] ethernet: do not construct EUI-64 identifier for empty MAC

2018-03-01 Thread Michael Brown
On 05/02/18 08:36, Hannes Reinecke wrote: If the MAC address is empty we should not construct an EUI-64 identifier, but rather return an error. An empty MAC address will cause other problems. If the driver expects the possibility of an empty MAC address, it should be using eth_random_addr()

Re: [ipxe-devel] [PATCH 1/3] dhcpv6: Fallback to using DUID-LL for empty UUID

2018-03-01 Thread Michael Brown
On 05/02/18 08:36, Hannes Reinecke wrote: +/** DHCP unique identifier based on Ethernet Link-layer address (DUID-LL) */ +struct dhcpv6_duid_eth_ll { + /** Type */ + uint16_t type; + /** Hardware type: Ethernet */ + uint16_t hw_type; + /** Ethernet link-layer address