Found it:
> Any target in the makefile may be specified as a goal (unless it starts with
> ‘-’ or contains an ‘=’, in which case it will be parsed as a switch or
> variable definition, respectively).
-- https://www.gnu.org/software/make/manual/make.html#Goals
I make my living on exactly this
> What problem is this actually solving?
Allow me to demonstrate:
```
$ echo && cat Makefile.bad && echo && EMBED=foobar make -f Makefile.bad && echo
&& cat Makefile.good && EMBED=foobar make -f Makefile.good
EMBED := $(EMBEDDED_IMAGE)
.PHONY: all
all:
echo "EMBEDDED_IMAGE:
What problem is this actually solving? Any variables specified in the `make`
command line will override assignments within the Makefile. Building with
`make EMBED=...` works with no problems already.
--
You are receiving this because you are subscribed to this thread.
Reply to this email
@danderson approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/115#pullrequestreview-432819509___
ipxe-devel mailing
You can view, comment on, or merge this pull request online at:
https://github.com/ipxe/ipxe/pull/115
-- Commit Summary --
* fix EMBED: dont eagerly assign over non-empty value
-- File Changes --
M src/Makefile.housekeeping (2)
-- Patch Links --
5 matches
Mail list logo
