@mcb30 thank you for your explanation. I found the sentiment you referenced:
> When make runs a recipe, variables defined in the makefile are placed into
> the environment of each shell.
> ...
> Other use of variables from the environment is not recommended. It is not
> wise for makefiles to
Closed #115.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/115#event-3503395947___
ipxe-devel mailing list
ipxe-devel@lists.ipxe.org
@mcb30 I can't tell if you're biding your time in thoughtful contemplation or
giving me the "Slow No". I want to believe it's the former, but --- since this
patch is a literal single character --- I doubt that optimism is justified. If
you're _not_ going to merge it, then could you please close
@mcb30
Yes you are right, I have the wrong impression without double checking the
code, the timer calls 'efi_tick()' indeed.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
@JamesWangAmiTw The timer callback function is `efi_tick()`, not
`efi_currticks()`. The timer event controlled by
`efi_tick_startup()`/`efi_tick_shutdown()` does not execute the code in
`efi_currticks()`.
There should not be any code path that leads to `efi_currticks()` while at
@mcb30
Sorry for not being specific in my [previous
comment](https://github.com/ipxe/ipxe/pull/113#issuecomment-651511355). I
didn't mean TPL is never restored anywhere but it was changed in timer event.
When OS image starts, is the `efi_currticks()` still active?
I assume it only stops
@jjohnson42 Thanks for the hints about reproduction via ESXi 7's bootx64.efi.
I will try to assemble a test case in qemu that demonstrates the problem. If
you have a minimal test case ready to use, that would be really helpful.
@huanghe4 What you are describing is not a **root** cause. If
7 matches
Mail list logo
