Closed #103.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/103#event-3571626809___
ipxe-devel mailing list
ipxe-devel@lists.ipxe.org
Good catch; thanks. Pushed the memcmp fix as
http://github.com/ipxe/ipxe/commit/0de5e6014 and pushed a simpler fix for the
wpa_derive_ptk debug message as http://github.com/ipxe/ipxe/commit/ee2dc525b
--
You are receiving this because you are subscribed to this thread.
Reply to this email
I haven't contributed to iPXE in many years, so I don't have write access to
the Github repo, but this PR looks good to me.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I wrote the original WPA code in 2009, and definitely successfully booted with
it at that time. It looks like the incorrect-polarity memcmp() was only
introduced in 2014:
https://github.com/ipxe/ipxe/commit/8ee39f7432e63c2382ab3e7d24e234310f4532c9
--
You are receiving this because you are
Fix memcmp() to return proper standard positive/negative
values for unequal comparisons. Similar to commit 3946aa9. The
current implementation is backwards (i.e. the functions are returning
negative when they should be positive and vice-versa).
Currently all other consumers of these functions
5 matches
Mail list logo
