Re: [ipxe-devel] [PATCH 0/4] [virtio] Virtqueue fixes
On Fri, Dec 16, 2016 at 03:30:01PM +0100, Ladi Prosek wrote: > This series was prompted by the issue reported in: > http://lists.ipxe.org/pipermail/ipxe-devel/2016-December/005317.html > > As it turns out, neither legacy nor modern iPXE virtio implementation > currently works well with queue sizes >256. > > In patch 1, modern virtio is fixed to correctly negotiate the queue > size. In patch 4, legacy virtio is fixed to accept whatever queue size > is declared by the host. > > src/drivers/bus/virtio-pci.c | 70 > +- > src/drivers/net/virtio-net.c | 31 --- > src/include/ipxe/virtio-pci.h | 2 ++ > src/include/ipxe/virtio-ring.h | 12 +++- > 4 files changed, 75 insertions(+), 40 deletions(-) > > Thanks! > Ladi I posted a comment on one patch but either way: Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature ___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
Re: [ipxe-devel] [PATCH 0/4] [virtio] Virtqueue fixes
On Fri, Dec 16, 2016 at 03:30:01PM +0100, Ladi Prosek wrote: > This series was prompted by the issue reported in: > http://lists.ipxe.org/pipermail/ipxe-devel/2016-December/005317.html > > As it turns out, neither legacy nor modern iPXE virtio implementation > currently works well with queue sizes >256. > > In patch 1, modern virtio is fixed to correctly negotiate the queue > size. In patch 4, legacy virtio is fixed to accept whatever queue size > is declared by the host. Acked-by: Michael S. Tsirkin > src/drivers/bus/virtio-pci.c | 70 > +- > src/drivers/net/virtio-net.c | 31 --- > src/include/ipxe/virtio-pci.h | 2 ++ > src/include/ipxe/virtio-ring.h | 12 +++- > 4 files changed, 75 insertions(+), 40 deletions(-) > > Thanks! > Ladi ___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
