Re: [ipxe-devel] [ipxe/ipxe] enable bin/ipxe.iso target to build on FreeBSD (#42)
@dyeske commented on this pull request. > @@ -95,6 +95,8 @@ SYSLINUX_DIR_LIST := \ /usr/share/syslinux/modules/bios \ /usr/local/share/syslinux \ /usr/local/share/syslinux/bios \ + /usr/local/share/syslinux/bios/core \ + /usr/local/share/syslinux/bios/com32/elflink/ldlinux \ That was on my fork locally for a long time. -- Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/42#discussion_r798093592 You are receiving this because you commented. Message ID: ___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo/ipxe-devel
Re: [ipxe-devel] [ipxe/ipxe] enable bin/ipxe.iso target to build on FreeBSD (#42)
Closed #42. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/42#event-4268487577___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo/ipxe-devel
Re: [ipxe-devel] [ipxe/ipxe] enable bin/ipxe.iso target to build on FreeBSD (#42)
This has been forward-ported and merged as https://github.com/ipxe/ipxe/commit/9557497e7 and https://github.com/ipxe/ipxe/commit/25b675c3d Thank you! -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/42#issuecomment-770112583___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo/ipxe-devel
Re: [ipxe-devel] [ipxe/ipxe] enable bin/ipxe.iso target to build on FreeBSD (#42)
@mcb30 commented on this pull request.
> @@ -120,7 +120,7 @@ case "${LEGACY}" in
;;
0)
# copy isolinux bootloader
- cp ${ISOLINUX_BIN} ${dir}
+ install -m 644 ${ISOLINUX_BIN} ${dir}
Merged (in the replacement `util/genfsimg`) as
https://github.com/ipxe/ipxe/commit/25b675c3d
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/42#pullrequestreview-579694643___
ipxe-devel mailing list
ipxe-devel@lists.ipxe.org
https://lists.ipxe.org/mailman/listinfo/ipxe-devel
Re: [ipxe-devel] [ipxe/ipxe] enable bin/ipxe.iso target to build on FreeBSD (#42)
@mcb30 commented on this pull request. > @@ -58,19 +58,19 @@ NON_AUTO_MEDIA+= iso %iso: %lkrn util/geniso $(QM)$(ECHO) " [GENISO] $@" $(Q)ISOLINUX_BIN=$(ISOLINUX_BIN) LDLINUX_C32=$(LDLINUX_C32) \ - VERSION="$(VERSION)" bash util/geniso -o $@ $< + VERSION="$(VERSION)" bash -e util/geniso -o $@ $< `util/geniso` and `util/gensdsk` have been replaced with `util/genfsimg` which already includes a `set -e` within the script itself. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/42#pullrequestreview-579694405___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo/ipxe-devel
Re: [ipxe-devel] [ipxe/ipxe] enable bin/ipxe.iso target to build on FreeBSD (#42)
@mcb30 commented on this pull request. > @@ -95,6 +95,8 @@ SYSLINUX_DIR_LIST := \ /usr/share/syslinux/modules/bios \ /usr/local/share/syslinux \ /usr/local/share/syslinux/bios \ + /usr/local/share/syslinux/bios/core \ + /usr/local/share/syslinux/bios/com32/elflink/ldlinux \ Merged (in the replacement `util/genfsimg`) as https://github.com/ipxe/ipxe/commit/9557497e7 -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/42#pullrequestreview-579692599___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo/ipxe-devel
