The patch attached should fix the build error. Untested since I do not have GCC
5.4.
Best regards,
Martin
On 07/11/16 08:49, Bjørn Forsman wrote:
> Hi iPXE developers,
>
> I'd like to report a build issue:
>
> $ make -C src
> [...]
> [BUILD] bin/etherfabric.o
> In file included from drivers/net/etherfabric.c:36:0:
> drivers/net/etherfabric.c: In function ‘falcon_init_xmac’:
> drivers/net/etherfabric.h:524:7: error: ‘reg.u32[0]’ may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
>| EFAB_INSERT_FIELD32 ( 0, 31, field, value ) ); \
>^
> drivers/net/etherfabric.c:2213:15: note: ‘reg.u32[0]’ was declared here
> efab_dword_t reg;
>^
> cc1: all warnings being treated as errors
> make: *** [Makefile.housekeeping:916: bin/etherfabric.o] Error 1
>
> This is on NixOS with GCC 5.4. Another issue that happens on NixOS is
> that "echo" isn't located in /bin. Could you either lookup "echo" in
> $PATH or use printf? (AFAIK, printf is more portable than echo, see
> http://unix.stackexchange.com/questions/65803/why-is-printf-better-than-echo.)
>
> Best regards,
> Bjørn Forsman
> ___
> ipxe-devel mailing list
> ipxe-devel@lists.ipxe.org
> https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
>
The information contained in this message is confidential and is intended for
the addressee(s) only. If you have received this message in error, please
notify the sender immediately and delete the message. Unless you are an
addressee (or authorized to receive for an addressee), you may not use, copy or
disclose to anyone this message or any information contained in this message.
The unauthorized use, disclosure, copying or alteration of this message is
strictly prohibited.
diff --git a/src/drivers/net/etherfabric.c b/src/drivers/net/etherfabric.c
index 2cd41d4cab51..fa696694639a 100644
--- a/src/drivers/net/etherfabric.c
+++ b/src/drivers/net/etherfabric.c
@@ -2210,7 +2210,7 @@ falcon_reset_xaui ( struct efab_nic *efab )
static int
falcon_xaui_link_ok ( struct efab_nic *efab )
{
- efab_dword_t reg;
+ efab_dword_t reg = { 0 };
int align_done, lane_status, sync;
int has_phyxs;
int link_ok = 1;
___
ipxe-devel mailing list
ipxe-devel@lists.ipxe.org
https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
