Re: [Ironruby-core] Code Review: Thread#raise

2009-01-05 Thread Shri Borde
Warning sounds reasonable for Thread#kill and Thread#raise. FWIW, Mongrel and webbrick do use Thread#kill to kill a background thread. Thread.critical= can actually be used in a sane way for simple synchronization, like the lock keyword in C#. This is used much more widely, and a warning for

Re: [Ironruby-core] Code Review: Thread#raise

2009-01-05 Thread Charles Oliver Nutter
kill and raise might be a bit of a bother if you add warnings, since they're used in several libraries without any good replacement other than reimpl (usually to interrupt stuck IO operations). But yeah, I'd be on board with an across-the-board Thread.critical= warning in both JRuby and

[Ironruby-core] Code Review: Thread.critical

2009-01-05 Thread Shri Borde
tfpt review /shelveset:critical;REDMOND\sborde Microsoft.Scripting.dll: Fix to interpreter to get better stack trace even when call-site caching kicks in. The try-catch needs to be added to all code that can throw an exception in the interpreter (or preferably in one function like

Re: [Ironruby-core] Code Review: Thread#raise

2009-01-05 Thread Shri Borde
I replied before seeing this... Taking a sampling of a few gems, I think it should actually be the other way. Mongrel and webbrick do use Thread#kill to kill a background thread, but other gems do not. Thread#raise was also used in just a couple of places to raise a timeout error. And it is

Re: [Ironruby-core] Error retrieving from github

2009-01-05 Thread Colin Jack
Jirapong Nanta wrote: Hi Colin, You might want to check with this guide http://github.com/guides/getting-a-copy-of-your-github-repo first. Hope this helps, -Jirapong Ta for the link, done all that now but same error. However ssh -v g...@github.com failed so I'm guessing it must be

Re: [Ironruby-core] Loading Assemblies

2009-01-05 Thread Ben Hall
I'm back in the office so decided to give this another go. The problem is, it appears to keep attempting to load a particular assembly, resulting in a stackoverflowexception. The method Assembly.load_from(path) never appears to return. I've tried to put a (if already saw then don't load) but I

Re: [Ironruby-core] Error retrieving from github

2009-01-05 Thread jirapong.na...@gmail.com
Hi Colin, You might want to check with this guide http://github.com/guides/getting-a-copy-of-your-github-repo first. Hope this helps, -Jirapong On Jan 5, 2009, at 5:47 PM, Colin Jack wrote: Hi, I've been trying to get IronRuby from GIT using the steps in Ben's blog

[Ironruby-core] ASP.NET integration ?

2009-01-05 Thread Ivan Porto Carrero
As my chapter on Rails is coming to an end I'd like to find out how things are going for ASP.NET webforms or asp.net MVC integration. Do you guys have an idea as to when we could expect something like this? --- Met vriendelijke groeten - Best regards - Salutations Ivan Porto Carrero GSM:

Re: [Ironruby-core] Code Review: Thread.critical

2009-01-05 Thread Curt Hagenlocher
The implementation of ThreadOps._CriticalMonitor and ThreadOps._IsInCriticalRegion as class-level fields will cause state information to leak between ScriptRuntimes. These should probably be put on the RubyContext, which can either be done directly or by using

Re: [Ironruby-core] Thread.key failure

2009-01-05 Thread Shri Borde
OK, atleast I know its not me. From: Jim Deville Sent: Monday, January 05, 2009 3:47 PM To: Shri Borde Subject: RE: Thread.key failure Fails for me on CRuby 186p287 JD From: Shri Borde Sent: Monday, January 05, 2009 3:45 PM To: Jim Deville Subject: Thread.key failure Could you try running

Re: [Ironruby-core] Code Review: Thread.critical

2009-01-05 Thread Shri Borde
Good catch. I have fixed the issue. Also updated the tests according to Jim's suggestions. Also, the last test using Thread.kill was wrong but seemed to succeed since flunk fails silently when used on the non-main thread. New patch included if you want to take a look. Will go ahead and submit