http://github.com/jschementi/ironruby/commit/bbfa3c4a35cc331e58fb9da9a4097de86ed0dbff
autoload uses '/' to join load-path and autoload-path.
Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=674
This makes Rails 2.3.2 startup without any modifications! =)
Changes:
-
Merlin/Extern
Daniele,
If you push this out tonight, I'll pull it in tomorrow.
JD
> -Original Message-
> From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-
> boun...@rubyforge.org] On Behalf Of Shri Borde
> Sent: Monday, April 20, 2009 9:58 PM
> To: ironruby-core@rubyforge.org
> Subject:
Test looks good.
JD
From: Tomas Matousek
Sent: Monday, April 20, 2009 9:32 AM
To: Shri Borde; IronRuby External Code Reviewers
Cc: ironruby-core@rubyforge.org
Subject: RE: Review: Array#hash and irtests.bat
Re RubyArray.Equals(object)/GetHashCode: is it desirable to use value equality
here? The
Looks great!
Could you copy the comment "# MRI follows hashing semantics here, so doesn't
actually call eql?/hash for Fixnum/Symbol" from core\array\minus_spec.rb to
IListOps.Difference as its not obvious why the code in IListOps.Difference does
the complicated checks.
Yes, it seems OK that yo
Looks great!
From: ironruby-core-boun...@rubyforge.org
[mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of
jirapong.na...@gmail.com
Sent: Monday, April 20, 2009 4:19 PM
To: ironruby-core@rubyforge.org
Subject: Re: [Ironruby-core] File.new spec fixes
http://github.com/Jirapong/ironruby/co
Mspec seems to be returning the wrong exitcode when used from irtests.bat. The
first mspec command which runs the core tests has failures in Module#autoload
but sets errorlevel to 0. And the second command has no failures but sets
errorlevel to 1. When I try out some mspec commands manually, the
Comment left on Github:
Can you move the fixtures up a level and combine them? (Put them in
rubyspec/fixtures instead of rubyspec/command_line/fixtures and
rubyspec/language/fixtures)
Also, shouldn't we move Glob.CanonicalizePath to a more central location, then
use that central location for b
http://github.com/Jirapong/ironruby/commit/e5dfbef094e4712d8859f5cda142b608dafe3b16
Makes Code refactor as reviewed. see inline answer.
Files changed:
• Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/
core/kernel/open_spec.rb
• Merlin/Main/Languages/Ruby/Libraries.
http://github.com/jschementi/ironruby/commit/3ef1b6ac9718d0c55796c2818da797ea8bab7275
Makes __FILE__ and $PROGRAM_NAME (and $0) have canonicalized paths when Ruby is
hosted from ir.exe. However, __FILE__ is not messed with when including a file
via require/load. Fixes
http://ironruby.codeplex.c
Re RubyArray.Equals(object)/GetHashCode: is it desirable to use value equality
here? These methods are only used from .NET libraries - e.g. if the array is
added into a dictionary as a key. Unless RubyArray is bound to a runtime its
.NET hash/equality implementation won't be the same as Ruby's (
Good point, and I guess there is no real reason for doing that... it
wasn't really an attempt to achieve optimization, it just turned out
like that as I honestly totally missed the case of already unique
lists :-) Adjustments scheduled for the next push of my commits.
On Sun, Apr 19, 2009 at 01:10
11 matches
Mail list logo
