Re: [Ironruby-core] Code Review: firewallwarning

2009-05-04 Thread Jim Deville
It is. The test is fully local. -Original Message- From: Jimmy Schementi Sent: Monday, May 04, 2009 10:04 PM To: Jim Deville; IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: RE: Code Review: firewallwarning This if fine as long as only this machine hits the serve

Re: [Ironruby-core] Code Review: firewallwarning

2009-05-04 Thread Jimmy Schementi
This if fine as long as only this machine hits the server ... > -Original Message- > From: Jim Deville > Sent: Monday, May 04, 2009 9:59 PM > To: IronRuby External Code Reviewers > Cc: ironruby-core@rubyforge.org > Subject: Code Review: firewallwarning > > RESENDING with diff: > tfpt revi

[Ironruby-core] Code Review: irinfo

2009-05-04 Thread Jim Deville
tfpt review "/shelveset:irinfo;REDMOND\jdeville" Comment : Tag and other changes to get ironruby.info running again. Also fixes crmail to work with new Merlin External path. irinfo.diff Description: irinfo.diff ___ Ironruby-core mailing list I

[Ironruby-core] Code Review: firewallwarning

2009-05-04 Thread Jim Deville
RESENDING with diff: tfpt review "/shelveset:firewallwarning;REDMOND\jdeville" Comment : This simple change fixes a firewall warning that gets kicked up in the test lab. The change is simply to change the listening address from 0.0.0.0 (bind on all addresses) to 127.0.0.1 (loopback). fi

[Ironruby-core] Code Review: irinfo

2009-05-04 Thread Jim Deville
tfpt review "/shelveset:irinfo;REDMOND\jdeville" Comment : Tag and other changes to get ironruby.info running again. irinfo.diff Description: irinfo.diff ___ Ironruby-core mailing list Ironruby-core@rubyforge.org http://rubyforge.org/mailman/li

[Ironruby-core] Code Review: firewallwarning

2009-05-04 Thread Jim Deville
tfpt review "/shelveset:firewallwarning;REDMOND\jdeville" Comment : This simple change fixes a firewall warning that gets kicked up when running Net::HTTP specs. The change is simply to change the listening address from 0.0.0.0 (bind on all addresses) to 127.0.0.1 (loopback). firewallw

Re: [Ironruby-core] Clr Interop and private member variables

2009-05-04 Thread Tomas Matousek
PrivateBinding doesn't mostly work in IronRuby yet (we will fix that). Note that the call to a private method/reading a private field will be much slower than if it was public. Also, it won't work in partial trust (anywhere where your app is not granted full access to all .NET features, like in

Re: [Ironruby-core] Clr Interop and private member variables

2009-05-04 Thread Curt Hagenlocher
Yes, that's right. As Jim said, you can use -X:PrivateBinding to work around this, but I don't remember if this has any other consequences. From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Orion Edwards Sent: Monday, May 04, 2009 4:57 PM To: iro

Re: [Ironruby-core] Clr Interop and private member variables

2009-05-04 Thread Jim Deville
If you don't mind running debug, you can also use -X:PrivateBindings -Original Message- From: Curt Hagenlocher Sent: May 04, 2009 4:41 PM To: ironruby-core@rubyforge.org Subject: Re: [Ironruby-core] Clr Interop and private member variables Make it protected instead of private? From: i

Re: [Ironruby-core] Clr Interop and private member variables

2009-05-04 Thread Orion Edwards
It's not my code :-) It appears as though "extending" a class in ruby is more or less the same as creating a derived class... is this right? Might have to convince the other guy that "restricted by default" is not the best philosophy... On Tue, May 5, 2009 at 11:34 AM, Curt Hagenlocher wrote: >

Re: [Ironruby-core] Clr Interop and private member variables

2009-05-04 Thread Curt Hagenlocher
Make it protected instead of private? From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Orion Edwards Sent: Monday, May 04, 2009 4:32 PM To: ironruby-core@rubyforge.org Subject: [Ironruby-core] Clr Interop and private member variables I have the

[Ironruby-core] Clr Interop and private member variables

2009-05-04 Thread Orion Edwards
I have the following C# class namespace MyNamespace { public class MyObject { private string m_Name; } } and I'm extending it from IronRuby class MyNameSpace::MyObject def printme puts m_Name end end When I try to run this, I get undefined method `m_Name' for MyNameSpace::MyObj

Re: [Ironruby-core] Time class instance

2009-05-04 Thread jirapong.na...@gmail.com
Hello Shri, Because the spec passed by accident, I was checked result by this code snippet require 'time' t1 = (Time.utc(1976, 8, 26, 14, 30) + 4 * 3600) t2 = Time.rfc2822("26 Aug 76 14:30 EDT") puts "#{t1} == #{t2}? #{t1==t2}" MRI: Thu Aug 26 18:30:00 UTC 1976 == Fri Aug 27 01:30:00 +0700

Re: [Ironruby-core] TypeError thrown in DynamicMetaObjectBinder.Bind

2009-05-04 Thread Daniele Alessandri
Hi Tomas, 1) Oh, I see. I didn't know that, and the fact that it was working with previous versions of IR just misleaded me. 2) Indeed, I know it was wrong to create a new site on each invocation and that's exactly why I'm reviewing the oldest bits of code that actually interact with IronRuby to c

Re: [Ironruby-core] TypeError thrown in DynamicMetaObjectBinder.Bind

2009-05-04 Thread Tomas Matousek
A couple of issues: 1) As Shri said, the return type of a site must be Object. 2) You shouldn't be creating a new site (and also not a shared one) in each invocation of the method. Instead, use one of the CallSiteStorages defined in CallSiteStorages.cs as the first parameter. You can search in th

Re: [Ironruby-core] Time class instance

2009-05-04 Thread jirapong.na...@gmail.com
Hello Shri, Thank you very much for code review. It is make sense about constructors and ToString methods. I will work on it. p.s. please delete bug #1021 for me. Thank you, -Jirapong On May 4, 2009, at 2:15 PM, Shri Borde wrote: The approach looks good. I have some comments though... Yo

Re: [Ironruby-core] clr events in ruby

2009-05-04 Thread Curt Hagenlocher
Sorry... I just looked at the source code and events are indeed not implemented yet. I promised Tomas I'd try really really hard to finish the typegen code this month, so you shouldn't have to wait too long. From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org]

Re: [Ironruby-core] clr events in ruby

2009-05-04 Thread Mark Ryall
No dice i'm afraid: with 'add_my_event': Snippets.scripting:0:in `add_MyEvent': undefined method `add_MyEvent' for IronRuby.Classes.Object$5:ClassWithEvent (NoMethodError) from ClassLibrary:0:in `RegisterEvent' from experiment1.rb:90 with 'add_MyEvent': Snippets.scripting:0:in `a

Re: [Ironruby-core] clr events in ruby

2009-05-04 Thread Curt Hagenlocher
I believe that this should work, but the name would need to be Rubified as "add_my_event". From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Mark Ryall Sent: Monday, May 04, 2009 6:02 AM To: ironruby-core@rubyforge.org Subject: [Ironruby-core] cl

[Ironruby-core] clr events in ruby

2009-05-04 Thread Mark Ryall
Hi everyone, I'm messing around with trying to create ironruby mock (actually recorder) implementations of various sorts of CLR type features and am struggling with events. Is it currently possible to create an implementation of a CLR interface that contains an event? For example using System;

Re: [Ironruby-core] Rails ActionPack and ActiveSupport tests

2009-05-04 Thread Shri Borde
I tried running the ActiveSupport tests. The results tally is : 1659 tests, 154 errors and failures The log is at http://gist.github.com/106363 if you want to see the kinds of failures IronRuby runs into. Instructions for running the tests is at the bottom of http://www.ironruby

Re: [Ironruby-core] Time class instance

2009-05-04 Thread Shri Borde
Why did you need to disable two examples in rfc2822_spec.rb? We should not be disabling tests that worked before without a very good reason. You added a test for Time.utc. That should actually be in the second describe block in the same file for Time#utc. The (grammatically correct) name of the

Re: [Ironruby-core] Time class instance

2009-05-04 Thread Shri Borde
The approach looks good. I have some comments though... You should do a search for "DateTime" in the code base to find all the places that might need updating. For example, Yaml.DateTimeOps needs to be changed (is there no spec for it?), and Converter.IsIntegral might need to be. RubyDateTime s