Re: [Ironruby-core] Code Review: Various .NET interop tests

2009-03-27 Thread Jimmy Schementi
Looks good to me. I left comments where appropriate, but nothing stopping you from checking in. From: Jim Deville Sent: Friday, March 27, 2009 11:40 AM To: IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: Code Review: Various .NET interop tests This is one of the weak a

Re: [Ironruby-core] Code Review: Various .NET interop tests

2009-03-27 Thread Jim Deville
Cool. As part of pulling this into TFS, I'm going to add ClrAssembly to Ruby.sln so that we build it from VS. JD From: Jimmy Schementi Sent: Friday, March 27, 2009 1:22 PM To: Jim Deville; IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: RE: Code Review: Various .NET int

[Ironruby-core] Code Review: Various .NET interop tests

2009-03-27 Thread Jim Deville
This is one of the weak areas for our Git setup. I have multiple commits that need review. I honestly feel that Git needs the concept of a push object, so I could say look at this, or these pushes. So, options to help you review: * Click on each of these links and leave comments *