http://github.com/jschementi/ironruby/commit/43514f8f9e980ba22dfb5b8661e5633661f50d1f
Remove Glob.CanonicalizePath (in favor of RubyUtils.CanonicalizePath)
-
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs
- Merlin/Main/Languages/Ruby/Ruby/Builtins/Glo
Looks good.
Tomas
From: Jimmy Schementi
Sent: Wednesday, April 22, 2009 10:56 AM
To: Tomas Matousek; Jim Deville; ironruby-core@rubyforge.org
Cc: IronRuby External Code Reviewers
Subject: RE: Code Review: __FILE__ and $PROGRAM_NAME paths
http://github.com/jschementi/ironruby/commit/43514f8f9e980
Could you remove
public static MutableString/*!*/ CanonicalizePath(MutableString/*!*/ path) {
return RubyUtils.CanonicalizePath(path);
}
from Glob and call RubyUtils directly wherever Glob.CanonicalizePath is used?
Other than that looks good.
Tomas
From: Jimmy Schementi
Sent: Tuesday, Apri
http://github.com/jschementi/ironruby/commit/57d18b591ba9cba92923864936f359de446e2f97
Code Review changes
- Moves command_line/fixtures/file* and language/fixtures/file* to fixtures/
- Create RubyUtils.CanonicalizePath, to dependency on IronRuby.Builtins.Glob
from IronRuby.Hosting
*
Merlin/
Comment left on Github:
Can you move the fixtures up a level and combine them? (Put them in
rubyspec/fixtures instead of rubyspec/command_line/fixtures and
rubyspec/language/fixtures)
Also, shouldn't we move Glob.CanonicalizePath to a more central location, then
use that central location for b
http://github.com/jschementi/ironruby/commit/3ef1b6ac9718d0c55796c2818da797ea8bab7275
Makes __FILE__ and $PROGRAM_NAME (and $0) have canonicalized paths when Ruby is
hosted from ir.exe. However, __FILE__ is not messed with when including a file
via require/load. Fixes
http://ironruby.codeplex.c
