Re: [Ironruby-core] Code Review: gems

2010-03-09 Thread Jim Deville
Looks good. We should probably make the same change in the Excel specs, but that isn't pressing. -Original Message- From: Shri Borde Sent: Tuesday, March 09, 2010 10:41 AM To: IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: Code Review: gems tfpt review "/sh

Re: [Ironruby-core] Code Review: gems

2010-03-09 Thread Shri Borde
Actually, the change in platform.rb is a nop as the string "universal-.net" will get converted to a Gem::Platform before comparsion. I will undo this change. We could consider adding a case for the string ".net" if we wanted, but I will leave that for later. -Original Message- From: Shr

[Ironruby-core] Code Review: gems

2010-03-09 Thread Shri Borde
tfpt review "/shelveset:gems;REDMOND\sborde" Comment : When installing gems from a remote server that is using MRI, the gem information that is sent down to the local machine is incorrect since MRI is not able to parse the platform string of "universal-.net" until a patch is applie