, 2008 3:31 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core@rubyforge.org; Martin Maly
Subject: [Ironruby-core] Code Review: gitintegration2
tfpt review "/shelveset:gitintegration2;REDMOND\jdeville"
Comment :
Context.rb
* Add helpers for mono and rake version
* changed t
Code Reviewers
Cc: Martin Maly
Subject: Re: [Ironruby-core] Code Review: gitintegration2
Reviewed with Jimmy on IRC.
-Original Message-
From: ironruby-core-boun...@rubyforge.org
[mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Jim Deville
Sent: Monday, December 15, 2008 3:32 PM
To: Iro
: [Ironruby-core] Code Review: gitintegration2
tfpt review "/shelveset:gitintegration2;REDMOND\jdeville"
Comment :
Context.rb
* Add helpers for mono and rake version
* changed the is_test? method to rely on the presence of the test environment
variable instead of the v
tfpt review "/shelveset:gitintegration2;REDMOND\jdeville"
Comment :
Context.rb
* Add helpers for mono and rake version
* changed the is_test? method to rely on the presence of the test environment
variable instead of the value of it.
git.rake
* refactor to_git
* added from_git, gi