Re: [Ironruby-core] Code Review: partial1

2008-06-26 Thread Srivatsn Narayanan
It's the one in the test. There is a snap timeout as well but that is the for the entire task. That shouldn't have to change. -Original Message- From: Jim Deville Sent: Thursday, June 26, 2008 1:23 PM To: Srivatsn Narayanan; IronRuby External Code Reviewers Cc: [email protected]

Re: [Ironruby-core] Code Review: partial1

2008-06-26 Thread Jim Deville
What's the timeout for generic tests? Is it the one in the test? Or does Snap have a limit? JD > -Original Message- > From: Srivatsn Narayanan > Sent: Thursday, June 26, 2008 11:11 AM > To: Jim Deville; IronRuby External Code Reviewers > Cc: [email protected] > Subject: RE: R

Re: [Ironruby-core] Code Review: partial1

2008-06-26 Thread Srivatsn Narayanan
Looks good. Make sure that the generic test won't timeout since the running time has effectively doubled. Also, in the batch file, you could use pushd %ROWAN_BIN% and then popd instead of storing CURRENT. -Original Message- From: Jim Deville Sent: Thursday, June 26, 2008 10:57 AM To: Sri

Re: [Ironruby-core] Code Review: partial1

2008-06-26 Thread Jim Deville
Fixed. Try again. JD > -Original Message- > From: Srivatsn Narayanan > Sent: Thursday, June 26, 2008 10:41 AM > To: Jim Deville; IronRuby External Code Reviewers > Cc: [email protected] > Subject: RE: Code Review: partial1 > > Did you forget to include irtest.bat? I don't see

Re: [Ironruby-core] Code Review: partial1

2008-06-26 Thread Srivatsn Narayanan
Did you forget to include irtest.bat? I don't see it already checked in. Also RowanTest.* files don't have any changes. You can undo them. -Original Message- From: Jim Deville Sent: Thursday, June 26, 2008 9:10 AM To: IronRuby External Code Reviewers; Srivatsn Narayanan Cc: ironruby-core@

[Ironruby-core] Code Review: partial1

2008-06-26 Thread Jim Deville
tfpt review "/shelveset:partial1;REDMOND\jdeville" Comment : Run IronRuby.test.exe under regular and partial trust in snap. partial1.diff Description: partial1.diff ___ Ironruby-core mailing list [email protected] http://rubyforge.org/mai

[Ironruby-core] Code Review: Partial1

2008-06-11 Thread Tomas Matousek
tfpt review "/shelveset:Partial1;REDMOND\tomat" Adds /partial mode to IronRuby unit tests. If specified, the harness will run tests in an app-domain that has restricted permissions. Simple DLR changes: Snippet assembly needs to be marked by SecurityTransparent attribute in order to w