Re: [Ironruby-core] More fixes for core/array specs (again)

2009-04-21 Thread Jim Deville
;s changes) JD > -Original Message- > From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core- > boun...@rubyforge.org] On Behalf Of Daniele Alessandri > Sent: Tuesday, April 21, 2009 11:43 AM > To: ironruby-core@rubyforge.org > Subject: Re: [Ironruby-core] More fixes for

Re: [Ironruby-core] More fixes for core/array specs (again)

2009-04-21 Thread Daniele Alessandri
tomorrow. >> >> JD >> >>> -Original Message- >>> From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core- >>> boun...@rubyforge.org] On Behalf Of Shri Borde >>> Sent: Monday, April 20, 2009 9:58 PM >>> To: ironruby-core@rubyforge.

Re: [Ironruby-core] More fixes for core/array specs (again)

2009-04-21 Thread Daniele Alessandri
ere would be a possibility of confusion, but as you say, there is not much > that can be done. It does not seem worth special-casing. > > Thanks, > Shri > > > -Original Message- > From: ironruby-core-boun...@rubyforge.org > [mailto:ironruby-core-boun...@rubyforge.org

Re: [Ironruby-core] More fixes for core/array specs (again)

2009-04-21 Thread Daniele Alessandri
l it in tomorrow. > > JD > >> -Original Message- >> From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core- >> boun...@rubyforge.org] On Behalf Of Shri Borde >> Sent: Monday, April 20, 2009 9:58 PM >> To: ironruby-core@rubyforge.org >>

Re: [Ironruby-core] More fixes for core/array specs (again)

2009-04-20 Thread Jim Deville
yforge.org > Subject: Re: [Ironruby-core] More fixes for core/array specs (again) > > Looks great! > > Could you copy the comment "# MRI follows hashing semantics here, so > doesn't actually call eql?/hash for Fixnum/Symbol" from > core\array\minus_spec.rb to

Re: [Ironruby-core] More fixes for core/array specs (again)

2009-04-20 Thread Shri Borde
worth special-casing. Thanks, Shri -Original Message- From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Daniele Alessandri Sent: Monday, April 20, 2009 12:46 PM To: ironruby-core@rubyforge.org Subject: [Ironruby-core] More fixes for c

Re: [Ironruby-core] More fixes for core/array specs

2009-04-20 Thread Daniele Alessandri
.org > [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Daniele Alessandri > Sent: Saturday, April 18, 2009 3:39 PM > To: ironruby-core@rubyforge.org > Subject: Re: [Ironruby-core] More fixes for core/array specs > > Hi, > > just a self-reply to point out that the

Re: [Ironruby-core] More fixes for core/array specs

2009-04-18 Thread Shri Borde
ril 18, 2009 3:39 PM To: ironruby-core@rubyforge.org Subject: Re: [Ironruby-core] More fixes for core/array specs Hi, just a self-reply to point out that the changes in ArrayOps.ToArray introduced a regression for Array#to_ary (reported by core/array/to_ary) due to the different behaviour of Array#t

Re: [Ironruby-core] More fixes for core/array specs

2009-04-18 Thread Daniele Alessandri
Hi, just a self-reply to point out that the changes in ArrayOps.ToArray introduced a regression for Array#to_ary (reported by core/array/to_ary) due to the different behaviour of Array#to_a and Array#to_ary on subclasses of Array. I have already fixed this on my local repository, I'm just waiting

[Ironruby-core] More fixes for core/array specs

2009-04-18 Thread Daniele Alessandri
Hi, http://github.com/nrk/ironruby/commit/4afc7f1bc44b007a9dca30e6330eca35d487f165 This commit resolves the following failing specs: Array#<=> properly handles recursive arrays (critical) Array#initialize with (size, object=nil) uses the block value instead of using the default value Array#to_a