Re: [Ironruby-core] Review: GzipWriter.open

2009-04-07 Thread Shri Borde
The following Ruby code prints "to_int". So checking for to_int seems to be correct, right? class C def to_int puts "to_int" 0 end def to_i puts "to_i" 0 end end [].at(C.new) Thanks, Shri From: Jim Deville Sent: Tuesday, April 07, 2009 1:25 PM To: Shri Borde; IronRuby Exte

Re: [Ironruby-core] Review: GzipWriter.open

2009-04-07 Thread Jim Deville
My bad. These look fine as is then. jD -Original Message- From: Shri Borde Sent: April 07, 2009 1:47 PM To: Jim Deville ; IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: RE: Review: GzipWriter.open The following Ruby code prints “to_int”. So checking for to

Re: [Ironruby-core] Review: GzipWriter.open

2009-04-07 Thread Tomas Matousek
Looks good. Tomas From: Shri Borde Sent: Tuesday, April 07, 2009 1:09 PM To: IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: Review: GzipWriter.open http://github.com/shri/ironruby/commit/fb6f89146e331a9f20f444d5ca94478dfce7f555 GitDiff.bat 9fc3048beb4a315ec7ac3dc82908d

Re: [Ironruby-core] Review: GzipWriter.open

2009-04-07 Thread Jim Deville
+ it "raises TypeError unless the arguments are exactly a String, Fixnum and Fixnum" do +filename = mock("filename") +filename.should_not_receive(:to_s) +lambda { Zlib::GzipWriter.open(filename) }.should raise_error(TypeError) + +level = mock("level") +level.should_not_receive

[Ironruby-core] Review: GzipWriter.open

2009-04-07 Thread Shri Borde
http://github.com/shri/ironruby/commit/fb6f89146e331a9f20f444d5ca94478dfce7f555 GitDiff.bat 9fc3048beb4a315ec7ac3dc82908da8f92bf1a07 fb6f89146e331a9f20f444d5ca94478dfce7f555 * Implemented Zlib::GzipWriter.open * Added Kernel.abort * Mapped Errno::EACCES to System.Unauth