Re: [Ironruby-core] Code Review: RandomRubyFixes05

2008-10-24 Thread Oleg Tkachenko
YAML changes look good too. -- Oleg -Original Message- From: Curt Hagenlocher Sent: Friday, October 24, 2008 8:23 AM To: IronRuby External Code Reviewers; Oleg Tkachenko Cc: ironruby-core@rubyforge.org Subject: Code Review: RandomRubyFixes05 tfpt review "/shelveset:RandomRubyFixes05;REDM

Re: [Ironruby-core] Code Review: RandomRubyFixes05

2008-10-24 Thread Tomas Matousek
Looks good. There is a minor formatting glitch in RubyUtils: return new RubyCompilerOptions(targetScope.ExecutionContext.Context.RubyOptions) { } (the opening brace on a new line). I guess you need to set this in VS formatting options. Tomas -Origi