Re: [Ironruby-core] Code Review: netinterop1

2009-02-25 Thread Jim Deville
PM > To: ironruby-core@rubyforge.org; IronRuby External Code Reviewers > Subject: Re: [Ironruby-core] Code Review: netinterop1 > > Do people prefer using "\" or "/" as the directory separator in Ruby > code? I prefer "/" since all existing Ruby code uses that, and Ru

Re: [Ironruby-core] Code Review: netinterop1

2009-02-25 Thread Jimmy Schementi
Do people prefer using "\" or "/" as the directory separator in Ruby code? I prefer "/" since all existing Ruby code uses that, and Ruby on windows understands it as well. Plus you don't have to play the escape-slash game when using double-quoted strings. Also, some folks might be confused at t

Re: [Ironruby-core] Code Review: netinterop1

2009-02-24 Thread Jimmy Schementi
Looks awesome. I'll get around to specing this behavior on the website shortly. ~Jimmy Sent from my phone On Feb 24, 2009, at 5:06 PM, "Jim Deville" wrote: > tfpt review "/shelveset:netinterop1;REDMOND\jdeville" > Comment : > Adds more netinterop tests related to methods. > Adds these

Re: [Ironruby-core] Code Review: netinterop1

2009-02-05 Thread Jim Deville
Narayanan Subject: Re: [Ironruby-core] Code Review: netinterop1 Sorry about the delay on this. Here are my comments: 1. Does MSpec have shared behaviors, like Rake or Bacon? If so, you should try to remove the duplication of managing engines and whatnot that you have in before/after blocks. For

Re: [Ironruby-core] Code Review: netinterop1

2009-02-04 Thread Jimmy Schementi
d == true end end Otherwise, it's a great start! > -Original Message- > From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core- > boun...@rubyforge.org] On Behalf Of Jim Deville > Sent: Friday, January 30, 2009 10:20 PM > To: ironruby-core@rubyforge.org; IronR

Re: [Ironruby-core] Code Review: netinterop1

2009-01-30 Thread Jim Deville
Srivatsn, Can you take a look? JD > -Original Message- > From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core- > boun...@rubyforge.org] On Behalf Of Jim Deville > Sent: Monday, January 26, 2009 1:03 PM > To: IronRuby External Code Reviewers; Srivatsn Narayanan > Cc: ironruby-c

Re: [Ironruby-core] Code Review: netinterop1

2009-01-26 Thread Tomas Matousek
Fixed :) Tomas -Original Message- From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Justin Bailey Sent: Monday, January 26, 2009 2:24 PM To: ironruby-core@rubyforge.org Subject: Re: [Ironruby-core] Code Review: netinterop1 On Mon, Jan

Re: [Ironruby-core] Code Review: netinterop1

2009-01-26 Thread Justin Bailey
On Mon, Jan 26, 2009 at 1:03 PM, Jim Deville wrote: > tfpt review "/shelveset:netinterop1;REDMOND\jdeville" > Comment : > More tests for .net interop. This is taking advantage of the IronRuby > selfhosting that Tomas blogged about in order to maintain Where can I find Tomas' blog? I'd like t

Re: [Ironruby-core] Code Review: netinterop1

2009-01-26 Thread Justin Bailey
The best way to answer your own question - post to a mailing list! I found a nice blogroll post by Oleg: http://www.tkachenko.com/blog/archives/000747.html Maybe someone can update the people page? I would but I haven't created an account and am pressed for time as it is ... Justin On Mon, Ja