Re: [Ironruby-core] Code review: String#unpack, Bignum and Array related stuff

2009-07-23 Thread Daniele Alessandri
boun...@rubyforge.org] On Behalf Of Daniele Alessandri > Sent: Thursday, July 23, 2009 11:38 AM > To: ironruby-core@rubyforge.org > Subject: Re: [Ironruby-core] Code review: String#unpack, Bignum and Array > related stuff > > Hi, > > Cool I didn't know [DefaultProtoco

Re: [Ironruby-core] Code review: String#unpack, Bignum and Array related stuff

2009-07-23 Thread Tomas Matousek
C.new, C.new) #=> to_ary, to_ary, to_ary > D.new.zip(C.new, C.new, C.new) #=> to_a, to_a, to_a > > Tomas > > -Original Message- > From: ironruby-core-boun...@rubyforge.org > [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Shri Borde > Sent: Wednesday,

Re: [Ironruby-core] Code review: String#unpack, Bignum and Array related stuff

2009-07-23 Thread Daniele Alessandri
; to_ary, to_ary, to_ary > D.new.zip(C.new, C.new, C.new) #=> to_a, to_a, to_a > > Tomas > > -Original Message- > From: ironruby-core-boun...@rubyforge.org > [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Shri Borde > Sent: Wednesday, July 22, 2009 2:52 PM >

Re: [Ironruby-core] Code review: String#unpack, Bignum and Array related stuff

2009-07-22 Thread Tomas Matousek
org Subject: Re: [Ironruby-core] Code review: String#unpack, Bignum and Array related stuff Looks good. In Array#zip, you prefer casting to IList, and use Protocols.TryCastToArray as a fallback. Is that correct? If an IList object defines to_a, shouldn't to_a get called? The array argument

Re: [Ironruby-core] Code review: String#unpack, Bignum and Array related stuff

2009-07-22 Thread Shri Borde
Shri -Original Message- From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Daniele Alessandri Sent: Wednesday, July 22, 2009 1:51 PM To: ironruby-core@rubyforge.org Subject: Re: [Ironruby-core] Code review: String#unpack, Bignum and

Re: [Ironruby-core] Code review: String#unpack, Bignum and Array related stuff

2009-07-22 Thread Daniele Alessandri
Just a quick note: updated with http://github.com/nrk/ironruby/commit/82feca718fc17ad45747ca45a1c92250abfcfce0 On Sun, Jul 19, 2009 at 11:29, Daniele Alessandri wrote: > Hi > first of all I am trying a different approach to submitting my > patches: I created a code_review branch on my repository i