Looks great!
From: ironruby-core-boun...@rubyforge.org
[mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of
jirapong.na...@gmail.com
Sent: Monday, April 20, 2009 4:19 PM
To: ironruby-core@rubyforge.org
Subject: Re: [Ironruby-core] File.new spec fixes
http://github.com/Jirapong/ironruby
Sent: Saturday, April 18, 2009 1:35 PM
To: ironruby-core@rubyforge.org
Subject: Re: [Ironruby-core] File.new spec fixes
Hi Shri,
Thank you for quick reply. Could you please review it
at af4acea ?
Note: VS.NET ProductVersion seems to be difference on my machine.
Thank you,
-Jirapon
ruby-core-boun...@rubyforge.org] On Behalf Of
jirapong.na...@gmail.com
Sent: Saturday, April 18, 2009 1:35 PM
To: ironruby-core@rubyforge.org
Subject: Re: [Ironruby-core] File.new spec fixes
Hi Shri,
Thank you for quick reply. Could you please review it at
af4ac
jirapong.na...@gmail.com
Sent: Friday, April 17, 2009 11:25 PM
To: ironruby-core@rubyforge.org
Subject: Re: [Ironruby-core] File.new spec fixes
Thank you for your review. please find formatted version at 9942b24
I just do a pull request for 929e07 and 9942b24.
please see my answer inline.
Thank
...@rubyforge.org
[mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of
jirapong.na...@gmail.com
Sent: Friday, April 17, 2009 11:25 PM
To: ironruby-core@rubyforge.org
Subject: Re: [Ironruby-core] File.new spec fixes
Thank you for your review. please find formatted version at
9942b24<h
Thank you for your review. please find formatted version at 9942b24
I just do a pull request for 929e07 and 9942b24.
please see my answer inline.
Thank you,
-Jirapong
On Apr 18, 2009, at 5:51 AM, Shri Borde wrote:
Some blocks are not indented as in the second line in this example.
Could yo
Some blocks are not indented as in the second line in this example. Could you
indent those please?
+lambda {
+@fh = File.new(@file, File::CREAT|File::EXCL)
+ }.should raise_error(Errno::EEXIST)
0
You added try-catch to one of the overloads of RubyFileOps.CreateFile. Could
you add it to
