Alessandri
> Sent: Wednesday, June 24, 2009 4:23 PM
>
> To: ironruby-core@rubyforge.org
> Subject: Re: [Ironruby-core] Review: fixes for Array#rindex and
> Array#reverse_each
>
>
>
> Thanks Jim!
>
>
>
> BTW currently my repository is about one month behind. I mus
to:ironruby-core@rubyforge.org>
> Subject: Re: [Ironruby-core] Review: fixes for Array#rindex and
> Array#reverse_each
>
> Hi,
>
> It seems like this patch has gone unnoticed as it didn't get any review yet so
> here I am, requesting for one :-)
>
> Thanks,
> Da
gt; boun...@rubyforge.org] On Behalf Of Daniele Alessandri
> > Sent: Wednesday, June 24, 2009 1:30 PM
> > To: ironruby-core@rubyforge.org
> > Subject: Re: [Ironruby-core] Review: fixes for Array#rindex and
> > Array#reverse_each
> >
> > Hi,
> >
> >
ore-
> boun...@rubyforge.org] On Behalf Of Daniele Alessandri
> Sent: Wednesday, June 24, 2009 1:30 PM
> To: ironruby-core@rubyforge.org
> Subject: Re: [Ironruby-core] Review: fixes for Array#rindex and
> Array#reverse_each
>
> Hi,
>
> It seems like this patch has gone unnoticed as it
Hi,
It seems like this patch has gone unnoticed as it didn't get any
review yet so here I am, requesting for one :-)
Thanks,
Daniele
On Sun, May 31, 2009 at 13:22, Daniele Alessandri wrote:
> Hi Jim,
>
> I'm a bit late but daytime work got in the way and then I was out of
> the country for two w
Hi Jim,
I'm a bit late but daytime work got in the way and then I was out of
the country for two weeks :-)
I got rid of the duplicated logic in IListOps.ReverseIndex and
ArrayOps.ReverseEach by implementing a new internal method
(IListOps.ReverseEnumerateIndexes):
http://github.com/nrk/ironruby/c
Ha! I got caught :-) The duplicated logic is there precisely because
I, too, couldn't think of a place to share that small piece of code in
a good way, so I just coded it like that for now but I'll ponder about
that for the next commit. OK for the specs.
Thanks,
Daniele
On Thu, Apr 23, 2009 at 22
Can you add specs for rindex that expose the bug you fixed? Also, is there any
shared place that you could put the following code:
if (self.Count < originalSize) {
i = originalSize - i - 1 + self.Count;
originalSize = self.Count;
}
It would be nice to g
