[Ironruby-core] Code Review: Fixes for File.dirname

2009-04-12 Thread Jimmy Schementi
Fixes for File.dirname; makes all core/file/dirname specs pass. For Rails to find log/development.log during startup. Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=499 ___ Ironruby-core mailing list Ironruby-core@rubyforge.org http://

Re: [Ironruby-core] Code Review: Fixes for File.dirname

2009-04-12 Thread Jimmy Schementi
And now with the actual review link =P http://github.com/jschementi/ironruby/commit/689aeec6046bc8ba76016f6dfa1bd947e8e3ce15 From: Jimmy Schementi Sent: Sunday, April 12, 2009 12:56 AM To: ironruby-core@rubyforge.org Cc: IronRuby External Code Reviewers Subject: Code Review: Fixes for File.dirnam

[Ironruby-core] GitDiff.bat

2009-04-12 Thread Shri Borde
GitDiff.bat just builds on top of the GIT_EXTERNAL_DIFF environment variable mentioned at http://kernel.org/pub/software/scm/git/docs/v1.0.13/git-diff-files.html. Can you do "set GIT_EXTERNAL_DIFF=echo" and then run a "git diff" command. If that runs to completion, GitDiff.bat should work as we