Re: [Ironruby-core] Review: File.expand_path

2009-06-03 Thread Jimmy Schementi
Looks good. From: Shri Borde Sent: Wednesday, June 03, 2009 11:07 AM To: ironruby-core@rubyforge.org Cc: IronRuby External Code Reviewers Subject: Review: File.expand_path http://github.com/shri/ironruby/commit/ec9eae2e12e97ab53082dbfd35d0d57b337731b3 Reimplemented File.expand_path such that it

[Ironruby-core] Review: File.expand_path

2009-06-03 Thread Shri Borde
http://github.com/shri/ironruby/commit/ec9eae2e12e97ab53082dbfd35d0d57b337731b3 Reimplemented File.expand_path such that it does not use System.IO.Path. This allows us to get better compatibility with MRI. The motivating reason was that RSpec does File.expand_path("filename:linenumber"), and the o

[Ironruby-core] CR: Rake work

2009-06-03 Thread Jim Deville
2009-06-03 rewrite irtest.bat to use Ruby instead of Batch commit 915ee4a5b60173c3a4df774339011381f85dc17c removed old t

Re: [Ironruby-core] CR: Rake work

2009-06-03 Thread Jimmy Schementi
Looks fine. From: Jim Deville Sent: Wednesday, June 03, 2009 12:11 PM To: IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: CR: Rake work 2009-06-03 rewrite irtest.bat to use Ruby instead of Batch

[Ironruby-core] Review: Misc fixes to tests

2009-06-03 Thread Shri Borde
http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1 Fix non-deterministic Rake test for "multitask" by adding semaphore.synchronize around array access Changed default.mspec so that :core properly excludes the thread tests (reviewed by Jim) * Merlin/External.LCA_

Re: [Ironruby-core] Review: Misc fixes to tests

2009-06-03 Thread Jim Deville
The rest looks good too. JD ...there is no try From: Shri Borde Sent: Wednesday, June 03, 2009 1:34 PM To: ironruby-core@rubyforge.org Cc: IronRuby External Code Reviewers Subject: Review: Misc fixes to tests http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1 Fix n

Re: [Ironruby-core] Review: Misc fixes to tests

2009-06-03 Thread Jimmy Schementi
Looks good From: Shri Borde Sent: Wednesday, June 03, 2009 1:34 PM To: ironruby-core@rubyforge.org Cc: IronRuby External Code Reviewers Subject: Review: Misc fixes to tests http://github.com/shri/ironruby/commit/4008955a15895eb0ad02fdbee257ac500a63efe1 Fix non-deterministic Rake test for "multit