Re: [isabelle-dev] illegal reflective access

2018-11-17 Thread Makarius
On 15/11/2018 22:13, Makarius wrote:
> On 15/11/2018 19:44, Lawrence Paulson wrote:
>> Got this upon launch. Is it important?
>>
>> 341ebf35464b tip
>>
>> WARNING: Illegal reflective access by macosx.MacOSXPlugin to method 
>> com.apple.eawt.FullScreenUtilities.setWindowCanFullScreen(java.awt.Window,boolean)
>> WARNING: Please consider reporting this to the maintainers of 
>> macosx.MacOSXPlugin
> 
> I am de-facto the maintainer of macosx.MacOSXPlugin -- see also
> https://sourceforge.net/p/jedit/plugin-patches/186
> 
> Here I have overlooked the dynamic access to
> com.apple.eawt.FullScreenUtilities -- it still needs to be sorted out.

I did not find a way around this, even after looking at the Java 11
sources. Maybe it is not really required (which still needs to be tested
on macOS), or there will be a replacement in a future Java release.

For now we can just ignore this particular warning about
FullScreenUtilities.setWindowCanFullScreen


We can't ignore other warnings, though.  In Isabelle/740b14b67472 I have
added --illegal-access=warn to the default Java options: it means that
warnings are not disabled after the first warning message. This can spam
or bomb the system, but hopefully we don't have too many such unclear
cases left over.


Makarius
___
isabelle-dev mailing list
isabelle-...@in.tum.de
https://mailmanbroy.informatik.tu-muenchen.de/mailman/listinfo/isabelle-dev


Re: [isabelle-dev] illegal reflective access

2018-11-15 Thread Makarius
On 15/11/2018 19:44, Lawrence Paulson wrote:
> Got this upon launch. Is it important?
> 
> 341ebf35464b tip
> 
> WARNING: Illegal reflective access by macosx.MacOSXPlugin to method 
> com.apple.eawt.FullScreenUtilities.setWindowCanFullScreen(java.awt.Window,boolean)
> WARNING: Please consider reporting this to the maintainers of 
> macosx.MacOSXPlugin

I am de-facto the maintainer of macosx.MacOSXPlugin -- see also
https://sourceforge.net/p/jedit/plugin-patches/186

Here I have overlooked the dynamic access to
com.apple.eawt.FullScreenUtilities -- it still needs to be sorted out.


Such warnings by Java 11 refer to internal things that will no longer be
accessible in the near future -- Oracle started to robustify this with
Java 9, and will become serious about it eventually. We need to
eliminate such illegal accesses one-by-one, as they occur at run-time.
Just today I've made a change in a different corner:

changeset:   69301:5a71b5145201
user:wenzelm
date:Wed Nov 14 21:43:33 2018 +0100
files:   src/Pure/General/http.scala
description:
prefer statically-typed close operation, avoid Java 11 warning: "Illegal
reflective access by scala.reflect.package$ to method
sun.net.httpserver.LeftOverInputStream.close()";


There are more fine-points about OpenJDK 11 that are still to be
discovered and sorted out. Only recently, I have noticed that the
derived italic versions of the IsabelleText font don't work -- the
current plan is to use fontforge to make a proper font instead.


Makarius
___
isabelle-dev mailing list
isabelle-...@in.tum.de
https://mailmanbroy.informatik.tu-muenchen.de/mailman/listinfo/isabelle-dev