[
https://issues.apache.org/jira/browse/AMQNET-727?focusedWorklogId=918983&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918983
]
ASF GitHub Bot logged work on AMQNET-727:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/May/24 21:54
Start Date: 12/May/24 21:54
Worklog Time Spent: 10m
Work Description: Havret commented on code in PR #37:
URL:
https://github.com/apache/activemq-nms-openwire/pull/37#discussion_r1597722159
##########
src/MessageConsumer.cs:
##########
@@ -1251,15 +1251,11 @@ public virtual async Task
AfterMessageIsConsumedAsync(MessageDispatch dispatch,
}
else if(IsClientAcknowledge || IsIndividualAcknowledge)
{
- bool messageAckedByConsumer = false;
using(await this.deliveredMessagesLock.LockAsync().Await())
{
- messageAckedByConsumer =
this.deliveredMessages.Contains(dispatch);
- }
+ if (this.deliveredMessages.Contains(dispatch))
Review Comment:
There is something messed up with the indentation here. Please add the
parentheses right below the 'if' so the intention is clear.
Issue Time Tracking
-------------------
Worklog Id: (was: 918983)
Time Spent: 1h 10m (was: 1h)
> Thread sync error with MessageConsumer.pendingAck
> -------------------------------------------------
>
> Key: AMQNET-727
> URL: https://issues.apache.org/jira/browse/AMQNET-727
> Project: ActiveMQ .Net
> Issue Type: Bug
> Components: OpenWire
> Affects Versions: 1.8.0
> Reporter: Andy DeMaurice
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> pendingAck is accessed by multiple threads; in most places where it is
> written, it is done along with accessing *deliveredMessages*, so it is
> written within a *lock(this.deliveredMessages)* block.
> However, this call stack shows where pendingAck gets assigned to a new
> MessageAck object, NOT within the lock... and it is subject to being
> overwritten by another thread (usually the other thread is in
> MessageConsumer.Acknowledge() :
>
> Apache.NMS.ActiveMQ.MessageConsumer.AckLater(Apache.NMS.ActiveMQ.Commands.MessageDispatch,
> Apache.NMS.ActiveMQ.AckType)
> Apache.NMS.ActiveMQ.MessageConsumer.AfterMessageIsConsumed(Apache.NMS.ActiveMQ.Commands.MessageDispatch,
> Boolean)
> Apache.NMS.ActiveMQ.MessageConsumer.Dispatch(Apache.NMS.ActiveMQ.Commands.MessageDispatch)
> Apache.NMS.ActiveMQ.SessionExecutor.Dispatch(Apache.NMS.ActiveMQ.Commands.MessageDispatch)
> Apache.NMS.ActiveMQ.SessionExecutor.Iterate()
> Apache.NMS.ActiveMQ.Threads.DedicatedTaskRunner.Run()
>
> The usual symptom I see is a NullReferenceException in this section of code
> within AckLater; because pendingAck has been set to null by another thread:
>
> if(oldPendingAck == null)
> {
> pendingAck.FirstMessageId = pendingAck.LastMessageId;
> }
> else if(oldPendingAck.AckType == pendingAck.AckType)
> {
> pendingAck.FirstMessageId = oldPendingAck.FirstMessageId;
> }
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
