[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684398#comment-16684398
]
Jamie goodyear commented on AMQ-7091:
-
Thank you Alan Protasio for the PR :)
> O(n) Memory consumption
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684381#comment-16684381
]
ASF subversion and git services commented on AMQ-7091:
--
Commit
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684377#comment-16684377
]
ASF GitHub Bot commented on AMQ-7091:
-
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684375#comment-16684375
]
ASF subversion and git services commented on AMQ-7091:
--
Commit
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684081#comment-16684081
]
Gary Tully commented on AMQ-7091:
-
[~tabish121] thanks. [~jgenender] Probably no need for any config option
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684019#comment-16684019
]
Timothy Bish commented on AMQ-7091:
---
[~gtully] I'm afraid I don't recall any longer what the context was
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683962#comment-16683962
]
Jeff Genender commented on AMQ-7091:
[~gtully], what if the change was a configuration property? i.e.
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683923#comment-16683923
]
Gary Tully commented on AMQ-7091:
-
[~tabish121] Hi tim, you added the messageReferences cache way back in
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680307#comment-16680307
]
Alan Protasio commented on AMQ-7091:
[~gtully] [~jgenender]
I did some performance tests before and
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679987#comment-16679987
]
Jeff Genender commented on AMQ-7091:
This looks good to me...the additional writes are gone.
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678860#comment-16678860
]
Alan Protasio commented on AMQ-7091:
Hi [~gtully]
Thanks again! haha :D
{quote}the solution is to
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678790#comment-16678790
]
Gary Tully commented on AMQ-7091:
-
[~alanprot] you have to ask the computer to see if there is any negative
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678599#comment-16678599
]
Alan Protasio commented on AMQ-7091:
[~gtully] [~jgoodyear] Seems that all tests succeed!
> O(n)
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677471#comment-16677471
]
Alan Protasio commented on AMQ-7091:
Hi Guys
I changed my PR to use the SequenceSets that
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677145#comment-16677145
]
Alan Protasio commented on AMQ-7091:
Cool! Thanks guys to looking into that...
I will change my PR! :D
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677021#comment-16677021
]
Jamie goodyear commented on AMQ-7091:
-
Hi [~alanprot],
After some conversation with the community,
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676861#comment-16676861
]
Jamie goodyear commented on AMQ-7091:
-
Thanks Gary.
> O(n) Memory consumption when broker has inactive
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676857#comment-16676857
]
Jamie goodyear commented on AMQ-7091:
-
[~cshannon], [~gtully]
I've reviewed Alan's patch and it looks
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676855#comment-16676855
]
Gary Tully commented on AMQ-7091:
-
that info does not need to be persisted, it is duplicate info. I would
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676851#comment-16676851
]
Jamie goodyear commented on AMQ-7091:
-
The patch looks good to me - thank you Alan.
> O(n) Memory
[
https://issues.apache.org/jira/browse/AMQ-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674544#comment-16674544
]
ASF GitHub Bot commented on AMQ-7091:
-
GitHub user alanprot opened a pull request:
21 matches
Mail list logo