date:20171215

[jira] [Commented] (ARTEMIS-1545) JMS MessageProducer fails to expose exception on send when message is sent non-persistent, but not authorised

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293702#comment-16293702
 ] 

ASF GitHub Bot commented on ARTEMIS-1545:
-

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1722#discussion_r15733
  
--- Diff: 
tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/SecurityTest.java
 ---
@@ -169,6 +180,71 @@ public void testLoginInvalidUserInvalidPassword() 
throws Exception {
   }
}
 
+   /**
+* Login with valid user and password
+* But try send to address not authorised - Persistent
+* Should not allow and should throw exception
+*/
+   @Test
+   public void testLoginValidUserAndPasswordButNotAuthorisedToSend() 
throws Exception {
+  ActiveMQConnectionFactory connectionFactory = new 
ActiveMQConnectionFactory("tcp://localhost:61616");
+  Connection connection = connectionFactory.createConnection("guest", 
"guest");
+  Session session = connection.createSession();
+  Destination destination = session.createQueue("guest.cannot.send");
+  MessageProducer messageProducer = 
session.createProducer(destination);
+  try {
+ messageProducer.send(session.createTextMessage("hello"));
+ fail("JMSSecurityException expected as guest is not allowed to 
send");
+  } catch (JMSSecurityException activeMQSecurityException) {
+ //pass
+  }
+  connection.close();
+   }
+
+   /**
+* Login with valid user and password
+* But try send to address not authorised - Non Persistent.
+* Should have same behaviour as Persistent with exception on send.
+*/
+   @Test
+   public void 
testLoginValidUserAndPasswordButNotAuthorisedToSendNonPersistent() throws 
Exception {
+  ActiveMQConnectionFactory connectionFactory = new 
ActiveMQConnectionFactory("tcp://localhost:61616");
+  connectionFactory.setConfirmationWindowSize(100);
+  connectionFactory.setBlockOnDurableSend(false);
+  connectionFactory.setBlockOnNonDurableSend(false);
+  Connection connection = connectionFactory.createConnection("guest", 
"guest");
+  Session session = connection.createSession();
+  Destination destination = session.createQueue("guest.cannot.send");
+  MessageProducer messageProducer = 
session.createProducer(destination);
+  messageProducer.setDeliveryMode(DeliveryMode.NON_PERSISTENT);
+  try {
+ AtomicReference e = new AtomicReference<>();
+ //
messageProducer.send(session.createTextMessage("hello"));
+
+ CountDownLatch countDownLatch = new CountDownLatch(1);
+ messageProducer.send(session.createTextMessage("hello"), new 
CompletionListener() {
+@Override
+public void onCompletion(Message message) {
+   countDownLatch.countDown();
+}
+
+@Override
+public void onException(Message message, Exception exception) {
+   countDownLatch.countDown();
+   e.set(exception);
--- End diff --

good spot, thanks.


> JMS MessageProducer fails to expose exception on send when message is sent 
> non-persistent, but not authorised
> -
>
> Key: ARTEMIS-1545
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1545
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> When sending persistent, behaviour is blocking and a Security exception is 
> thrown. The same behaviour that the client is exposed to the client when 
> sending non-persistent, so that a client could log or take action 
> asynchronously. 
> This can be recreated easily by the following:
> Add the following security section , that means guest is not auth'd to send 
> to "guest.cannot.send"
> activemq-artemis/tests/jms-tests/src/test/resources/broker.xml
>  
>
>
>
>
>
>
>
>
> Then add the following tests to this test (first is proving exception 
> correctly is thrown when persistent is sent using jms api, and second shows 
> behaviour difference and no error):
> activemq-artemis/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/SecurityTest.java
>   /**
> * Login with valid user and password
> * But try send to address not authorised - Persistent
> * Should not allow and should throw exception
> */
>@Test
>public void

[jira] [Commented] (ARTEMIS-1541) Make the JDBC Node Manager more resilient on failures

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292168#comment-16292168
 ] 

ASF GitHub Bot commented on ARTEMIS-1541:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1691
  
@mtaylor I've performed the failover tests on other DBMS and it is working 
as expected, but disabling the `ThreadLeakCheckRule` due to a "known" leak on 
the Oracle thin driver - the uninterruptible/unstoppable/unbreakable 
`oracle.jdbc.driver.BlockSource.ThreadedCachingBlockSource.BlockReleaser` 
thread:
```
public void run() {
while(true) {
try {

BlockSource.ThreadedCachingBlockSource.BlockReleaser var1 = SOLE_INSTANCE;
synchronized(SOLE_INSTANCE) {
SOLE_INSTANCE.wait(30L);
}


BlockSource.ThreadedCachingBlockSource.releaseFromAllSources();
} catch (Throwable var4) {
;
}
}
}
```



> Make the JDBC Node Manager more resilient on failures
> -
>
> Key: ARTEMIS-1541
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1541
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>
> The JDBC Node Manager isn't showing (at any level) errors on setup and hasn't 
> any policy to fail or recover while executing certain critical operations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1230) Create Maven Bill of Materials (BOM)

2017-12-15 Thread Johan (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292482#comment-16292482
 ] 

Johan commented on ARTEMIS-1230:


I too would appreciate a BOM very much. For example using Artemis 2.4 with 
Spring Boot is a PITA because in Spring's BOM older versions of artemis 
artifacts are imported, thus I have to declare all 2.4 dependencies and 
transitive dependencies manually in a  section of the 
projects where I want to use artemis as an embedded broker.

With an artifactory BOM I would first import the Artemis BOM and then the 
spring boot BOM and for Artemis all correct dependencies will be set.

> Create Maven Bill of Materials (BOM)
> 
>
> Key: ARTEMIS-1230
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1230
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Daniel Siviter
>
> It's frustrating having to deal with dependency versions so the creation of a 
> Bill of Materials will assist with this.
> I'm currently battling with Wildfly Swarm 2017.6.0 overriding to 
> v1.1.0.wildfly017. To override the version of Artemis I have to have an entry 
> in my POM for every single dependency which is arduous.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1264) Client authentication via Kerberos TLS Cipher Suites (RFC 2712)

2017-12-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292603#comment-16292603
 ] 

ASF subversion and git services commented on ARTEMIS-1264:
--

Commit 7b3b22d1840ab124e7aefcd4a98f54cb8831e62f in activemq-artemis's branch 
refs/heads/master from [~gtully]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=7b3b22d ]

[ARTEMIS-1310] [ARTEMIS-1264] - remove some dead code - krb5 login module and 
jaas callback handler now have the smarts to query netty


> Client authentication via Kerberos TLS Cipher Suites (RFC 2712)
> ---
>
> Key: ARTEMIS-1264
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1264
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Affects Versions: 2.1.0
>Reporter: Gary Tully
>Assignee: Gary Tully
> Fix For: 2.2.0
>
>
> Allow a client authenticated with a kerberos credential to authenticate to 
> the broker using SSL via the Kerberos cipher suites.
> next steps:
>  - -ensure mapping from kerberos principal to broker identity is locked down-
>  -- https://github.com/apache/activemq-artemis/pull/1388
>  - -ensure jms client config is trivial-
>  -- the connector properties can be configured in the same way as for core.
>  - -validate broker side ticket expiry and renewal-
>  - work with qpid-jms to validate amqp client (on hold)
>  - validate with non java - proton-c client ({color:red}problem{color})
> Interop with non java clients is a problem. OpenSSL [has removed 
> support|http://openssl.6102.n7.nabble.com/openssl-users-Kerberos-tp57906p58095.html]
>  for [rfc2712|https://www.ietf.org/rfc/rfc2712.txt]. 
> While reusing the TLS handshake was a good idea at the time; it has issues 
> (non compatible impl between openssl and sun) and the world has moved on to 
> layering authentication over TLS rather than with.
> This makes sense b/c kerberos does two things, authentication over an 
> insecure connection and session encryption over that connection. With rfc2712 
> the available session encryption options are known to be insecure, best to 
> leave encryption entirely to TLS. 
> In a java only scenario (sun jdk on both ends), using this feature for 
> kerberos *authentication only* is viable.
> For example, if clients use username/password for authentication and TLS to 
> encrypt the connection to secure the password, but don't care about 
> encrypting the rest of the data, there is some value here.
> They can swap the username/password for a kerberos token and achieve 
> authentication. They will essentially drop encryption because the cypher in 
> use is insecure. Note a kerberos ticket is designed to be validated across an 
> insecure channel.
> The modern approach is to layer kerberos authentication over TLS using 
> something like the GSSAPI and SASL.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1310) Provide GSSAPI (kerberos) SASL mechanism for AMQP

2017-12-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292602#comment-16292602
 ] 

ASF subversion and git services commented on ARTEMIS-1310:
--

Commit 7b3b22d1840ab124e7aefcd4a98f54cb8831e62f in activemq-artemis's branch 
refs/heads/master from [~gtully]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=7b3b22d ]

[ARTEMIS-1310] [ARTEMIS-1264] - remove some dead code - krb5 login module and 
jaas callback handler now have the smarts to query netty


> Provide GSSAPI (kerberos) SASL mechanism for AMQP
> -
>
> Key: ARTEMIS-1310
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1310
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.2.0
>Reporter: Gary Tully
>Assignee: Gary Tully
> Fix For: 2.3.0
>
>
> implement GSSAPI sasl mechanism for AMQP transport allowing kerberos single 
> sign on (authentication) and subsequent authorisation
> Doco: 
> https://github.com/apache/activemq-artemis/blob/master/docs/user-manual/en/security.md#kerberos-authentication



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1555) MQTT - Unsubscribe topic in cluster environment leaves reference to the consumer

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292629#comment-16292629
 ] 

ASF GitHub Bot commented on ARTEMIS-1555:
-

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1718
  
@Skiler Good catch and nice work on the tests.  @jbertram @Skiler I am 
going to merge.  I will take care of the commit message and squash.  Thanks.


> MQTT - Unsubscribe topic in cluster environment leaves reference to the 
> consumer
> 
>
> Key: ARTEMIS-1555
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1555
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Raul Valdoleiros
>Priority: Blocker
>
> The use case is:
> * Subscribe queue A in broker 1
> * Subscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Process messages in the two subscribers
> * Unsubscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Some messages aren't delivered in subscriber of broker 1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1555) MQTT - Unsubscribe topic in cluster environment leaves reference to the consumer

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292623#comment-16292623
 ] 

ASF GitHub Bot commented on ARTEMIS-1555:
-

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1718
  
> The commit message is too long to be included in the commit

Please follow the commit recommendations in the [Hacking 
Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/maintainers.md#commit-messages).

Also, please squash your commits and then `push -f` to your branch where 
the PR is based (i.e. `Skiler:remoteQueueSubscriptionRemoveConsumer`).  More 
details [here](https://davidwalsh.name/squash-commits-git).  GitHub will 
automatically pick up the changes on the PR branch.


> MQTT - Unsubscribe topic in cluster environment leaves reference to the 
> consumer
> 
>
> Key: ARTEMIS-1555
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1555
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Raul Valdoleiros
>Priority: Blocker
>
> The use case is:
> * Subscribe queue A in broker 1
> * Subscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Process messages in the two subscribers
> * Unsubscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Some messages aren't delivered in subscriber of broker 1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1543) Vote on Live Setting causes incorrectly shutdown when it's backup dies

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292555#comment-16292555
 ] 

ASF GitHub Bot commented on ARTEMIS-1543:
-

GitHub user mtaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/1719

ARTEMIS-1543 Fix Quorum Vote with remain live setting



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1543

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1719.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1719


commit 84b0c2f7d52d156707bda2899b0635a58674b518
Author: Martyn Taylor 
Date:   2017-12-08T12:47:03Z

ARTEMIS-1543 Fix Quorum Vote with remain live setting




> Vote on Live Setting causes incorrectly shutdown when it's backup dies
> --
>
> Key: ARTEMIS-1543
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1543
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martyn Taylor
>Assignee: Martyn Taylor
>Priority: Critical
>
> The HA replication functionality has the ability to configure the live to 
> request quorum from other nodes in the cluster for it to stay live should 
> it's back up fail.  The intent here is prefer the loss of availability over a 
> potential split brain situation should a live and backup become partitoned.  
> However, this causes the live to incorrectly shutdown should it's backup die 
> and no partition experienced.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1563) added an example to demo Slow Consumer Policy KILL and NOTIFY

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292611#comment-16292611
 ] 

ASF GitHub Bot commented on ARTEMIS-1563:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1717


> added an example to demo Slow Consumer Policy KILL and NOTIFY
> -
>
> Key: ARTEMIS-1563
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1563
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Pat Fox
>Priority: Minor
>
> could not find example of using Slow Consumer policy. It would be good to 
> have one in the examples. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1563) added an example to demo Slow Consumer Policy KILL and NOTIFY

2017-12-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292610#comment-16292610
 ] 

ASF subversion and git services commented on ARTEMIS-1563:
--

Commit 8ccefba4354ae100788d10e2954c0ead08947502 in activemq-artemis's branch 
refs/heads/master from [~pgfox]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=8ccefba ]

ARTEMIS-1563 Slow Consumer example for Slow Consumer policy KILL and NOTIFY


> added an example to demo Slow Consumer Policy KILL and NOTIFY
> -
>
> Key: ARTEMIS-1563
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1563
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Pat Fox
>Priority: Minor
>
> could not find example of using Slow Consumer policy. It would be good to 
> have one in the examples. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1563) added an example to demo Slow Consumer Policy KILL and NOTIFY

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292613#comment-16292613
 ] 

ASF GitHub Bot commented on ARTEMIS-1563:
-

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1717
  
@pgfox Nice example.  Thanks!


> added an example to demo Slow Consumer Policy KILL and NOTIFY
> -
>
> Key: ARTEMIS-1563
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1563
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Pat Fox
>Priority: Minor
>
> could not find example of using Slow Consumer policy. It would be good to 
> have one in the examples. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1541) Make the JDBC Node Manager more resilient on failures

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292230#comment-16292230
 ] 

ASF GitHub Bot commented on ARTEMIS-1541:
-

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1691
  
@franz1981 If you really can't kill it and the thread does not cause 
interference with other tests you can add an exception to the 
ThreadCheckerRule.  Which systems did you run the tests against?  It would be 
good to have this set up in the CI env.


> Make the JDBC Node Manager more resilient on failures
> -
>
> Key: ARTEMIS-1541
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1541
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>
> The JDBC Node Manager isn't showing (at any level) errors on setup and hasn't 
> any policy to fail or recover while executing certain critical operations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1541) Make the JDBC Node Manager more resilient on failures

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292287#comment-16292287
 ] 

ASF GitHub Bot commented on ARTEMIS-1541:
-

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1691
  
> Do you mean which versions of which DBMS?
Yes.

>  how do you propose to do that?
Just add the driver to the class path and pass in the driver class 
parameter via system properties.  We do this for other JDBC tests


> Make the JDBC Node Manager more resilient on failures
> -
>
> Key: ARTEMIS-1541
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1541
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>
> The JDBC Node Manager isn't showing (at any level) errors on setup and hasn't 
> any policy to fail or recover while executing certain critical operations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1563) added an example to demo Slow Consumer Policy KILL and NOTIFY

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292324#comment-16292324
 ] 

ASF GitHub Bot commented on ARTEMIS-1563:
-

GitHub user pgfox opened a pull request:

https://github.com/apache/activemq-artemis/pull/1717

ARTEMIS-1563 Slow Consumer example for Slow Consumer policy KILL and NOTIFY

Slow Consumer example for Slow Consumer policy KILL and NOTIFY. It is based 
off the unit test 
org.apache.activemq.artemis.tests.integration.client.SlowConsumerTest

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pgfox/activemq-artemis slow_consumer_sample

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1717.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1717


commit 841ba569d5141b2d969e01cc3c4c3484c3be4d52
Author: Pat Fox 
Date:   2017-12-13T19:26:26Z

ARTEMIS-1563 Slow Consumer example for Slow Consumer policy KILL and NOTIFY




> added an example to demo Slow Consumer Policy KILL and NOTIFY
> -
>
> Key: ARTEMIS-1563
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1563
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Pat Fox
>Priority: Minor
>
> could not find example of using Slow Consumer policy. It would be good to 
> have one in the examples. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1555) MQTT - Unsubscribe topic in cluster environment leaves reference to the consumer

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292379#comment-16292379
 ] 

ASF GitHub Bot commented on ARTEMIS-1555:
-

GitHub user Skiler opened a pull request:

https://github.com/apache/activemq-artemis/pull/1718

ARTEMIS-1555 MQTT - Unsubscribe topic in cluster environment leaves r…

…eference to the consumer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Skiler/activemq-artemis 
remoteQueueSubscriptionRemoveConsumer

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1718.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1718


commit e7f2989b1a27acfc74f64aacaad86dc0b44f0888
Author: raul.valdoleiros 
Date:   2017-12-15T09:46:57Z

ARTEMIS-1555 MQTT - Unsubscribe topic in cluster environment leaves 
reference to the consumer




> MQTT - Unsubscribe topic in cluster environment leaves reference to the 
> consumer
> 
>
> Key: ARTEMIS-1555
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1555
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Raul Valdoleiros
>Priority: Blocker
>
> The use case is:
> * Subscribe queue A in broker 1
> * Subscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Process messages in the two subscribers
> * Unsubscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Some messages aren't delivered in subscriber of broker 1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1555) MQTT - Unsubscribe topic in cluster environment leaves reference to the consumer

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292389#comment-16292389
 ] 

ASF GitHub Bot commented on ARTEMIS-1555:
-

Github user Skiler closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1706


> MQTT - Unsubscribe topic in cluster environment leaves reference to the 
> consumer
> 
>
> Key: ARTEMIS-1555
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1555
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Raul Valdoleiros
>Priority: Blocker
>
> The use case is:
> * Subscribe queue A in broker 1
> * Subscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Process messages in the two subscribers
> * Unsubscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Some messages aren't delivered in subscriber of broker 1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1555) MQTT - Unsubscribe topic in cluster environment leaves reference to the consumer

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292381#comment-16292381
 ] 

ASF GitHub Bot commented on ARTEMIS-1555:
-

Github user Skiler commented on the issue:

https://github.com/apache/activemq-artemis/pull/1706
  
Fixed by https://github.com/apache/activemq-artemis/pull/1718


> MQTT - Unsubscribe topic in cluster environment leaves reference to the 
> consumer
> 
>
> Key: ARTEMIS-1555
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1555
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Raul Valdoleiros
>Priority: Blocker
>
> The use case is:
> * Subscribe queue A in broker 1
> * Subscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Process messages in the two subscribers
> * Unsubscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Some messages aren't delivered in subscriber of broker 1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1555) MQTT - Unsubscribe topic in cluster environment leaves reference to the consumer

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292382#comment-16292382
 ] 

ASF GitHub Bot commented on ARTEMIS-1555:
-

Github user Skiler commented on the issue:

https://github.com/apache/activemq-artemis/pull/1718
  
The commit message is too long to be included in the commit


> MQTT - Unsubscribe topic in cluster environment leaves reference to the 
> consumer
> 
>
> Key: ARTEMIS-1555
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1555
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Raul Valdoleiros
>Priority: Blocker
>
> The use case is:
> * Subscribe queue A in broker 1
> * Subscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Process messages in the two subscribers
> * Unsubscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Some messages aren't delivered in subscriber of broker 1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1541) Make the JDBC Node Manager more resilient on failures

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292291#comment-16292291
 ] 

ASF GitHub Bot commented on ARTEMIS-1541:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1691
  
@mtaylor 
The DBMS I've tested are MySQL 5.7 and Oracle 12 c (and obviously Derby!).
What I think it worths to do is improve the tests to make them more 
configurations with ease but I'm thinking to address it as a separate PR in 
order to not charge this one with other changes, wdyt?



> Make the JDBC Node Manager more resilient on failures
> -
>
> Key: ARTEMIS-1541
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1541
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>
> The JDBC Node Manager isn't showing (at any level) errors on setup and hasn't 
> any policy to fail or recover while executing certain critical operations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1541) Make the JDBC Node Manager more resilient on failures

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292237#comment-16292237
 ] 

ASF GitHub Bot commented on ARTEMIS-1541:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1691
  
@mtaylor 
> and the thread does not cause interference with other tests

That's the part I'm sure of it: it seems that only a SIGKILL can close a 
process that has any of these threads running-

> Which systems did you run the tests against? 

Do you mean which versions of which DBMS?

> It would be good to have this set up in the CI env

Considering that I'm not sure that is possible to kill gently the Oracle 
one, how do you propose to do that?
eg The Oracle thin driver is not on maven AFAIK




> Make the JDBC Node Manager more resilient on failures
> -
>
> Key: ARTEMIS-1541
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1541
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>
> The JDBC Node Manager isn't showing (at any level) errors on setup and hasn't 
> any policy to fail or recover while executing certain critical operations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1563) added an example to demo Slow Consumer Policy KILL and NOTIFY

2017-12-15 Thread Pat Fox (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292321#comment-16292321
 ] 

Pat Fox commented on ARTEMIS-1563:
--

adding a PR with suggested example 

> added an example to demo Slow Consumer Policy KILL and NOTIFY
> -
>
> Key: ARTEMIS-1563
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1563
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Pat Fox
>Priority: Minor
>
> could not find example of using Slow Consumer policy. It would be good to 
> have one in the examples. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ARTEMIS-1563) added an example to demo Slow Consumer Policy KILL and NOTIFY

2017-12-15 Thread Pat Fox (JIRA)

Pat Fox created ARTEMIS-1563:


 Summary: added an example to demo Slow Consumer Policy KILL and 
NOTIFY
 Key: ARTEMIS-1563
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1563
 Project: ActiveMQ Artemis
  Issue Type: Improvement
  Components: Broker
Affects Versions: 2.4.0
Reporter: Pat Fox
Priority: Minor


could not find example of using Slow Consumer policy. It would be good to have 
one in the examples. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1555) MQTT - Unsubscribe topic in cluster environment leaves reference to the consumer

2017-12-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292644#comment-16292644
 ] 

ASF subversion and git services commented on ARTEMIS-1555:
--

Commit bbf5e4ebd202710a53ddf97d5226eba03631e5bd in activemq-artemis's branch 
refs/heads/master from raul.valdoleiros
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=bbf5e4e ]

[ARTEMIS-1555] Close core consumer on MQTT unsub

Unsubscribe topic in clustered environment left open references to the core 
consumer.  This patch properly closes the consumer which results in correct 
removal of the consumer reference on a remote queue.


> MQTT - Unsubscribe topic in cluster environment leaves reference to the 
> consumer
> 
>
> Key: ARTEMIS-1555
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1555
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Raul Valdoleiros
>Priority: Blocker
>
> The use case is:
> * Subscribe queue A in broker 1
> * Subscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Process messages in the two subscribers
> * Unsubscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Some messages aren't delivered in subscriber of broker 1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1555) MQTT - Unsubscribe topic in cluster environment leaves reference to the consumer

2017-12-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292642#comment-16292642
 ] 

ASF subversion and git services commented on ARTEMIS-1555:
--

Commit e7f2989b1a27acfc74f64aacaad86dc0b44f0888 in activemq-artemis's branch 
refs/heads/master from raul.valdoleiros
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=e7f2989 ]

ARTEMIS-1555 MQTT - Unsubscribe topic in cluster environment leaves reference 
to the consumer



> MQTT - Unsubscribe topic in cluster environment leaves reference to the 
> consumer
> 
>
> Key: ARTEMIS-1555
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1555
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Raul Valdoleiros
>Priority: Blocker
>
> The use case is:
> * Subscribe queue A in broker 1
> * Subscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Process messages in the two subscribers
> * Unsubscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Some messages aren't delivered in subscriber of broker 1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1555) MQTT - Unsubscribe topic in cluster environment leaves reference to the consumer

2017-12-15 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292643#comment-16292643
 ] 

ASF subversion and git services commented on ARTEMIS-1555:
--

Commit 328ece0701a81aa1bfc6bcdac8303152d4f0b1fd in activemq-artemis's branch 
refs/heads/master from raul.valdoleiros
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=328ece0 ]

ARTEMIS-1555 Remove unused imports from test class



> MQTT - Unsubscribe topic in cluster environment leaves reference to the 
> consumer
> 
>
> Key: ARTEMIS-1555
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1555
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Raul Valdoleiros
>Priority: Blocker
>
> The use case is:
> * Subscribe queue A in broker 1
> * Subscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Process messages in the two subscribers
> * Unsubscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Some messages aren't delivered in subscriber of broker 1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1562) Refactor example documentation

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292726#comment-16292726
 ] 

ASF GitHub Bot commented on ARTEMIS-1562:
-

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1720
  
@pgfox, no worries.  It was quick work.


> Refactor example documentation
> --
>
> Key: ARTEMIS-1562
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1562
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1562) Refactor example documentation

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292662#comment-16292662
 ] 

ASF GitHub Bot commented on ARTEMIS-1562:
-

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1720

ARTEMIS-1562 fix new slow-consumer example



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1562

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1720.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1720


commit 2efbb54fafca6f3e2100b2f6fa43e38267889024
Author: Justin Bertram 
Date:   2017-10-24T19:20:37Z

ARTEMIS-1562 fix new slow-consumer example




> Refactor example documentation
> --
>
> Key: ARTEMIS-1562
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1562
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1230) Create Maven Bill of Materials (BOM)

2017-12-15 Thread Timothy Bish (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292637#comment-16292637
 ] 

Timothy Bish commented on ARTEMIS-1230:
---

The project welcomes contributions, why not start working on one and create a 
PR when you are ready. 

> Create Maven Bill of Materials (BOM)
> 
>
> Key: ARTEMIS-1230
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1230
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Daniel Siviter
>
> It's frustrating having to deal with dependency versions so the creation of a 
> Bill of Materials will assist with this.
> I'm currently battling with Wildfly Swarm 2017.6.0 overriding to 
> v1.1.0.wildfly017. To override the version of Artemis I have to have an entry 
> in my POM for every single dependency which is arduous.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1555) MQTT - Unsubscribe topic in cluster environment leaves reference to the consumer

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292645#comment-16292645
 ] 

ASF GitHub Bot commented on ARTEMIS-1555:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1718


> MQTT - Unsubscribe topic in cluster environment leaves reference to the 
> consumer
> 
>
> Key: ARTEMIS-1555
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1555
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Raul Valdoleiros
>Priority: Blocker
>
> The use case is:
> * Subscribe queue A in broker 1
> * Subscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Process messages in the two subscribers
> * Unsubscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Some messages aren't delivered in subscriber of broker 1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1185) Inter-Process Journal Sampler Profiler + CLI command

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292676#comment-16292676
 ] 

ASF GitHub Bot commented on ARTEMIS-1185:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1295
  
I'm closing it , waiting to update it before reopening! :+1: 


> Inter-Process Journal Sampler Profiler + CLI command
> 
>
> Key: ARTEMIS-1185
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1185
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Minor
>
> It provides a sampling profiler on buffered ASYNCIO/NIO based journals.
> The profiling has a minimal cost in term of CPU time for each sample (the 
> dominant costs are System.nanoTime() and a single cache line invalidation) 
> and total memory footprint (~OS page size in bytes).
> A proper CLI command activates a sampler to collect (ie CSV) the profiled 
> data, showing the precision of the sampling: data loss is not considered a 
> failure condition.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1555) MQTT - Unsubscribe topic in cluster environment leaves reference to the consumer

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292666#comment-16292666
 ] 

ASF GitHub Bot commented on ARTEMIS-1555:
-

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1718
  
@Skiler, nice work!


> MQTT - Unsubscribe topic in cluster environment leaves reference to the 
> consumer
> 
>
> Key: ARTEMIS-1555
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1555
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Raul Valdoleiros
>Priority: Blocker
>
> The use case is:
> * Subscribe queue A in broker 1
> * Subscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Process messages in the two subscribers
> * Unsubscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Some messages aren't delivered in subscriber of broker 1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1555) MQTT - Unsubscribe topic in cluster environment leaves reference to the consumer

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292671#comment-16292671
 ] 

ASF GitHub Bot commented on ARTEMIS-1555:
-

Github user Skiler commented on the issue:

https://github.com/apache/activemq-artemis/pull/1718
  
@jbertram @mtaylor thanks =D


> MQTT - Unsubscribe topic in cluster environment leaves reference to the 
> consumer
> 
>
> Key: ARTEMIS-1555
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1555
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Raul Valdoleiros
>Priority: Blocker
>
> The use case is:
> * Subscribe queue A in broker 1
> * Subscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Process messages in the two subscribers
> * Unsubscribe queue A in broker 2
> * Send messages to queue A in broker 1
> * Some messages aren't delivered in subscriber of broker 1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1562) Refactor example documentation

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292715#comment-16292715
 ] 

ASF GitHub Bot commented on ARTEMIS-1562:
-

Github user pgfox commented on the issue:

https://github.com/apache/activemq-artemis/pull/1720
  
@jbertram  sorry about that ... I only noticed your conversion to markdown 
after the example PR was committed.  

the markdown is so much nicer   


> Refactor example documentation
> --
>
> Key: ARTEMIS-1562
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1562
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1562) Refactor example documentation

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292647#comment-16292647
 ] 

ASF GitHub Bot commented on ARTEMIS-1562:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1716


> Refactor example documentation
> --
>
> Key: ARTEMIS-1562
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1562
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1545) JMS MessageProducer fails to expose exception on send when message is sent non-persistent, but not authorised

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292882#comment-16292882
 ] 

ASF GitHub Bot commented on ARTEMIS-1545:
-

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1722

(WIP DO NOT MERGE) ARTEMIS-1545 Support JMS 2.0 Completion Listener for 
Exceptions

@clebertsuconic id like some feedback on this whilst I'm still developing 
it, if thats ok.

Some bits i need to sort still (inc tests), and back compatibility where 
new client connects to old broker (I've put TODO's in code where i can handle 
this once i know how to do this check).

Could you have a look over and detail bits you spot that need more thought, 
or need to address.


Cheers
Mike

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1545-DEC

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1722.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1722


commit 5353ab548937209fb269ffbcc82e55fa8a168b0f
Author: Michael André Pearce 
Date:   2017-12-14T07:47:30Z

ARTEMIS-1545 Support JMS 2.0 Completion Listener for Exceptions




> JMS MessageProducer fails to expose exception on send when message is sent 
> non-persistent, but not authorised
> -
>
> Key: ARTEMIS-1545
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1545
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> When sending persistent, behaviour is blocking and a Security exception is 
> thrown. The same behaviour that the client is exposed to the client when 
> sending non-persistent, so that a client could log or take action 
> asynchronously. 
> This can be recreated easily by the following:
> Add the following security section , that means guest is not auth'd to send 
> to "guest.cannot.send"
> activemq-artemis/tests/jms-tests/src/test/resources/broker.xml
>  
>
>
>
>
>
>
>
>
> Then add the following tests to this test (first is proving exception 
> correctly is thrown when persistent is sent using jms api, and second shows 
> behaviour difference and no error):
> activemq-artemis/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/SecurityTest.java
>   /**
> * Login with valid user and password
> * But try send to address not authorised - Persistent
> * Should not allow and should throw exception
> */
>@Test
>public void testLoginValidUserAndPasswordButNotAuthorisedToSend() throws 
> Exception {
>   ConnectionFactory connectionFactory = new 
> ActiveMQConnectionFactory("tcp://localhost:61616");
>   Connection connection = connectionFactory.createConnection("guest", 
> "guest");
>   Session session = connection.createSession();
>   Destination destination = session.createQueue("guest.cannot.send");
>   MessageProducer messageProducer = session.createProducer(destination);
>   try {
>  messageProducer.send(session.createTextMessage("hello"));
>  fail("JMSSecurityException expected as guest is not allowed to 
> send");
>   } catch (JMSSecurityException activeMQSecurityException){
>  //pass
>   }
>   connection.close();
>}
>/**
> * Login with valid user and password
> * But try send to address not authorised - Non Persistent.
> * Should have same behaviour as Persistent with exception on send.
> */
>@Test
>public void 
> testLoginValidUserAndPasswordButNotAuthorisedToSendNonPersistent() throws 
> Exception {
>   ConnectionFactory connectionFactory = new 
> ActiveMQConnectionFactory("tcp://localhost:61616");
>   Connection connection = connectionFactory.createConnection("guest", 
> "guest");
>   Session session = connection.createSession();
>   Destination destination = session.createQueue("guest.cannot.send");
>   MessageProducer messageProducer = session.createProducer(destination);
>   messageProducer.setDeliveryMode(DeliveryMode.NON_PERSISTENT);
>   try {
>  messageProducer.send(session.createTextMessage("hello"));
>  fail("JMSSecurityException expected as guest is not allowed to 
> send");
>   } catch (JMSSecurityException activeMQSecurityException){
>  //pass
>   }
>   connection.close();
>}



--
This message was sent by Atlassian

[jira] [Commented] (ARTEMIS-1545) JMS MessageProducer fails to expose exception on send when message is sent non-persistent, but not authorised

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292895#comment-16292895
 ] 

ASF GitHub Bot commented on ARTEMIS-1545:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1722
  
@mtaylor also if you get a chance to give any early feedback


> JMS MessageProducer fails to expose exception on send when message is sent 
> non-persistent, but not authorised
> -
>
> Key: ARTEMIS-1545
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1545
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> When sending persistent, behaviour is blocking and a Security exception is 
> thrown. The same behaviour that the client is exposed to the client when 
> sending non-persistent, so that a client could log or take action 
> asynchronously. 
> This can be recreated easily by the following:
> Add the following security section , that means guest is not auth'd to send 
> to "guest.cannot.send"
> activemq-artemis/tests/jms-tests/src/test/resources/broker.xml
>  
>
>
>
>
>
>
>
>
> Then add the following tests to this test (first is proving exception 
> correctly is thrown when persistent is sent using jms api, and second shows 
> behaviour difference and no error):
> activemq-artemis/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/SecurityTest.java
>   /**
> * Login with valid user and password
> * But try send to address not authorised - Persistent
> * Should not allow and should throw exception
> */
>@Test
>public void testLoginValidUserAndPasswordButNotAuthorisedToSend() throws 
> Exception {
>   ConnectionFactory connectionFactory = new 
> ActiveMQConnectionFactory("tcp://localhost:61616");
>   Connection connection = connectionFactory.createConnection("guest", 
> "guest");
>   Session session = connection.createSession();
>   Destination destination = session.createQueue("guest.cannot.send");
>   MessageProducer messageProducer = session.createProducer(destination);
>   try {
>  messageProducer.send(session.createTextMessage("hello"));
>  fail("JMSSecurityException expected as guest is not allowed to 
> send");
>   } catch (JMSSecurityException activeMQSecurityException){
>  //pass
>   }
>   connection.close();
>}
>/**
> * Login with valid user and password
> * But try send to address not authorised - Non Persistent.
> * Should have same behaviour as Persistent with exception on send.
> */
>@Test
>public void 
> testLoginValidUserAndPasswordButNotAuthorisedToSendNonPersistent() throws 
> Exception {
>   ConnectionFactory connectionFactory = new 
> ActiveMQConnectionFactory("tcp://localhost:61616");
>   Connection connection = connectionFactory.createConnection("guest", 
> "guest");
>   Session session = connection.createSession();
>   Destination destination = session.createQueue("guest.cannot.send");
>   MessageProducer messageProducer = session.createProducer(destination);
>   messageProducer.setDeliveryMode(DeliveryMode.NON_PERSISTENT);
>   try {
>  messageProducer.send(session.createTextMessage("hello"));
>  fail("JMSSecurityException expected as guest is not allowed to 
> send");
>   } catch (JMSSecurityException activeMQSecurityException){
>  //pass
>   }
>   connection.close();
>}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1545) JMS MessageProducer fails to expose exception on send when message is sent non-persistent, but not authorised

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292907#comment-16292907
 ] 

ASF GitHub Bot commented on ARTEMIS-1545:
-

Github user tabish121 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1722#discussion_r157260287
  
--- Diff: 
tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/SecurityTest.java
 ---
@@ -169,6 +180,71 @@ public void testLoginInvalidUserInvalidPassword() 
throws Exception {
   }
}
 
+   /**
+* Login with valid user and password
+* But try send to address not authorised - Persistent
+* Should not allow and should throw exception
+*/
+   @Test
+   public void testLoginValidUserAndPasswordButNotAuthorisedToSend() 
throws Exception {
+  ActiveMQConnectionFactory connectionFactory = new 
ActiveMQConnectionFactory("tcp://localhost:61616");
+  Connection connection = connectionFactory.createConnection("guest", 
"guest");
+  Session session = connection.createSession();
+  Destination destination = session.createQueue("guest.cannot.send");
+  MessageProducer messageProducer = 
session.createProducer(destination);
+  try {
+ messageProducer.send(session.createTextMessage("hello"));
+ fail("JMSSecurityException expected as guest is not allowed to 
send");
+  } catch (JMSSecurityException activeMQSecurityException) {
+ //pass
+  }
+  connection.close();
+   }
+
+   /**
+* Login with valid user and password
+* But try send to address not authorised - Non Persistent.
+* Should have same behaviour as Persistent with exception on send.
+*/
+   @Test
+   public void 
testLoginValidUserAndPasswordButNotAuthorisedToSendNonPersistent() throws 
Exception {
+  ActiveMQConnectionFactory connectionFactory = new 
ActiveMQConnectionFactory("tcp://localhost:61616");
+  connectionFactory.setConfirmationWindowSize(100);
+  connectionFactory.setBlockOnDurableSend(false);
+  connectionFactory.setBlockOnNonDurableSend(false);
+  Connection connection = connectionFactory.createConnection("guest", 
"guest");
+  Session session = connection.createSession();
+  Destination destination = session.createQueue("guest.cannot.send");
+  MessageProducer messageProducer = 
session.createProducer(destination);
+  messageProducer.setDeliveryMode(DeliveryMode.NON_PERSISTENT);
+  try {
+ AtomicReference e = new AtomicReference<>();
+ //
messageProducer.send(session.createTextMessage("hello"));
+
+ CountDownLatch countDownLatch = new CountDownLatch(1);
+ messageProducer.send(session.createTextMessage("hello"), new 
CompletionListener() {
+@Override
+public void onCompletion(Message message) {
+   countDownLatch.countDown();
+}
+
+@Override
+public void onException(Message message, Exception exception) {
+   countDownLatch.countDown();
+   e.set(exception);
--- End diff --

The set here should occur prior to the countDown to avoid potential race on 
the later check of error state.  


> JMS MessageProducer fails to expose exception on send when message is sent 
> non-persistent, but not authorised
> -
>
> Key: ARTEMIS-1545
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1545
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> When sending persistent, behaviour is blocking and a Security exception is 
> thrown. The same behaviour that the client is exposed to the client when 
> sending non-persistent, so that a client could log or take action 
> asynchronously. 
> This can be recreated easily by the following:
> Add the following security section , that means guest is not auth'd to send 
> to "guest.cannot.send"
> activemq-artemis/tests/jms-tests/src/test/resources/broker.xml
>  
>
>
>
>
>
>
>
>
> Then add the following tests to this test (first is proving exception 
> correctly is thrown when persistent is sent using jms api, and second shows 
> behaviour difference and no error):
> activemq-artemis/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/SecurityTest.java
>   /**
> * Login with valid user and password
> * But try send to address not authorised - Persistent
> * Should not allow

[jira] [Resolved] (ARTEMIS-1547) Support referrals in the LDAP login module

2017-12-15 Thread Justin Bertram (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram resolved ARTEMIS-1547.
-
Resolution: Fixed

> Support referrals in the LDAP login module
> --
>
> Key: ARTEMIS-1547
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1547
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1548) Support CRL

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293070#comment-16293070
 ] 

ASF GitHub Bot commented on ARTEMIS-1548:
-

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1715
  
Can you squash the commits?


> Support CRL
> ---
>
> Key: ARTEMIS-1548
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1548
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1548) Support CRL

2017-12-15 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293269#comment-16293269
 ] 

ASF GitHub Bot commented on ARTEMIS-1548:
-

Github user Skiler commented on the issue:

https://github.com/apache/activemq-artemis/pull/1715
  
Done :)


> Support CRL
> ---
>
> Key: ARTEMIS-1548
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1548
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

40 matches

Mail list logo