[jira] [Closed] (ARTEMIS-1689) Remove redundant "mvn install" during travis-ci build

2018-02-16 Thread Ilya Shipitsin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ilya Shipitsin closed ARTEMIS-1689.
---
Resolution: Duplicate

> Remove redundant "mvn install" during travis-ci build
> -
>
> Key: ARTEMIS-1689
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1689
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Ilya Shipitsin
>Priority: Trivial
>
> "mvn install" was called twice. no need actually



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1690) Remove redundant "mvn install" during travis-ci build

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368122#comment-16368122
 ] 

ASF GitHub Bot commented on ARTEMIS-1690:
-

GitHub user chipitsine opened a pull request:

https://github.com/apache/activemq-artemis/pull/1876

ARTEMIS-1690 remove not needed "mvn install"

"mvn install" is called by travis-ci itself, let's skip it in favour of our 
own "mvn install"

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chipitsine/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1876.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1876


commit 55bd074992beffd01bc49310c6ee5a9f0936542d
Author: Ilya Shipitsin 
Date:   2018-02-17T06:55:05Z

ARTEMIS-1690 remove not needed "mvn install"




> Remove redundant "mvn install" during travis-ci build
> -
>
> Key: ARTEMIS-1690
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1690
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Ilya Shipitsin
>Priority: Trivial
>
> remove non needed "mvn install" during travis-ci build



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ARTEMIS-1690) Remove redundant "mvn install" during travis-ci build

2018-02-16 Thread Ilya Shipitsin (JIRA) 
Ilya Shipitsin created ARTEMIS-1690:
---

 Summary: Remove redundant "mvn install" during travis-ci build
 Key: ARTEMIS-1690
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1690
 Project: ActiveMQ Artemis
  Issue Type: Improvement
Reporter: Ilya Shipitsin


remove non needed "mvn install" during travis-ci build



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ARTEMIS-1689) Remove redundant "mvn install" during travis-ci build

2018-02-16 Thread Ilya Shipitsin (JIRA) 
Ilya Shipitsin created ARTEMIS-1689:
---

 Summary: Remove redundant "mvn install" during travis-ci build
 Key: ARTEMIS-1689
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1689
 Project: ActiveMQ Artemis
  Issue Type: Improvement
Reporter: Ilya Shipitsin


"mvn install" was called twice. no need actually



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1688) Cluster won't form when auto-create-addresses = false

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367970#comment-16367970
 ] 

ASF GitHub Bot commented on ARTEMIS-1688:
-

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1875

ARTEMIS-1688 fix cluster when auto-create-addresses=false



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1688

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1875.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1875


commit 5d1e90b27d3d40540da5577f195fe4f20d8ba57d
Author: Justin Bertram 
Date:   2018-02-16T22:44:17Z

ARTEMIS-1688 fix cluster when auto-create-addresses=false




> Cluster won't form when auto-create-addresses = false
> -
>
> Key: ARTEMIS-1688
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1688
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>
> If address auto-creation is disabled like so:
> {noformat}
> 
>false
>false
> 
> {noformat}
> Then the cluster bridge will silently fail to connect because its 
> notification consumer (see 
> {{org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge#setupNotificationConsumer}})
>  will fail.
> To workaround this issue the management notifications address can be manually 
> configured like so:
> {noformat}
> 
>
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ARTEMIS-1688) Cluster won't form when auto-create-addresses = false

2018-02-16 Thread Justin Bertram (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram updated ARTEMIS-1688:

Description: 
If address auto-creation is disabled like so:

{noformat}

   false
   false

{noformat}

Then the cluster bridge will silently fail to connect because its notification 
consumer (see 
{{org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge#setupNotificationConsumer}})
 will fail.

To workaround this issue the management notifications address can be manually 
configured like so:

{noformat}

   

{noformat}

  was:
If address auto-creation is disabled like so:

{noformat}

   false
   false

{noformat}

Then the cluster bridge will silently fail to connect because its notification 
consumer (see 
org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge#setupNotificationConsumer)
 will fail.

To workaround this issue the management notifications address can be manually 
configured like so:

{noformat}

   

{noformat}


> Cluster won't form when auto-create-addresses = false
> -
>
> Key: ARTEMIS-1688
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1688
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>
> If address auto-creation is disabled like so:
> {noformat}
> 
>false
>false
> 
> {noformat}
> Then the cluster bridge will silently fail to connect because its 
> notification consumer (see 
> {{org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge#setupNotificationConsumer}})
>  will fail.
> To workaround this issue the management notifications address can be manually 
> configured like so:
> {noformat}
> 
>
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ARTEMIS-1688) Cluster won't form when auto-create-addresses = false

2018-02-16 Thread Justin Bertram (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram updated ARTEMIS-1688:

Description: 
If address auto-creation is disabled like so:

{noformat}

   false
   false

{noformat}

Then the cluster bridge will silently fail to connect because its notification 
consumer (see 
org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge#setupNotificationConsumer)
 will fail.

To workaround this issue the management notifications address can be manually 
configured like so:

{noformat}

   

{noformat}

> Cluster won't form when auto-create-addresses = false
> -
>
> Key: ARTEMIS-1688
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1688
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>
> If address auto-creation is disabled like so:
> {noformat}
> 
>false
>false
> 
> {noformat}
> Then the cluster bridge will silently fail to connect because its 
> notification consumer (see 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge#setupNotificationConsumer)
>  will fail.
> To workaround this issue the management notifications address can be manually 
> configured like so:
> {noformat}
> 
>
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ARTEMIS-1688) Cluster won't form when auto-create-addresses = false

2018-02-16 Thread Justin Bertram (JIRA) 
Justin Bertram created ARTEMIS-1688:
---

 Summary: Cluster won't form when auto-create-addresses = false
 Key: ARTEMIS-1688
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1688
 Project: ActiveMQ Artemis
  Issue Type: Bug
Affects Versions: 2.4.0
Reporter: Justin Bertram
Assignee: Justin Bertram






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1664) fix npe bug while getting element in the process of rehash

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367848#comment-16367848
 ] 

ASF GitHub Bot commented on ARTEMIS-1664:
-

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1851
  
Please rebase this and push -f so the new Travis CI build for the PR will 
run. Thanks!


> fix npe bug while getting element in the process of rehash
> --
>
> Key: ARTEMIS-1664
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1664
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: yangwei
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1669) JMS message is not received when using a non-transactional JMSConnectionFactoryDefinition

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367840#comment-16367840
 ] 

ASF GitHub Bot commented on ARTEMIS-1669:
-

Github user jbertram commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1857#discussion_r168862534
  
--- Diff: 
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRASessionFactoryImpl.java
 ---
@@ -819,13 +819,12 @@ protected ActiveMQRASession 
allocateConnection(boolean transacted,
 //from createSession
 // In a Java EE web or EJB container, when there is an active 
JTA transaction in progress:
 //Both arguments {@code transacted} and {@code 
acknowledgeMode} are ignored.
-if (inJtaTransaction()) {
+// fix of JBEAP-12720 - when a JMSConnectionFactoryDefinition 
annotation with the transactional attribute set to false="false" is set
--- End diff --

This should reference the ARTEMIS JIRA rather than JBEAP.


> JMS message is not received when using a non-transactional 
> JMSConnectionFactoryDefinition
> -
>
> Key: ARTEMIS-1669
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1669
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.5.5
>Reporter: Jiri Ondrusek
>Priority: Major
>
> When using a JMSConnectionFactoryDefinition annotation, and specifying a non 
> transactional connection factory, message is not being sent (or at least 
> received by MDB). Example:
> @JMSConnectionFactoryDefinition(
>  name = "java:app/jms/nonXAconnectionFactory",
>  transactional = false,
>  properties = {
>  "connectors=in-vm",}
>  ),
> When using an MDB message isn't received. Removing "transactional" attribute 
> makes it work again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AMQ-6901) Destination with wildcard may not have correct policy applied if multiple wildcard policies exist

2018-02-16 Thread Christopher L. Shannon (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367788#comment-16367788
 ] 

Christopher L. Shannon commented on AMQ-6901:
-

Added 
[https://git-wip-us.apache.org/repos/asf?p=activemq.git;a=commit;h=703b7b151017fe117363e5598146e157bad78265]
 to fix a NPE

> Destination with wildcard may not have correct policy applied if multiple 
> wildcard policies exist
> -
>
> Key: AMQ-6901
> URL: https://issues.apache.org/jira/browse/AMQ-6901
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.15.3
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 5.16.0, 5.15.4
>
>
> Back in AMQ-6109 I fixed an issue where the wrong policy was being applied to 
> a destination. when there were wildcards.  It turns out that this was only a 
> partial fix and there is another edge case where if there are multiple wild 
> card policies (and some are children) , it is possible for the wrong child 
> card policy to be applied to a destination at a higher parent level which is 
> incorrect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1656) OpenWire scalability improvements

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367745#comment-16367745
 ] 

ASF GitHub Bot commented on ARTEMIS-1656:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1849
  
I have no further comments. I haven’t had a chance to run test suites but 
as long as you run them and they pass I’m happy 


> OpenWire scalability improvements
> -
>
> Key: ARTEMIS-1656
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1656
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Minor
>
> OpenWire is using the synchronized OpenWireFormat instance belonging to 
> OpenWireProtocolManager: it won't allow to scale with the number of 
> connections.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1628) Limit pool size of files on the journal by default

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367735#comment-16367735
 ] 

ASF GitHub Bot commented on ARTEMIS-1628:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1863


> Limit pool size of files on the journal by default
> --
>
> Key: ARTEMIS-1628
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1628
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: clebert suconic
>Assignee: clebert suconic
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1628) Limit pool size of files on the journal by default

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367729#comment-16367729
 ] 

ASF GitHub Bot commented on ARTEMIS-1628:
-

Github user graben commented on the issue:

https://github.com/apache/activemq-artemis/pull/1863
  
Any further objection to not merge this?


> Limit pool size of files on the journal by default
> --
>
> Key: ARTEMIS-1628
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1628
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: clebert suconic
>Assignee: clebert suconic
>Priority: Major
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1687) Reduce logging for fast-tests

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367723#comment-16367723
 ] 

ASF GitHub Bot commented on ARTEMIS-1687:
-

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1874

ARTEMIS-1687 reduce logging for fast-tests

Logging for the "fast-tests" profile used for PR builds could be reduced
significantly. This would save time as well as prevent log truncation
(Travis CI only supports logs up to 4MB).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1687

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1874.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1874


commit 63765fb95de98d62fe4993fc8fd021e07a1d65ba
Author: Justin Bertram 
Date:   2018-02-16T18:50:26Z

ARTEMIS-1687 reduce logging for fast-tests

Logging for the "fast-tests" profile used for PR builds could be reduced
significantly. This would save time as well as prevent log truncation
(Travis CI only supports logs up to 4MB).




> Reduce logging for fast-tests
> -
>
> Key: ARTEMIS-1687
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1687
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ARTEMIS-1687) Reduce logging for fast-tests

2018-02-16 Thread Justin Bertram (JIRA) 
Justin Bertram created ARTEMIS-1687:
---

 Summary: Reduce logging for fast-tests
 Key: ARTEMIS-1687
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1687
 Project: ActiveMQ Artemis
  Issue Type: Task
Reporter: Justin Bertram
Assignee: Justin Bertram






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1498) [interop] Openwire internal headers should not be part of message properties

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367674#comment-16367674
 ] 

ASF GitHub Bot commented on ARTEMIS-1498:
-

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1793
  
@RaiSaurabh, the Travis CI issues should be resolved.  Can you please 
rebase this PR and push -f?  Thanks!


> [interop] Openwire internal headers should not be part of message properties
> 
>
> Key: ARTEMIS-1498
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1498
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: OpenWire
> Environment: interoperability between Openwire -> AMQP/Core
>Reporter: Michal Toth
>Priority: Minor
>
> Sending an empty message from Openwire JMS client to AMQP or Core receiver 
> client shows extra "internal" headers (__HDR_*) in message properties. 
> They should not be there, as these are internal for broker in my opinion.
> Openwire sender
> {noformat}
> $ java  -jar /var/dtests/node_data/clients/aoc7.jar sender  --timeout 5 
> --log-msgs interop --broker tcp://localhost:61616 --address queue_name_\$ 
> --count 1  --conn-username admin --conn-password admin
> {'durable': True, 'priority': 4, 'ttl': 0, 'first-acquirer': False, 
> 'delivery-count': 0, 'id': 
> 'dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1:1:1:1', 
> 'user-id':None, 'address': 'queue_name_$', 'subject': None, 'reply-to': None, 
> 'correlation-id': None, 'content-type': None, 'content-encoding': None, 
> 'absolute-expiry-time': 0, 'creation-time': 1509702974798, 'group-id': None, 
> 'group-sequence': 0, 'reply-to-group-id': None, 'properties': {}, 'content': 
> None, 'type': None}
> {noformat}
> AMQP/Core receiver
> {noformat}
> $ java  -jar /var/dtests/node_data/clients/aac1.jar receiver  --timeout 5 
> --log-msgs interop --broker localhost:5672 --address queue_name_\$ --count 1  
> --conn-username admin --conn-password admin
> Unsupported object type org.apache.qpid.proton.amqp.Binary 
> \x00\x00\x00Jn\x02\xae\x02{\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01\x00\x01
> Unsupported object type org.apache.qpid.proton.amqp.Binary 
> \x00\x00\x00F{\x01+\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01
> {'durable': True, 'priority': 4, 'ttl': 0, 'first-acquirer': False, 
> 'delivery-count': 0, 'id': None, 'user-id': None, 'address': 'queue_name_$', 
> 'subject': None, 'reply-to': None, 'correlation-id': None, 'content-type': 
> None, 'content-encoding': None, 'absolute-expiry-time': 0, 'creation-time': 
> 1509702974798, 'group-id': None, 'group-sequence': 0, 'reply-to-group-id': 
> None, 'properties': {'__HDR_COMMAND_ID': 5, 'JMSXDeliveryCount': 1, 
> '__HDR_ARRIVAL': 0, '__HDR_MESSAGE_ID': 
> \x00\x00\x00Jn\x02\xae\x02{\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01\x00\x01,
>  '__HDR_GROUP_SEQUENCE': 0, '__HDR_PRODUCER_ID': 
> \x00\x00\x00F{\x01+\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01,
>  '__HDR_DROPPABLE': False, '__HDR_BROKER_IN_TIME': 1509702974800}, 'content': 
> None}
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (ARTEMIS-1684) Enable TravisCI

2018-02-16 Thread Robbie Gemmell (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367623#comment-16367623
 ] 

Robbie Gemmell edited comment on ARTEMIS-1684 at 2/16/18 5:44 PM:
--

I see that the build is caching the maven local repo, and the build is 
installing there each time. It might be good to either not install, or prevent 
the artemis bits from actually being cached, otherwise the cache will grow 
unchecked and there could be issues from interaction with stale artifacts from 
failed builds etc. This 
[https://docs.travis-ci.com/user/caching/#before_cache-phase] might offer a 
route if leaving it installing.

 

 


was (Author: gemmellr):
I see that the build is caching the maven local repo, and the build is 
installing there each time. It might be good to either not install, or prevent 
the artemis bits from actually being cached, otherwise the cache will grow 
unchecked and there could be issues from interaction with stale artifacts from 
failed builds etc. This 
[https://docs.travis-ci.com/user/caching/#before_cache-phase] might offer a 
router if leaving it installing.

 

 

> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

2018-02-16 Thread Robbie Gemmell (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367623#comment-16367623
 ] 

Robbie Gemmell commented on ARTEMIS-1684:
-

I see that the build is caching the maven local repo, and the build is 
installing there each time. It might be good to either not install, or prevent 
the artemis bits from actually being cached, otherwise the cache will grow 
unchecked and there could be issues from interaction with stale artifacts from 
failed builds etc. This 
[https://docs.travis-ci.com/user/caching/#before_cache-phase] might offer a 
router if leaving it installing.

 

 

> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1685) Set MQTT connection clientID before session creation

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367621#comment-16367621
 ] 

ASF GitHub Bot commented on ARTEMIS-1685:
-

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1873
  
@dejanb, can you rebase to get the Travis CI integration bits so the PR 
build will run properly?


> Set MQTT connection clientID before session creation
> 
>
> Key: ARTEMIS-1685
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1685
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: MQTT
>Affects Versions: 2.4.0
>Reporter: Dejan Bosanac
>Priority: Major
>
> It will make this property available in the plugin beforeCreateSession()  and 
> afterCreateSession(), which can be useful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1684) Enable TravisCI

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367608#comment-16367608
 ] 

ASF GitHub Bot commented on ARTEMIS-1684:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1872


> Enable TravisCI
> ---
>
> Key: ARTEMIS-1684
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1684
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ARTEMIS-1686) Connection to PostgreSQL seems to be broken

2018-02-16 Thread Michal Toth (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michal Toth updated ARTEMIS-1686:
-
Description: 
Unable to connect to PostreSQL database with configured broker.xml and added 
appropriate connector-jar.

{normat}

[root@hp-dl380pgen8-02-vm-12 ~]# /opt/jboss-amq-7-i0/bin/artemis run

 10:36:31.299 DEBUG [org.apache.activemq.artemis.integration.bootstrap] 
AMQ101005: Using broker configuration: xml:/opt/jboss-amq-7-i0/etc/bootstrap.xml
 10:36:31.301 FINE [javax.xml.bind] Searching jaxb.properties
 10:36:31.301 FINE [javax.xml.bind] Searching the system property
 10:36:31.302 FINE [javax.xml.bind] Unable to find from OSGi: 
javax.xml.bind.JAXBContext
 10:36:31.302 FINE [javax.xml.bind] Searching META-INF/services
 10:36:31.302 FINE [javax.xml.bind] Unable to 
load:META-INF/services/javax.xml.bind.JAXBContext
 10:36:31.302 FINE [javax.xml.bind] Trying to create the platform default 
provider
 10:36:31.302 FINE [javax.xml.bind] Trying to load 
com.sun.xml.internal.bind.v2.ContextFactory
 ...

10:36:32.045 WARN [org.apache.activemq.artemis.core.server] AMQ69: Please 
use a fixed value for "journal-pool-files". Default changed per 
https://issues.apache.org/jira/browse/ARTEMIS-1628
 10:36:32.094 INFO [org.apache.activemq.artemis.integration.bootstrap] 
AMQ101000: Starting ActiveMQ Artemis Server
 10:36:32.112 DEBUG 
[org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl] Starting 
server ActiveMQServerImpl::
 10:36:32.796 INFO [org.apache.activemq.artemis.core.server] AMQ221000: live 
Message Broker is starting with configuration Broker Configuration 
(clustered=false,journalDirectory=./data/journal,bindingsDirectory=./data/bindings,largeMessagesDirectory=./data/large-messages,pagingDirectory=./data/paging)
 10:36:32.956 WARN 
[org.apache.activemq.artemis.jdbc.store.drivers.AbstractJDBCDriver] 
 SQL EXCEPTIONS: 
 SQLState: 0A000 ErrorCode: 0 Message: Method 
org.postgresql.jdbc.PgConnection.setNetworkTimeout(Executor, int) is not yet 
implemented.
 10:36:32.959 WARN [org.apache.activemq.artemis.journal] Unable to set a 
network timeout on the JDBC connection
 10:36:33.170 WARN 
[org.apache.activemq.artemis.jdbc.store.drivers.AbstractJDBCDriver] 
 SQL EXCEPTIONS: 
 SQLState: 0A000 ErrorCode: 0 Message: Method 
org.postgresql.jdbc.PgConnection.setNetworkTimeout(Executor, int) is not yet 
implemented.
 10:36:33.171 WARN [org.apache.activemq.artemis.journal] Unable to set a 
network timeout on the JDBC connection
 10:36:33.267 DEBUG 
[org.apache.activemq.artemis.spi.core.protocol.MessagePersister] Cannot find 
persister for 
org.apache.activemq.artemis.core.protocol.mqtt.MQTTProtocolManagerFactory@21b2e768
 10:36:33.269 DEBUG 
[org.apache.activemq.artemis.spi.core.protocol.MessagePersister] Cannot find 
persister for 
org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManagerFactory@fa36558
 10:36:33.270 DEBUG 
[org.apache.activemq.artemis.spi.core.protocol.MessagePersister] Cannot find 
persister for 
org.apache.activemq.artemis.core.protocol.stomp.StompProtocolManagerFactory@7748410a
 10:36:33.270 INFO [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-server]. Adding protocol support for: CORE
 10:36:33.271 INFO [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-amqp-protocol]. Adding protocol support for: 
AMQP
 10:36:33.271 INFO [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-hornetq-protocol]. Adding protocol support for: 
HORNETQ
 10:36:33.272 DEBUG 
[org.apache.activemq.artemis.spi.core.protocol.MessagePersister] Cannot find 
persister for 
org.apache.activemq.artemis.core.protocol.mqtt.MQTTProtocolManagerFactory@65b3f4a4
 10:36:33.272 INFO [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-mqtt-protocol]. Adding protocol support for: 
MQTT
 10:36:33.272 DEBUG 
[org.apache.activemq.artemis.spi.core.protocol.MessagePersister] Cannot find 
persister for 
org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManagerFactory@50caa560
 10:36:33.272 INFO [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-openwire-protocol]. Adding protocol support 
for: OPENWIRE
 10:36:33.272 DEBUG 
[org.apache.activemq.artemis.spi.core.protocol.MessagePersister] Cannot find 
persister for 
org.apache.activemq.artemis.core.protocol.stomp.StompProtocolManagerFactory@186f8716
 10:36:33.273 INFO [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-stomp-protocol]. Adding protocol support for: 
STOMP
 10:36:33.666 WARN 
[org.apache.activemq.artemis.jdbc.store.drivers.AbstractJDBCDriver] 
 SQL EXCEPTIONS: 
 SQLState: 0A000 ErrorCode: 0 Message: Method 
org.postgresql.jdbc.PgConnection.setNetworkTimeout(Executor, int) is not yet 
implemented.
 10:36:33.666 WARN

[jira] [Created] (ARTEMIS-1686) Connection to PostgreSQL seems to be broken

2018-02-16 Thread Michal Toth (JIRA) 
Michal Toth created ARTEMIS-1686:


 Summary: Connection to PostgreSQL seems to be broken
 Key: ARTEMIS-1686
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1686
 Project: ActiveMQ Artemis
  Issue Type: Bug
  Components: Broker
Affects Versions: 2.4.0
 Environment: Rhel7
Reporter: Michal Toth


Unable to connect to PostreSQL database with configured broker.xml and added 
appropriate connector-jar.

{normat}

[root@hp-dl380pgen8-02-vm-12 ~]# /opt/jboss-amq-7-i0/bin/artemis run
__ __   _
 /\ | \/ |/ __ \ | _ \ | |
 / \ | \ / | | | | | |_) |_ __ ___ | | _ _ __
 / /\ \ | |\/| | | | | | _ <| '__/ _ | |/ / _ \ '__|
 /  | | | | |__| | | |_) | | | (_) | < __/ |
 /_/ __| |_|\ |/|_| ___/|_||_|

Red Hat JBoss AMQ 7.1.0.GA

10:36:31.298 DEBUG [org.jboss.logging] Logging Provider: 
org.jboss.logging.JBossLogManagerProvider
 10:36:31.299 DEBUG [org.apache.activemq.artemis.integration.bootstrap] 
AMQ101005: Using broker configuration: xml:/opt/jboss-amq-7-i0/etc/bootstrap.xml
 10:36:31.301 FINE [javax.xml.bind] Searching jaxb.properties
 10:36:31.301 FINE [javax.xml.bind] Searching the system property
 10:36:31.302 FINE [javax.xml.bind] Unable to find from OSGi: 
javax.xml.bind.JAXBContext
 10:36:31.302 FINE [javax.xml.bind] Searching META-INF/services
 10:36:31.302 FINE [javax.xml.bind] Unable to 
load:META-INF/services/javax.xml.bind.JAXBContext
 10:36:31.302 FINE [javax.xml.bind] Trying to create the platform default 
provider
 10:36:31.302 FINE [javax.xml.bind] Trying to load 
com.sun.xml.internal.bind.v2.ContextFactory
 ...

10:36:32.045 WARN [org.apache.activemq.artemis.core.server] AMQ69: Please 
use a fixed value for "journal-pool-files". Default changed per 
https://issues.apache.org/jira/browse/ARTEMIS-1628
 10:36:32.094 INFO [org.apache.activemq.artemis.integration.bootstrap] 
AMQ101000: Starting ActiveMQ Artemis Server
 10:36:32.112 DEBUG 
[org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl] Starting 
server ActiveMQServerImpl::
 10:36:32.796 INFO [org.apache.activemq.artemis.core.server] AMQ221000: live 
Message Broker is starting with configuration Broker Configuration 
(clustered=false,journalDirectory=./data/journal,bindingsDirectory=./data/bindings,largeMessagesDirectory=./data/large-messages,pagingDirectory=./data/paging)
 10:36:32.956 WARN 
[org.apache.activemq.artemis.jdbc.store.drivers.AbstractJDBCDriver] 
 SQL EXCEPTIONS: 
 SQLState: 0A000 ErrorCode: 0 Message: Method 
org.postgresql.jdbc.PgConnection.setNetworkTimeout(Executor, int) is not yet 
implemented.
 10:36:32.959 WARN [org.apache.activemq.artemis.journal] Unable to set a 
network timeout on the JDBC connection
 10:36:33.170 WARN 
[org.apache.activemq.artemis.jdbc.store.drivers.AbstractJDBCDriver] 
 SQL EXCEPTIONS: 
 SQLState: 0A000 ErrorCode: 0 Message: Method 
org.postgresql.jdbc.PgConnection.setNetworkTimeout(Executor, int) is not yet 
implemented.
 10:36:33.171 WARN [org.apache.activemq.artemis.journal] Unable to set a 
network timeout on the JDBC connection
 10:36:33.267 DEBUG 
[org.apache.activemq.artemis.spi.core.protocol.MessagePersister] Cannot find 
persister for 
org.apache.activemq.artemis.core.protocol.mqtt.MQTTProtocolManagerFactory@21b2e768
 10:36:33.269 DEBUG 
[org.apache.activemq.artemis.spi.core.protocol.MessagePersister] Cannot find 
persister for 
org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManagerFactory@fa36558
 10:36:33.270 DEBUG 
[org.apache.activemq.artemis.spi.core.protocol.MessagePersister] Cannot find 
persister for 
org.apache.activemq.artemis.core.protocol.stomp.StompProtocolManagerFactory@7748410a
 10:36:33.270 INFO [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-server]. Adding protocol support for: CORE
 10:36:33.271 INFO [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-amqp-protocol]. Adding protocol support for: 
AMQP
 10:36:33.271 INFO [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-hornetq-protocol]. Adding protocol support for: 
HORNETQ
 10:36:33.272 DEBUG 
[org.apache.activemq.artemis.spi.core.protocol.MessagePersister] Cannot find 
persister for 
org.apache.activemq.artemis.core.protocol.mqtt.MQTTProtocolManagerFactory@65b3f4a4
 10:36:33.272 INFO [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-mqtt-protocol]. Adding protocol support for: 
MQTT
 10:36:33.272 DEBUG 
[org.apache.activemq.artemis.spi.core.protocol.MessagePersister] Cannot find 
persister for 
org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManagerFactory@50caa560
 10:36:33.272 INFO [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-openwire-protocol]. Adding protocol support 
for: OPENWIRE
 10:36:33.272 DEBUG

[jira] [Resolved] (AMQ-6901) Destination with wildcard may not have correct policy applied if multiple wildcard policies exist

2018-02-16 Thread Christopher L. Shannon (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AMQ-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon resolved AMQ-6901.
-
Resolution: Fixed

> Destination with wildcard may not have correct policy applied if multiple 
> wildcard policies exist
> -
>
> Key: AMQ-6901
> URL: https://issues.apache.org/jira/browse/AMQ-6901
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.15.3
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 5.16.0, 5.15.4
>
>
> Back in AMQ-6109 I fixed an issue where the wrong policy was being applied to 
> a destination. when there were wildcards.  It turns out that this was only a 
> partial fix and there is another edge case where if there are multiple wild 
> card policies (and some are children) , it is possible for the wrong child 
> card policy to be applied to a destination at a higher parent level which is 
> incorrect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AMQ-6901) Destination with wildcard may not have correct policy applied if multiple wildcard policies exist

2018-02-16 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367483#comment-16367483
 ] 

ASF subversion and git services commented on AMQ-6901:
--

Commit 3c2d5a3015db444de6500dcbe08299d50ce74824 in activemq's branch 
refs/heads/activemq-5.15.x from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=3c2d5a3 ]

AMQ-6901 - Make sure proper policy is used to configure a destination

When multiple wildcard policies exist in a hierarchy it was possible for
the wrong policy to be selected when configuring a destination

(cherry picked from commit 2ce1c1352fb64ecf1d3018e2b0f7cabeba99b589)


> Destination with wildcard may not have correct policy applied if multiple 
> wildcard policies exist
> -
>
> Key: AMQ-6901
> URL: https://issues.apache.org/jira/browse/AMQ-6901
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.15.3
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 5.16.0, 5.15.4
>
>
> Back in AMQ-6109 I fixed an issue where the wrong policy was being applied to 
> a destination. when there were wildcards.  It turns out that this was only a 
> partial fix and there is another edge case where if there are multiple wild 
> card policies (and some are children) , it is possible for the wrong child 
> card policy to be applied to a destination at a higher parent level which is 
> incorrect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AMQ-6901) Destination with wildcard may not have correct policy applied if multiple wildcard policies exist

2018-02-16 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367482#comment-16367482
 ] 

ASF subversion and git services commented on AMQ-6901:
--

Commit 2ce1c1352fb64ecf1d3018e2b0f7cabeba99b589 in activemq's branch 
refs/heads/master from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=2ce1c13 ]

AMQ-6901 - Make sure proper policy is used to configure a destination

When multiple wildcard policies exist in a hierarchy it was possible for
the wrong policy to be selected when configuring a destination


> Destination with wildcard may not have correct policy applied if multiple 
> wildcard policies exist
> -
>
> Key: AMQ-6901
> URL: https://issues.apache.org/jira/browse/AMQ-6901
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.15.3
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 5.16.0, 5.15.4
>
>
> Back in AMQ-6109 I fixed an issue where the wrong policy was being applied to 
> a destination. when there were wildcards.  It turns out that this was only a 
> partial fix and there is another edge case where if there are multiple wild 
> card policies (and some are children) , it is possible for the wrong child 
> card policy to be applied to a destination at a higher parent level which is 
> incorrect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ARTEMIS-1659) AMQ224000: Failure in initialisation: java.lang.IllegalStateException: java.lang.IllegalStateException: Cursor 28 had already been created

2018-02-16 Thread Justin Bertram (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram resolved ARTEMIS-1659.
-
   Resolution: Fixed
Fix Version/s: 2.5.0

>  AMQ224000: Failure in initialisation: java.lang.IllegalStateException: 
> java.lang.IllegalStateException: Cursor 28 had already been created
> ---
>
> Key: ARTEMIS-1659
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1659
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.0.0
> Environment:  Artemis 2
>Reporter: Tom Ross
>Priority: Major
> Fix For: 2.5.0
>
>
> The following exception can be seen in the amq log file 
> {noformat}
> 08:07:04,658 ERROR [org.apache.activemq.artemis.core.server] AMQ224000: 
> Failure in initialisation: java.lang.IllegalStateException: 
> java.lang.IllegalStateException: Cursor 28 had already been created
> at 
> org.apache.activemq.artemis.core.server.QueueConfig$Builder.build(QueueConfig.java:151)
>  [artemis-server-2.0.0.amq-700013-redhat-1.jar:2.0.0.amq-700013-redhat-1]
> at 
> org.apache.activemq.artemis.core.server.impl.PostOfficeJournalLoader.initQueues(PostOfficeJournalLoader.java:154)
>  [artemis-server-2.0.0.amq-700013-redhat-1.jar:2.0.0.amq-700013-redhat-1]
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.loadJournals(ActiveMQServerImpl.java:2481)
>  [artemis-server-2.0.0.amq-700013-redhat-1.jar:2.0.0.amq-700013-redhat-1]
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart2(ActiveMQServerImpl.java:2258)
>  [artemis-server-2.0.0.amq-700013-redhat-1.jar:2.0.0.amq-700013-redhat-1]
> at 
> org.apache.activemq.artemis.core.server.impl.SharedNothingBackupActivation.run(SharedNothingBackupActivation.java:342)
>  [artemis-server-2.0.0.amq-700013-redhat-1.jar:2.0.0.amq-700013-redhat-1]
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$ActivationThread.run(ActiveMQServerImpl.java:2866)
>  [artemis-server-2.0.0.amq-700013-redhat-1.jar:2.0.0.amq-700013-redhat-1]
> Caused by: java.lang.IllegalStateException: Cursor 28 had already been created
> at 
> org.apache.activemq.artemis.core.paging.cursor.impl.PageCursorProviderImpl.createSubscription(PageCursorProviderImpl.java:100)
>  [artemis-server-2.0.0.amq-700013-redhat-1.jar:2.0.0.amq-700013-redhat-1]
> at 
> org.apache.activemq.artemis.core.server.QueueConfig$Builder.build(QueueConfig.java:149)
>  [artemis-server-2.0.0.amq-700013-redhat-1.jar:2.0.0.amq-700013-redhat-1]
> ... 5 more
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1685) Set MQTT connection clientID before session creation

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367411#comment-16367411
 ] 

ASF GitHub Bot commented on ARTEMIS-1685:
-

GitHub user dejanb opened a pull request:

https://github.com/apache/activemq-artemis/pull/1873

ARTEMIS-1685 Set MQTT connection clientID before session creation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dejanb/activemq-artemis mqtt-clientid

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1873.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1873


commit 320033d2f78a619d62d65edae023e3803ba7740e
Author: Dejan Bosanac 
Date:   2018-02-16T14:49:10Z

ARTEMIS-1685 Set MQTT connection clientID before session creation




> Set MQTT connection clientID before session creation
> 
>
> Key: ARTEMIS-1685
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1685
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: MQTT
>Affects Versions: 2.4.0
>Reporter: Dejan Bosanac
>Priority: Major
>
> It will make this property available in the plugin beforeCreateSession()  and 
> afterCreateSession(), which can be useful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ARTEMIS-1685) Set MQTT connection clientID before session creation

2018-02-16 Thread Dejan Bosanac (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dejan Bosanac updated ARTEMIS-1685:
---
Summary: Set MQTT connection clientID before session creation  (was: Set 
connection clientID before session creation)

> Set MQTT connection clientID before session creation
> 
>
> Key: ARTEMIS-1685
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1685
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: MQTT
>Affects Versions: 2.4.0
>Reporter: Dejan Bosanac
>Priority: Major
>
> It will make this property available in the plugin beforeCreateSession()  and 
> afterCreateSession(), which can be useful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ARTEMIS-1685) Set connection clientID before session creation

2018-02-16 Thread Dejan Bosanac (JIRA) 
Dejan Bosanac created ARTEMIS-1685:
--

 Summary: Set connection clientID before session creation
 Key: ARTEMIS-1685
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1685
 Project: ActiveMQ Artemis
  Issue Type: Improvement
  Components: MQTT
Affects Versions: 2.4.0
Reporter: Dejan Bosanac


It will make this property available in the plugin beforeCreateSession()  and 
afterCreateSession(), which can be useful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1660) create-journal-table.oracle does create identity for column id

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366796#comment-16366796
 ] 

ASF GitHub Bot commented on ARTEMIS-1660:
-

Github user jmesnil commented on the issue:

https://github.com/apache/activemq-artemis/pull/1866
  
FWIW, I copied the SQL statement from Artemis 2.4.0 
https://github.com/apache/activemq-artemis/blob/ec63189a0a8235fc0436d9554bcdf323944e1bf6/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/oracle/Oracle12CSQLProvider.java#L26



> create-journal-table.oracle does create identity for column id
> --
>
> Key: ARTEMIS-1660
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1660
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Benjamin Graf
>Priority: Major
>
> Statement contains identity column for id. That's wrong according to generic 
> create statement and leaves invalid storage for userrecordtype 32/45



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1653) Allow database tables to be created externally

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366765#comment-16366765
 ] 

ASF GitHub Bot commented on ARTEMIS-1653:
-

Github user nlippke commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1822#discussion_r168707901
  
--- Diff: 
artemis-server/src/test/java/org/apache/activemq/artemis/core/server/impl/jdbc/JdbcLeaseLockTest.java
 ---
@@ -33,13 +35,31 @@
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameter;
 
+@RunWith(Parameterized.class)
 public class JdbcLeaseLockTest extends ActiveMQTestBase {
 
private JdbcSharedStateManager jdbcSharedStateManager;
private DatabaseStorageConfiguration dbConf;
private SQLProvider sqlProvider;
 
+   @Parameterized.Parameters(name = "create_tables_prior_test")
+   public static List data() {
+  return Arrays.asList(new Object[][] {
+ {true, null},
+ {false, null}
+  });
+   }
+
+   @Parameter(0)
+   public boolean withExistingTable;
+   @Parameter(1)
+   public Object result;
--- End diff --

Your version of Junit requires to work with tuples (input, expecte result). 
Newer versions allow input only. If you don't have this annotation JUnit will 
complain.


> Allow database tables to be created externally
> --
>
> Key: ARTEMIS-1653
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1653
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Niels Lippke
>Priority: Major
>
> In some environments (e.g. production) it is not allowed that applications 
> create their own schema. It's common practice to pass DDL-Statetements to 
> DBAs instead prior to rollout.
> Currently the broker does not support this scenario. If the required tables 
> already exist the broker fails to start.
> A better approach is that if the broker detects empy tables and initializes 
> them in the very same way it does if the tables dont't exist.
> See also discussion in 
> [forum|http://activemq.2283324.n4.nabble.com/ARTEMIS-Server-doesn-t-start-if-JDBC-store-is-used-and-table-NODE-MANAGER-STORE-is-empty-td4735779.html].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1653) Allow database tables to be created externally

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366759#comment-16366759
 ] 

ASF GitHub Bot commented on ARTEMIS-1653:
-

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1822#discussion_r168704701
  
--- Diff: 
artemis-server/src/test/java/org/apache/activemq/artemis/core/server/impl/jdbc/JdbcLeaseLockTest.java
 ---
@@ -33,13 +35,31 @@
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameter;
 
+@RunWith(Parameterized.class)
 public class JdbcLeaseLockTest extends ActiveMQTestBase {
 
private JdbcSharedStateManager jdbcSharedStateManager;
private DatabaseStorageConfiguration dbConf;
private SQLProvider sqlProvider;
 
+   @Parameterized.Parameters(name = "create_tables_prior_test")
+   public static List data() {
+  return Arrays.asList(new Object[][] {
+ {true, null},
+ {false, null}
+  });
+   }
+
+   @Parameter(0)
+   public boolean withExistingTable;
+   @Parameter(1)
+   public Object result;
--- End diff --

'result` isn't used, it is needed?


> Allow database tables to be created externally
> --
>
> Key: ARTEMIS-1653
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1653
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Niels Lippke
>Priority: Major
>
> In some environments (e.g. production) it is not allowed that applications 
> create their own schema. It's common practice to pass DDL-Statetements to 
> DBAs instead prior to rollout.
> Currently the broker does not support this scenario. If the required tables 
> already exist the broker fails to start.
> A better approach is that if the broker detects empy tables and initializes 
> them in the very same way it does if the tables dont't exist.
> See also discussion in 
> [forum|http://activemq.2283324.n4.nabble.com/ARTEMIS-Server-doesn-t-start-if-JDBC-store-is-used-and-table-NODE-MANAGER-STORE-is-empty-td4735779.html].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1656) OpenWire scalability improvements

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366727#comment-16366727
 ] 

ASF GitHub Bot commented on ARTEMIS-1656:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1849
  
I'm going to merge this provided that is not causing any regressions on 
OpenWire tests/compatibility tests :+1: 


> OpenWire scalability improvements
> -
>
> Key: ARTEMIS-1656
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1656
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Minor
>
> OpenWire is using the synchronized OpenWireFormat instance belonging to 
> OpenWireProtocolManager: it won't allow to scale with the number of 
> connections.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1498) [interop] Openwire internal headers should not be part of message properties

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366724#comment-16366724
 ] 

ASF GitHub Bot commented on ARTEMIS-1498:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1793
  
@RaiSaurabh I've just checked vs the `integration/openwire` tests in 
`integration-tests` and it fail 22 tests/338. 
The original number of failing tests here is 1, so anything over this value 
is actually a regression.
I'm not runining the compatibility ones on `activemq5-unit-tests` (my 
notebook could die before finishing them :P) with no reasons.
Please run the tests I've mentioned and try at least to no have regressions 
there: the idea of the original PR is good (very good), but the implementation 
need to be fixed in order to not have huge regressions on how OpenWire is 
working, thanks :+1: 



> [interop] Openwire internal headers should not be part of message properties
> 
>
> Key: ARTEMIS-1498
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1498
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: OpenWire
> Environment: interoperability between Openwire -> AMQP/Core
>Reporter: Michal Toth
>Priority: Minor
>
> Sending an empty message from Openwire JMS client to AMQP or Core receiver 
> client shows extra "internal" headers (__HDR_*) in message properties. 
> They should not be there, as these are internal for broker in my opinion.
> Openwire sender
> {noformat}
> $ java  -jar /var/dtests/node_data/clients/aoc7.jar sender  --timeout 5 
> --log-msgs interop --broker tcp://localhost:61616 --address queue_name_\$ 
> --count 1  --conn-username admin --conn-password admin
> {'durable': True, 'priority': 4, 'ttl': 0, 'first-acquirer': False, 
> 'delivery-count': 0, 'id': 
> 'dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1:1:1:1', 
> 'user-id':None, 'address': 'queue_name_$', 'subject': None, 'reply-to': None, 
> 'correlation-id': None, 'content-type': None, 'content-encoding': None, 
> 'absolute-expiry-time': 0, 'creation-time': 1509702974798, 'group-id': None, 
> 'group-sequence': 0, 'reply-to-group-id': None, 'properties': {}, 'content': 
> None, 'type': None}
> {noformat}
> AMQP/Core receiver
> {noformat}
> $ java  -jar /var/dtests/node_data/clients/aac1.jar receiver  --timeout 5 
> --log-msgs interop --broker localhost:5672 --address queue_name_\$ --count 1  
> --conn-username admin --conn-password admin
> Unsupported object type org.apache.qpid.proton.amqp.Binary 
> \x00\x00\x00Jn\x02\xae\x02{\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01\x00\x01
> Unsupported object type org.apache.qpid.proton.amqp.Binary 
> \x00\x00\x00F{\x01+\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01
> {'durable': True, 'priority': 4, 'ttl': 0, 'first-acquirer': False, 
> 'delivery-count': 0, 'id': None, 'user-id': None, 'address': 'queue_name_$', 
> 'subject': None, 'reply-to': None, 'correlation-id': None, 'content-type': 
> None, 'content-encoding': None, 'absolute-expiry-time': 0, 'creation-time': 
> 1509702974798, 'group-id': None, 'group-sequence': 0, 'reply-to-group-id': 
> None, 'properties': {'__HDR_COMMAND_ID': 5, 'JMSXDeliveryCount': 1, 
> '__HDR_ARRIVAL': 0, '__HDR_MESSAGE_ID': 
> \x00\x00\x00Jn\x02\xae\x02{\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01\x00\x01,
>  '__HDR_GROUP_SEQUENCE': 0, '__HDR_PRODUCER_ID': 
> \x00\x00\x00F{\x01+\x00=ID:dhcp-145-96.lab.eng.brq.redhat.com-33646-1509702974536-1:1\x00\x01\x00\x01,
>  '__HDR_DROPPABLE': False, '__HDR_BROKER_IN_TIME': 1509702974800}, 'content': 
> None}
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1660) create-journal-table.oracle does create identity for column id

2018-02-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366716#comment-16366716
 ] 

ASF GitHub Bot commented on ARTEMIS-1660:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1866
  
@graben 
> Well, I'm actually not able to test against oracle 12 only have a oracle 
11 express instance

It would be enough: it is just to validate the changes.

> But it is obvious that the autoincrement of id is wrong, since it is 1st 
managed by the broker and 2nd different to all other database types.

Agree but would be anyway welcome at least a test round with the change.
I will ping @mtaylor and @jmesnil authors of most the SQL contained there 
to validate it: if they think that the change is safe as it seems, for me is ok 
:+1: 



> create-journal-table.oracle does create identity for column id
> --
>
> Key: ARTEMIS-1660
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1660
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Benjamin Graf
>Priority: Major
>
> Statement contains identity column for id. That's wrong according to generic 
> create statement and leaves invalid storage for userrecordtype 32/45



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)