[jira] [Work logged] (AMQNET-596) Support LocalMessageExpiry property for NMS AMQP

2019-08-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/AMQNET-596?focusedWorklogId=292357=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292357
 ]

ASF GitHub Bot logged work on AMQNET-596:
-

Author: ASF GitHub Bot
Created on: 10/Aug/19 00:06
Start Date: 10/Aug/19 00:06
Worklog Time Spent: 10m 
  Work Description: cjwmorgan-sol commented on issue #15: AMQNET-596: Added 
local message expiry connection uri connection property
URL: https://github.com/apache/activemq-nms-amqp/pull/15#issuecomment-520099489
 
 
   @michaelandrepearce and @HarvetGC please take a look.
   I added some tests based off of qpid jms however I think I'll need some 
changes from #9 to assert the amqp frames properly.
   I also verified the Helloworld application does receive messages when the 
property is set to false.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 292357)
Time Spent: 0.5h  (was: 20m)

> Support LocalMessageExpiry property for NMS AMQP
> 
>
> Key: AMQNET-596
> URL: https://issues.apache.org/jira/browse/AMQNET-596
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: AMQP, NMS
>Reporter: Chris Morgan
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Qpid Jms has a connection property to Enable/Disable LocalMessageExpiry. The 
> nms amqp provider should support this property as some amqp brokers do not 
> support LocalMessageExpiry at the protocol level over amqp.
>  
> This property should be added to the NmsConnectionFactory, along with the 
> ConnectionInfo Class and the ConsumerInfo Class and applied at consumer 
> message receive.
>  
> The default value in qpid jms is true to have the nms amqp provider should 
> have the same default.
>  
> The string name of the property will be "nms.localMessagePriority".



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Work logged] (AMQNET-596) Support LocalMessageExpiry property for NMS AMQP

2019-08-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/AMQNET-596?focusedWorklogId=292355=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292355
 ]

ASF GitHub Bot logged work on AMQNET-596:
-

Author: ASF GitHub Bot
Created on: 10/Aug/19 00:04
Start Date: 10/Aug/19 00:04
Worklog Time Spent: 10m 
  Work Description: cjwmorgan-sol commented on issue #15: AMQNET-596: Added 
local message expiry connection uri connection property
URL: https://github.com/apache/activemq-nms-amqp/pull/15#issuecomment-520099489
 
 
   @michaelandrepearce and @HarvetGC please take a look.
   I added some tests based off of qpid jms however I think I'll need some 
changes from #9 to assert the amqp frames properly.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 292355)
Time Spent: 20m  (was: 10m)

> Support LocalMessageExpiry property for NMS AMQP
> 
>
> Key: AMQNET-596
> URL: https://issues.apache.org/jira/browse/AMQNET-596
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: AMQP, NMS
>Reporter: Chris Morgan
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Qpid Jms has a connection property to Enable/Disable LocalMessageExpiry. The 
> nms amqp provider should support this property as some amqp brokers do not 
> support LocalMessageExpiry at the protocol level over amqp.
>  
> This property should be added to the NmsConnectionFactory, along with the 
> ConnectionInfo Class and the ConsumerInfo Class and applied at consumer 
> message receive.
>  
> The default value in qpid jms is true to have the nms amqp provider should 
> have the same default.
>  
> The string name of the property will be "nms.localMessagePriority".



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Work logged] (AMQNET-596) Support LocalMessageExpiry property for NMS AMQP

2019-08-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/AMQNET-596?focusedWorklogId=292350=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292350
 ]

ASF GitHub Bot logged work on AMQNET-596:
-

Author: ASF GitHub Bot
Created on: 10/Aug/19 00:01
Start Date: 10/Aug/19 00:01
Worklog Time Spent: 10m 
  Work Description: cjwmorgan-sol commented on pull request #15: 
AMQNET-596: Added local message expiry connection uri connection property
URL: https://github.com/apache/activemq-nms-amqp/pull/15
 
 
   
   Message consumer only filter expired messages when local message expiry is 
enabled
   
   Added message expiration integration test
   
   Signed-off-by: cjwmorgan-sol 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 292350)
Time Spent: 10m
Remaining Estimate: 0h

> Support LocalMessageExpiry property for NMS AMQP
> 
>
> Key: AMQNET-596
> URL: https://issues.apache.org/jira/browse/AMQNET-596
> Project: ActiveMQ .Net
>  Issue Type: Improvement
>  Components: AMQP, NMS
>Reporter: Chris Morgan
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Qpid Jms has a connection property to Enable/Disable LocalMessageExpiry. The 
> nms amqp provider should support this property as some amqp brokers do not 
> support LocalMessageExpiry at the protocol level over amqp.
>  
> This property should be added to the NmsConnectionFactory, along with the 
> ConnectionInfo Class and the ConsumerInfo Class and applied at consumer 
> message receive.
>  
> The default value in qpid jms is true to have the nms amqp provider should 
> have the same default.
>  
> The string name of the property will be "nms.localMessagePriority".



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (AMQNET-596) Support LocalMessageExpiry property for NMS AMQP

2019-08-09 Thread Chris Morgan (JIRA)
Chris Morgan created AMQNET-596:
---

 Summary: Support LocalMessageExpiry property for NMS AMQP
 Key: AMQNET-596
 URL: https://issues.apache.org/jira/browse/AMQNET-596
 Project: ActiveMQ .Net
  Issue Type: Improvement
  Components: AMQP, NMS
Reporter: Chris Morgan


Qpid Jms has a connection property to Enable/Disable LocalMessageExpiry. The 
nms amqp provider should support this property as some amqp brokers do not 
support LocalMessageExpiry at the protocol level over amqp.

 

This property should be added to the NmsConnectionFactory, along with the 
ConnectionInfo Class and the ConsumerInfo Class and applied at consumer message 
receive.

 

The default value in qpid jms is true to have the nms amqp provider should have 
the same default.

 

The string name of the property will be "nms.localMessagePriority".



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Work logged] (ARTEMIS-2433) Support LDAP role mapping of SASL EXTERNAL credentials

2019-08-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2433?focusedWorklogId=292085=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292085
 ]

ASF GitHub Bot logged work on ARTEMIS-2433:
---

Author: ASF GitHub Bot
Created on: 09/Aug/19 14:45
Start Date: 09/Aug/19 14:45
Worklog Time Spent: 10m 
  Work Description: gtully commented on issue #2768: ARTEMIS-2433 add 
ExternalCertificateLoginModule to surface a SASL EXT…
URL: https://github.com/apache/activemq-artemis/pull/2768#issuecomment-519946775
 
 
   pushed an update with a rebase to resolve the conflict the ldif file
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 292085)
Time Spent: 40m  (was: 0.5h)

> Support LDAP role mapping of SASL EXTERNAL credentials
> --
>
> Key: ARTEMIS-2433
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2433
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: AMQP, Broker
>Affects Versions: 2.9.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
>  Labels: AMQP, LDAP, SASL
> Fix For: 2.10.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> currently the textcertificate login module must be used with SASL EXTERNAL. 
> There is no other way to do authorisation and role assignment.
> however a validated TLS certificate subject dn is a valid identity, in the 
> same way as a kerberos token identity. If we provide a login module that will 
> populate a subject principal with the subject DN, it will be possible to 
> chain with the LDAPLoginModule and have LDAP used for role assignment. In 
> LDAP, the CERT subjectDN just needs to be added as a member to any existing 
> role definition.
> LDAPLoginModule can be configured to not authenticate, not lookup the user 
> and *just* do role assignment.
> authenticateUser=false and default/empty userSearchMatching



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Work logged] (ARTEMIS-2433) Support LDAP role mapping of SASL EXTERNAL credentials

2019-08-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2433?focusedWorklogId=292077=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292077
 ]

ASF GitHub Bot logged work on ARTEMIS-2433:
---

Author: ASF GitHub Bot
Created on: 09/Aug/19 14:41
Start Date: 09/Aug/19 14:41
Worklog Time Spent: 10m 
  Work Description: gtully commented on issue #2768: ARTEMIS-2433 add 
ExternalCertificateLoginModule to surface a SASL EXT…
URL: https://github.com/apache/activemq-artemis/pull/2768#issuecomment-519945189
 
 
   I don't think this is a candidate for the cli, the setup of jaas login 
config is too context specific
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 292077)
Time Spent: 0.5h  (was: 20m)

> Support LDAP role mapping of SASL EXTERNAL credentials
> --
>
> Key: ARTEMIS-2433
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2433
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: AMQP, Broker
>Affects Versions: 2.9.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
>  Labels: AMQP, LDAP, SASL
> Fix For: 2.10.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> currently the textcertificate login module must be used with SASL EXTERNAL. 
> There is no other way to do authorisation and role assignment.
> however a validated TLS certificate subject dn is a valid identity, in the 
> same way as a kerberos token identity. If we provide a login module that will 
> populate a subject principal with the subject DN, it will be possible to 
> chain with the LDAPLoginModule and have LDAP used for role assignment. In 
> LDAP, the CERT subjectDN just needs to be added as a member to any existing 
> role definition.
> LDAPLoginModule can be configured to not authenticate, not lookup the user 
> and *just* do role assignment.
> authenticateUser=false and default/empty userSearchMatching



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Work logged] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE

2019-08-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=292019=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292019
 ]

ASF GitHub Bot logged work on ARTEMIS-2450:
---

Author: ASF GitHub Bot
Created on: 09/Aug/19 12:09
Start Date: 09/Aug/19 12:09
Worklog Time Spent: 10m 
  Work Description: wy96f commented on pull request #2791: ARTEMIS-2450 
page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 292019)
Time Spent: 10m
Remaining Estimate: 0h

> page-size-bytes should not be greater than Integer.MAX_VALUE
> 
>
> Key: ARTEMIS-2450
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2450
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: yangwei
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (ARTEMIS-2450) page-size-bytes should not be greater than Integer.MAX_VALUE

2019-08-09 Thread yangwei (JIRA)
yangwei created ARTEMIS-2450:


 Summary: page-size-bytes should not be greater than 
Integer.MAX_VALUE
 Key: ARTEMIS-2450
 URL: https://issues.apache.org/jira/browse/ARTEMIS-2450
 Project: ActiveMQ Artemis
  Issue Type: Bug
  Components: Broker
Reporter: yangwei






--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Assigned] (ARTEMIS-2437) AMQP message conversion fails if annotations contain values outwith simple property types

2019-08-09 Thread Robbie Gemmell (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reassigned ARTEMIS-2437:
---

Assignee: Timothy Bish
 Summary: AMQP message conversion fails if annotations contain values 
outwith simple property types  (was: AMQ224046: Exception while browser handled 
from Reference[627]:NON-RELIABLE:AMQPMessage [...]: java.lang.RuntimeException: 
class java.util.LinkedHashMap is not a valid property type)

This issue simplifies to simply sending an AMQP message annotation that doesn't 
fit within the basic JMS style property types and triggering a message 
conversion. The broker converts the message to Core messages at various points 
(cross protocol traffic such as here, larger messages, clustering, possibly 
others) but the conversion fails to handle the possible annotation types, such 
as a map in this particular case.

> AMQP message conversion fails if annotations contain values outwith simple 
> property types
> -
>
> Key: ARTEMIS-2437
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2437
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.9.0
>Reporter: Jiri Daněk
>Assignee: Timothy Bish
>Priority: Major
>
> {noformat}
> $ bin/artemis browser --destination example
> Consumer:: filter = null
> Consumer ActiveMQQueue[example], thread=0 trying to browse 1000 messages
> [...]
> Consumer ActiveMQQueue[example], thread=0 browsing Alert!!!
> Consumer ActiveMQQueue[example], thread=0 browsed: 4 messages
> Consumer ActiveMQQueue[example], thread=0 Browser thread finished
> {noformat}
> In fact, there is 5 messages in the queue, and probably when browsing last 
> one, the following error is printed to broker stdout.
> {noformat}
> 2019-07-31 15:07:30,742 ERROR [org.apache.activemq.artemis.core.server] 
> AMQ224046: Exception while browser handled from 
> Reference[627]:NON-RELIABLE:AMQPMessage [durable=false, messageID=627, 
> address=example, size=121, applicationProperties=null, 
> properties=Properties{messageId=null, userId=null, to='null', subject='null', 
> replyTo='null', correlationId=null, contentType=null, contentEncoding=null, 
> absoluteExpiryTime=null, creationTime=null, groupId='null', 
> groupSequence=null, replyToGroupId='null'}, extraProperties = 
> TypedProperties[_AMQ_AD=example]]: java.lang.RuntimeException: class 
> java.util.LinkedHashMap is not a valid property type
> at 
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.toCore(AMQPMessage.java:695)
>  [artemis-amqp-protocol-2.9.0.jar:2.9.0]
> at 
> org.apache.activemq.artemis.core.protocol.core.impl.CoreSessionCallback.sendMessage(CoreSessionCallback.java:123)
>  [artemis-server-2.9.0.jar:2.9.0]
> at 
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1168)
>  [artemis-server-2.9.0.jar:2.9.0]
> at 
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:510)
>  [artemis-server-2.9.0.jar:2.9.0]
> at 
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl$BrowserDeliverer.run(ServerConsumerImpl.java:1484)
>  [artemis-server-2.9.0.jar:2.9.0]
> at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  [artemis-commons-2.9.0.jar:2.9.0]
> at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
>  [artemis-commons-2.9.0.jar:2.9.0]
> at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
>  [artemis-commons-2.9.0.jar:2.9.0]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  [rt.jar:1.8.0_212]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [rt.jar:1.8.0_212]
> at 
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
>  [artemis-commons-2.9.0.jar:2.9.0]
> Caused by: 
> org.apache.activemq.artemis.api.core.ActiveMQPropertyConversionException: 
> class java.util.LinkedHashMap is not a valid property type
> at 
> org.apache.activemq.artemis.utils.collections.TypedProperties.setObjectProperty(TypedProperties.java:1112)
>  [artemis-commons-2.9.0.jar:2.9.0]
> at 
> org.apache.activemq.artemis.core.message.impl.CoreMessage.putObjectProperty(CoreMessage.java:1014)
>  [artemis-core-client-2.9.0.jar:2.9.0]
> at 
> org.apache.activemq.artemis.core.message.impl.CoreMessage.putObjectProperty(CoreMessage.java:1030)
>  [artemis-core-client-2.9.0.jar:2.9.0]
> at 
>