[jira] [Created] (ARTEMIS-2522) Docker file does not work with GCP kubernetes
Philip Brown created ARTEMIS-2522: - Summary: Docker file does not work with GCP kubernetes Key: ARTEMIS-2522 URL: https://issues.apache.org/jira/browse/ARTEMIS-2522 Project: ActiveMQ Artemis Issue Type: Bug Affects Versions: 2.10.1 Reporter: Philip Brown I made a google cloud kubernetes container, and tried to use their standard GUI for automated docker building an image. They have a fairly standard process: 1. designate a github repo 2. designate the Dockerfile in the repo 3. "go". I picked Dockerfile-centos, and it mostly worked, until the end. Transaction Summary Install 1 Package Total download size: 24 k Installed size: 38 k Downloading packages: Running transaction check Running transaction test Transaction test succeeded Running transaction Installing : libaio-0.3.109-13.el7.x86_64 1/1 Verifying : libaio-0.3.109-13.el7.x86_64 1/1 Installed: libaio.x86_64 0:0.3.109-13.el7 Complete! Loaded plugins: fastestmirror, ovl Cleaning repos: base extras updates Cleaning up list of fastest mirrors Removing intermediate container e43bbbc10606 ---> 554142e64a2b Step 11/21 : USER artemis ---> Running in 07fafffa7b45 Removing intermediate container 07fafffa7b45 ---> 57ef2ee28a0b Step 12/21 : ADD . /opt/activemq-artemis ---> 2c2fcc98c888 Step 13/21 : EXPOSE 8161 9404 61616 5445 5672 1883 61613 ---> Running in 57c28bb7358e Removing intermediate container 57c28bb7358e ---> 00d0ffeb141f Step 14/21 : USER root ---> Running in 0a15a089f1d8 Removing intermediate container 0a15a089f1d8 ---> de284adad6a7 Step 15/21 : RUN mkdir /var/lib/artemis-instance && chown -R artemis.artemis /var/lib/artemis-instance ---> Running in a8226f65442e Removing intermediate container a8226f65442e ---> 436a623d226e Step 16/21 : COPY ./docker/docker-run.sh / COPY failed: stat /var/lib/docker/tmp/docker-builder095519310/docker/docker-run.sh: no such file or directory ERROR ERROR: build step 0 "gcr.io/cloud-builders/docker" failed: exit status 1 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2504) Support retroactive addresses
[ https://issues.apache.org/jira/browse/ARTEMIS-2504?focusedWorklogId=330166&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330166 ] ASF GitHub Bot logged work on ARTEMIS-2504: --- Author: ASF GitHub Bot Created on: 17/Oct/19 22:07 Start Date: 17/Oct/19 22:07 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2850: ARTEMIS-2504 implement retroactive addresses URL: https://github.com/apache/activemq-artemis/pull/2850#issuecomment-543381734 No further comments from me atm other bits and bobs can always be added later in future prs /version and refined over time. Thanks for this @jbertram was prob the last big ticket for artemis to be in feature parity with activemq5. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 330166) Time Spent: 7h 40m (was: 7.5h) > Support retroactive addresses > - > > Key: ARTEMIS-2504 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2504 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 7h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2504) Support retroactive addresses
[ https://issues.apache.org/jira/browse/ARTEMIS-2504?focusedWorklogId=330125&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330125 ] ASF GitHub Bot logged work on ARTEMIS-2504: --- Author: ASF GitHub Bot Created on: 17/Oct/19 20:31 Start Date: 17/Oct/19 20:31 Worklog Time Spent: 10m Work Description: jbertram commented on issue #2850: ARTEMIS-2504 implement retroactive addresses URL: https://github.com/apache/activemq-artemis/pull/2850#issuecomment-543349109 I added a simple failover test and pushed. Everything looks OK as far as I can tell. As far as the "destructive testing" you mentioned goes, I've done a bit more than what is captured in the tests, but nothing I could categorize as industrial grade (e.g. no huge loads on big hardware). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 330125) Time Spent: 7.5h (was: 7h 20m) > Support retroactive addresses > - > > Key: ARTEMIS-2504 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2504 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 7.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2504) Support retroactive addresses
[ https://issues.apache.org/jira/browse/ARTEMIS-2504?focusedWorklogId=330124&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330124 ] ASF GitHub Bot logged work on ARTEMIS-2504: --- Author: ASF GitHub Bot Created on: 17/Oct/19 20:30 Start Date: 17/Oct/19 20:30 Worklog Time Spent: 10m Work Description: jbertram commented on issue #2850: ARTEMIS-2504 implement retroactive addresses URL: https://github.com/apache/activemq-artemis/pull/2850#issuecomment-543349109 I added a simple failover test and push. Everything looks OK as far as I can tell. As far as the "destructive testing" you mentioned goes, I've done a bit more than what is captured in the tests, but nothing I could categorize as industrial grade (e.g. no huge loads on big hardware). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 330124) Time Spent: 7h 20m (was: 7h 10m) > Support retroactive addresses > - > > Key: ARTEMIS-2504 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2504 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 7h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2420) Reimplementation of AMQ5 dead letter strategy queuePrefix
[ https://issues.apache.org/jira/browse/ARTEMIS-2420?focusedWorklogId=330090&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330090 ] ASF GitHub Bot logged work on ARTEMIS-2420: --- Author: ASF GitHub Bot Created on: 17/Oct/19 19:44 Start Date: 17/Oct/19 19:44 Worklog Time Spent: 10m Work Description: rcsilva83 commented on issue #2760: ARTEMIS-2420 Adding support for DLA/DLQ prefix for wildcard addresses URL: https://github.com/apache/activemq-artemis/pull/2760#issuecomment-543332194 Please, support suffix on "dead-letter-address-auto-create" element too. We prefer "Queue.Name.DLQ" so DLQ queues stay close to the original ones in alphabetical order. This is how our current ActiveMQ is configured. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 330090) Remaining Estimate: 0h (was: 10m) Time Spent: 12h (was: 11h 50m) > Reimplementation of AMQ5 dead letter strategy queuePrefix > - > > Key: ARTEMIS-2420 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2420 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.9.0 >Reporter: Piotr Klimczak >Priority: Major > Original Estimate: 12h > Time Spent: 12h > Remaining Estimate: 0h > > ActiveMQ Classic supports DLQ prefixes for dynamically created destinations. > This causes regression when switching from AMQ5 to AMQ Artemis, therefore it > should be reimplemented. > *Detailed requirements* > *Configuration* > # Prefix for dead-letter-address-auto-create is mandatory, while the tag > itself is optional - DONE > # All attributes for dead-letter-address-auto-create are optional, in which > case values will be taken from origin queue - DONE > ** routing type for DLQ > ** temporary > ** durable can be null > # DLA settings can be defined with address-settings with wildcard match - > DONE > # Should throw error if both DLA and auto-create DLA are defined for same AS > - *TODO* > Example > {code:xml} > > >MULTICAST >true >false > > > > > > {code} > Questions: > # [michaelpearce-gain|https://github.com/michaelpearce-gain]: What occurs if > both dead letter address is set and prefix? > # [michaelpearce-gain|https://github.com/michaelpearce-gain]: Is there auto > clean up, so the auto created dead letter addresses are removed when the > original address is removed, in cases of auto creation. > # [michaelpearce-gain|https://github.com/michaelpearce-gain]: Also would it > be possible to configure a spefiic queue to goto a specific address, taking > precedence over the default prefix when set. > ** This is how it should work now- *TODO* test coverage > # [michaelpearce-gain|https://github.com/michaelpearce-gain]:I dea around > security and address creation restrictions, could that both the address and > queue settings are checked both for the new address/queue and the dead > letter, before it is created. Thus meaning that either both create (because > permission and settings allow) or both wouldnt. Thus avoiding the situation > of one being created without the other > ** Not sure if I understand above- *TODO* get clarification > *Message delivery to DLQ* > # Delivery to dynamic DLQ only happens for messages failed by a consumer - > DONE > # Delivery to dynamic addresses should happen using FQQN address, regardless > of routing - DONE > # [michaelpearce-gain|https://github.com/michaelpearce-gain]: The same > should be made for expiryQueues with all the same rules and logic - DONE > Questions: > # Should dynamic DLQ creation also work for messages delivered to an address > with no queues? > *Security* > # TODO Consolidate security requirements from original PR: > [https://github.com/apache/activemq-artemis/pull/2747] > > Questions: > # [michaelpearce-gain|https://github.com/michaelpearce-gain]: What occurs if > queue/address is allowed to be created due security settings, but the user > able to do that is unable to create the dead letter address? Do both fail? > Does one part succeed but the dla fails? And then what occurs? > # [michaelpearce-gain|https://github.com/michaelpearce-gain]: What occurs > when security settings come into play? How does it fail if you have ability > to create address but not dla? Do both fail? > > Links to all conversa
[jira] [Work logged] (ARTEMIS-2521) Role-mapping not described in documentation
[ https://issues.apache.org/jira/browse/ARTEMIS-2521?focusedWorklogId=329925&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329925 ] ASF GitHub Bot logged work on ARTEMIS-2521: --- Author: ASF GitHub Bot Created on: 17/Oct/19 15:04 Start Date: 17/Oct/19 15:04 Worklog Time Spent: 10m Work Description: jbertram commented on issue #2865: ARTEMIS-2521 add documentation for role-mapping URL: https://github.com/apache/activemq-artemis/pull/2865#issuecomment-543218430 Thanks for the PR! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 329925) Time Spent: 40m (was: 0.5h) > Role-mapping not described in documentation > --- > > Key: ARTEMIS-2521 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2521 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.10.0 >Reporter: Sascha Dirbach >Priority: Minor > Fix For: 2.11.0 > > Time Spent: 40m > Remaining Estimate: 0h > > The role-mapping as implemented in #ARTEMIS-1116 is not explained in the > documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARTEMIS-2521) Role-mapping not described in documentation
[ https://issues.apache.org/jira/browse/ARTEMIS-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram resolved ARTEMIS-2521. - Fix Version/s: 2.11.0 Resolution: Fixed > Role-mapping not described in documentation > --- > > Key: ARTEMIS-2521 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2521 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.10.0 >Reporter: Sascha Dirbach >Priority: Minor > Fix For: 2.11.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The role-mapping as implemented in #ARTEMIS-1116 is not explained in the > documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2521) Role-mapping not described in documentation
[ https://issues.apache.org/jira/browse/ARTEMIS-2521?focusedWorklogId=329923&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329923 ] ASF GitHub Bot logged work on ARTEMIS-2521: --- Author: ASF GitHub Bot Created on: 17/Oct/19 15:03 Start Date: 17/Oct/19 15:03 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2865: ARTEMIS-2521 add documentation for role-mapping URL: https://github.com/apache/activemq-artemis/pull/2865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 329923) Time Spent: 20m (was: 10m) > Role-mapping not described in documentation > --- > > Key: ARTEMIS-2521 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2521 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.10.0 >Reporter: Sascha Dirbach >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > The role-mapping as implemented in #ARTEMIS-1116 is not explained in the > documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2521) Role-mapping not described in documentation
[ https://issues.apache.org/jira/browse/ARTEMIS-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953830#comment-16953830 ] ASF subversion and git services commented on ARTEMIS-2521: -- Commit 8043828e84f74f458796ef322871630ad30d3465 in activemq-artemis's branch refs/heads/master from Sascha Dirbach [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=8043828 ] ARTEMIS-2521 add documentation for role-mapping > Role-mapping not described in documentation > --- > > Key: ARTEMIS-2521 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2521 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.10.0 >Reporter: Sascha Dirbach >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The role-mapping as implemented in #ARTEMIS-1116 is not explained in the > documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2521) Role-mapping not described in documentation
[ https://issues.apache.org/jira/browse/ARTEMIS-2521?focusedWorklogId=329924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329924 ] ASF GitHub Bot logged work on ARTEMIS-2521: --- Author: ASF GitHub Bot Created on: 17/Oct/19 15:03 Start Date: 17/Oct/19 15:03 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2865: ARTEMIS-2521 add documentation for role-mapping URL: https://github.com/apache/activemq-artemis/pull/2865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 329924) Time Spent: 0.5h (was: 20m) > Role-mapping not described in documentation > --- > > Key: ARTEMIS-2521 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2521 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.10.0 >Reporter: Sascha Dirbach >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > The role-mapping as implemented in #ARTEMIS-1116 is not explained in the > documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2426) Allow artemis-native loading Libraries from Bundle
[ https://issues.apache.org/jira/browse/ARTEMIS-2426?focusedWorklogId=329852&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329852 ] ASF GitHub Bot logged work on ARTEMIS-2426: --- Author: ASF GitHub Bot Created on: 17/Oct/19 13:17 Start Date: 17/Oct/19 13:17 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #4: ARTEMIS-2426 Added Bundle-Native code header URL: https://github.com/apache/activemq-artemis-native/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 329852) Time Spent: 20m (was: 10m) > Allow artemis-native loading Libraries from Bundle > -- > > Key: ARTEMIS-2426 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2426 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: ActiveMQ-Artemis-Native >Affects Versions: native-1.0.0 >Reporter: Rico Neubauer >Assignee: Clebert Suconic >Priority: Major > Fix For: native-1.1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > artemis-native currently expects the native libraries to be in the native > library path on filesystem. The libraries are shipped in the bundle though > already. > There is header _Bundle-Native_ which can be used to declare the path inside > the bundle to look for the libraries. The way they get loaded > (System.loadLibrary) already matches to find them. > See section 3.10 in OSGi spec (4.3). > Will push a PR, which creates the header for x86 and x86-64, since those are > the 2 that are also shipped in the bundle. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ARTEMIS-2426) Allow artemis-native loading Libraries from Bundle
[ https://issues.apache.org/jira/browse/ARTEMIS-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic updated ARTEMIS-2426: - Issue Type: Improvement (was: New Feature) > Allow artemis-native loading Libraries from Bundle > -- > > Key: ARTEMIS-2426 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2426 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: ActiveMQ-Artemis-Native >Affects Versions: native-1.0.0 >Reporter: Rico Neubauer >Assignee: Clebert Suconic >Priority: Major > Fix For: native-1.1.0 > > Time Spent: 10m > Remaining Estimate: 0h > > artemis-native currently expects the native libraries to be in the native > library path on filesystem. The libraries are shipped in the bundle though > already. > There is header _Bundle-Native_ which can be used to declare the path inside > the bundle to look for the libraries. The way they get loaded > (System.loadLibrary) already matches to find them. > See section 3.10 in OSGi spec (4.3). > Will push a PR, which creates the header for x86 and x86-64, since those are > the 2 that are also shipped in the bundle. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ARTEMIS-2426) Allow artemis-native loading Libraries from Bundle
[ https://issues.apache.org/jira/browse/ARTEMIS-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic updated ARTEMIS-2426: - Fix Version/s: native-1.1.0 > Allow artemis-native loading Libraries from Bundle > -- > > Key: ARTEMIS-2426 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2426 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: ActiveMQ-Artemis-Native >Affects Versions: native-1.0.0 >Reporter: Rico Neubauer >Assignee: Clebert Suconic >Priority: Major > Fix For: native-1.1.0 > > Time Spent: 10m > Remaining Estimate: 0h > > artemis-native currently expects the native libraries to be in the native > library path on filesystem. The libraries are shipped in the bundle though > already. > There is header _Bundle-Native_ which can be used to declare the path inside > the bundle to look for the libraries. The way they get loaded > (System.loadLibrary) already matches to find them. > See section 3.10 in OSGi spec (4.3). > Will push a PR, which creates the header for x86 and x86-64, since those are > the 2 that are also shipped in the bundle. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2426) Allow artemis-native loading Libraries from Bundle
[ https://issues.apache.org/jira/browse/ARTEMIS-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953499#comment-16953499 ] Rico Neubauer commented on ARTEMIS-2426: fyi: Resulting Manifest entry: {noformat} Bundle-NativeCode: lib/linux-i686/libartemis-native-32.so; osname=Linux; processor=x86, lib/linux-x86_64/libartemis-native-64.so; osname=Linux; processor=x86-64, *{noformat} > Allow artemis-native loading Libraries from Bundle > -- > > Key: ARTEMIS-2426 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2426 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: ActiveMQ-Artemis-Native >Affects Versions: native-1.0.0 >Reporter: Rico Neubauer >Assignee: Clebert Suconic >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > artemis-native currently expects the native libraries to be in the native > library path on filesystem. The libraries are shipped in the bundle though > already. > There is header _Bundle-Native_ which can be used to declare the path inside > the bundle to look for the libraries. The way they get loaded > (System.loadLibrary) already matches to find them. > See section 3.10 in OSGi spec (4.3). > Will push a PR, which creates the header for x86 and x86-64, since those are > the 2 that are also shipped in the bundle. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2503) Improve wildcards for the roles access match
[ https://issues.apache.org/jira/browse/ARTEMIS-2503?focusedWorklogId=329692&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-329692 ] ASF GitHub Bot logged work on ARTEMIS-2503: --- Author: ASF GitHub Bot Created on: 17/Oct/19 08:25 Start Date: 17/Oct/19 08:25 Worklog Time Spent: 10m Work Description: brusdev commented on pull request #2851: ARTEMIS-2503 Improve wildcards for the roles access match URL: https://github.com/apache/activemq-artemis/pull/2851#discussion_r335870325 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/JMXAccessControlList.java ## @@ -25,12 +25,22 @@ import java.util.Map; import java.util.concurrent.ConcurrentHashMap; +import org.apache.activemq.artemis.core.config.WildcardConfiguration; +import org.apache.activemq.artemis.core.settings.HierarchicalRepository; +import org.apache.activemq.artemis.core.settings.impl.HierarchicalObjectRepository; + public class JMXAccessControlList { private Access defaultAccess = new Access("*"); - private Map domainAccess = new HashMap<>(); + private HierarchicalRepository domainAccess; private ConcurrentHashMap> whitelist = new ConcurrentHashMap<>(); + public JMXAccessControlList() { + WildcardConfiguration domainAccessWildcardConfiguration = new WildcardConfiguration(); Review comment: I pushed a commit to simplify the improvement. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 329692) Time Spent: 3.5h (was: 3h 20m) > Improve wildcards for the roles access match > > > Key: ARTEMIS-2503 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2503 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Bruscino >Priority: Major > Time Spent: 3.5h > Remaining Estimate: 0h > > Please improve wildcard support for the key element in the roles access > element. > ATM you can NOT apply a restriction across a set of queue instances starting > with the same prefix (like below): > {code:java} > > > >... > {code} > If queues are created dynamically and only a queue name "prefix" is known in > advance; JMX RBAC cannot be used to restrict access in this case. -- This message was sent by Atlassian Jira (v8.3.4#803005)