[jira] [Commented] (ARTEMIS-1803) Pass ServerConsumer to messageExpired and messageAcknowledged plugin callbacks
[ https://issues.apache.org/jira/browse/ARTEMIS-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438369#comment-16438369 ] ASF subversion and git services commented on ARTEMIS-1803: -- Commit bddfa4892b1c0a4085069f7d015f0ac946f1d416 in activemq-artemis's branch refs/heads/master from [~cshannon] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=bddfa48 ] ARTEMIS-1803 - Pass ServerConsumer to messageExpired and messageAcknowledged plugin callback methods Knowing the consumer that expired or acked a message (if available) is useful and right now a message reference only contains a consumer id which by itself is not unique so the actual consumer needs to be passed > Pass ServerConsumer to messageExpired and messageAcknowledged plugin callbacks > -- > > Key: ARTEMIS-1803 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1803 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.5.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Minor > > Right now a MessageReference will track a consumerId (in certain scenarios) > but the sessionId is not included. This is a problem because consumerIds are > not unique and are duplicated across sessions. In order to find a unique > consumer you need the sessionId and consumerId as well. This is a problem > for plugins implementing messageExpired and messageAcknowledged as they can't > get the exact consumer based on just the consumerId. > To solve this the ServerConsumer object responsible for acknowledging the > message or expiring the message should be passed to those callback methods. > If consumer doesn't apply (such as when the broker expires internally or > internally moves messages and acks) then the consumer object will be null. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1803) Pass ServerConsumer to messageExpired and messageAcknowledged plugin callbacks
[ https://issues.apache.org/jira/browse/ARTEMIS-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438370#comment-16438370 ] ASF GitHub Bot commented on ARTEMIS-1803: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2012 > Pass ServerConsumer to messageExpired and messageAcknowledged plugin callbacks > -- > > Key: ARTEMIS-1803 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1803 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.5.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Minor > > Right now a MessageReference will track a consumerId (in certain scenarios) > but the sessionId is not included. This is a problem because consumerIds are > not unique and are duplicated across sessions. In order to find a unique > consumer you need the sessionId and consumerId as well. This is a problem > for plugins implementing messageExpired and messageAcknowledged as they can't > get the exact consumer based on just the consumerId. > To solve this the ServerConsumer object responsible for acknowledging the > message or expiring the message should be passed to those callback methods. > If consumer doesn't apply (such as when the broker expires internally or > internally moves messages and acks) then the consumer object will be null. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1803) Pass ServerConsumer to messageExpired and messageAcknowledged plugin callbacks
[ https://issues.apache.org/jira/browse/ARTEMIS-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437496#comment-16437496 ] ASF GitHub Bot commented on ARTEMIS-1803: - Github user cshannon commented on the issue: https://github.com/apache/activemq-artemis/pull/2012 @franz1981 and @michaelandrepearce - thanks for taking a look > Pass ServerConsumer to messageExpired and messageAcknowledged plugin callbacks > -- > > Key: ARTEMIS-1803 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1803 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.5.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Minor > > Right now a MessageReference will track a consumerId (in certain scenarios) > but the sessionId is not included. This is a problem because consumerIds are > not unique and are duplicated across sessions. In order to find a unique > consumer you need the sessionId and consumerId as well. This is a problem > for plugins implementing messageExpired and messageAcknowledged as they can't > get the exact consumer based on just the consumerId. > To solve this the ServerConsumer object responsible for acknowledging the > message or expiring the message should be passed to those callback methods. > If consumer doesn't apply (such as when the broker expires internally or > internally moves messages and acks) then the consumer object will be null. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1803) Pass ServerConsumer to messageExpired and messageAcknowledged plugin callbacks
[ https://issues.apache.org/jira/browse/ARTEMIS-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437476#comment-16437476 ] ASF GitHub Bot commented on ARTEMIS-1803: - Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/2012 @michaelandrepearce @cshannon my sider-sense doesn't feel dangers anymore : > Pass ServerConsumer to messageExpired and messageAcknowledged plugin callbacks > -- > > Key: ARTEMIS-1803 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1803 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.5.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Minor > > Right now a MessageReference will track a consumerId (in certain scenarios) > but the sessionId is not included. This is a problem because consumerIds are > not unique and are duplicated across sessions. In order to find a unique > consumer you need the sessionId and consumerId as well. This is a problem > for plugins implementing messageExpired and messageAcknowledged as they can't > get the exact consumer based on just the consumerId. > To solve this the ServerConsumer object responsible for acknowledging the > message or expiring the message should be passed to those callback methods. > If consumer doesn't apply (such as when the broker expires internally or > internally moves messages and acks) then the consumer object will be null. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1803) Pass ServerConsumer to messageExpired and messageAcknowledged plugin callbacks
[ https://issues.apache.org/jira/browse/ARTEMIS-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437431#comment-16437431 ] ASF GitHub Bot commented on ARTEMIS-1803: - Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2012 @franz1981, any comment? > Pass ServerConsumer to messageExpired and messageAcknowledged plugin callbacks > -- > > Key: ARTEMIS-1803 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1803 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.5.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Minor > > Right now a MessageReference will track a consumerId (in certain scenarios) > but the sessionId is not included. This is a problem because consumerIds are > not unique and are duplicated across sessions. In order to find a unique > consumer you need the sessionId and consumerId as well. This is a problem > for plugins implementing messageExpired and messageAcknowledged as they can't > get the exact consumer based on just the consumerId. > To solve this the ServerConsumer object responsible for acknowledging the > message or expiring the message should be passed to those callback methods. > If consumer doesn't apply (such as when the broker expires internally or > internally moves messages and acks) then the consumer object will be null. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1803) Pass ServerConsumer to messageExpired and messageAcknowledged plugin callbacks
[ https://issues.apache.org/jira/browse/ARTEMIS-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436323#comment-16436323 ] ASF GitHub Bot commented on ARTEMIS-1803: - Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2012 I personally prefer this. > Pass ServerConsumer to messageExpired and messageAcknowledged plugin callbacks > -- > > Key: ARTEMIS-1803 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1803 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.5.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Minor > > Right now a MessageReference will track a consumerId (in certain scenarios) > but the sessionId is not included. This is a problem because consumerIds are > not unique and are duplicated across sessions. In order to find a unique > consumer you need the sessionId and consumerId as well. This is a problem > for plugins implementing messageExpired and messageAcknowledged as they can't > get the exact consumer based on just the consumerId. > To solve this the ServerConsumer object responsible for acknowledging the > message or expiring the message should be passed to those callback methods. > If consumer doesn't apply (such as when the broker expires internally or > internally moves messages and acks) then the consumer object will be null. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1803) Pass ServerConsumer to messageExpired and messageAcknowledged plugin callbacks
[ https://issues.apache.org/jira/browse/ARTEMIS-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435911#comment-16435911 ] ASF GitHub Bot commented on ARTEMIS-1803: - Github user cshannon commented on the issue: https://github.com/apache/activemq-artemis/pull/2012 @franz1981 and @michaelandrepearce - I updated the patch to pass a reference to the ServerConsumer (when it applies) for both the expired and acked callbacks and dropped the extra reference to the serverId in the MessageReference classlet me know what you think > Pass ServerConsumer to messageExpired and messageAcknowledged plugin callbacks > -- > > Key: ARTEMIS-1803 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1803 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.5.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Minor > > Right now a MessageReference will track a consumerId (in certain scenarios) > but the sessionId is not included. This is a problem because consumerIds are > not unique and are duplicated across sessions. In order to find a unique > consumer you need the sessionId and consumerId as well. This is a problem > for plugins implementing messageExpired and messageAcknowledged as they can't > get the exact consumer based on just the consumerId. > To solve this the ServerConsumer object responsible for acknowledging the > message or expiring the message should be passed to those callback methods. > If consumer doesn't apply (such as when the broker expires internally or > internally moves messages and acks) then the consumer object will be null. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
