[jira] [Commented] (ARTEMIS-350) possible OOM in replication manager
[ https://issues.apache.org/jira/browse/ARTEMIS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159585#comment-15159585 ] ASF GitHub Bot commented on ARTEMIS-350: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/402 > possible OOM in replication manager > --- > > Key: ARTEMIS-350 > URL: https://issues.apache.org/jira/browse/ARTEMIS-350 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.3.0 > > > This is becausee we have no flow control, we need to throttle back when the > channel is not writable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-350) possible OOM in replication manager
[ https://issues.apache.org/jira/browse/ARTEMIS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159584#comment-15159584 ] ASF subversion and git services commented on ARTEMIS-350: - Commit 6bdfe95f665d19b868b8246358941b72419512ab in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=6bdfe95 ] ARTEMIS-350 small improvement on the writable logic > possible OOM in replication manager > --- > > Key: ARTEMIS-350 > URL: https://issues.apache.org/jira/browse/ARTEMIS-350 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.3.0 > > > This is becausee we have no flow control, we need to throttle back when the > channel is not writable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-350) possible OOM in replication manager
[ https://issues.apache.org/jira/browse/ARTEMIS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159568#comment-15159568 ] ASF GitHub Bot commented on ARTEMIS-350: GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/402 ARTEMIS-350 small improvement on the writable logic You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis tweak Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/402.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #402 > possible OOM in replication manager > --- > > Key: ARTEMIS-350 > URL: https://issues.apache.org/jira/browse/ARTEMIS-350 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.3.0 > > > This is becausee we have no flow control, we need to throttle back when the > channel is not writable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-350) possible OOM in replication manager
[ https://issues.apache.org/jira/browse/ARTEMIS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159471#comment-15159471 ] ASF GitHub Bot commented on ARTEMIS-350: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/400 > possible OOM in replication manager > --- > > Key: ARTEMIS-350 > URL: https://issues.apache.org/jira/browse/ARTEMIS-350 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.3.0 > > > This is becausee we have no flow control, we need to throttle back when the > channel is not writable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-350) possible OOM in replication manager
[ https://issues.apache.org/jira/browse/ARTEMIS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159468#comment-15159468 ] ASF subversion and git services commented on ARTEMIS-350: - Commit 2fcd474bb3ea83c696e2794cd7b5951494a2b20a in activemq-artemis's branch refs/heads/master from [~jbertram] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=2fcd474 ] ARTEMIS-350 fix for potential race It's possible for the latch used for flow control here to get out of sync. In other words, multiple count-downs can occur between count-ups so that the latch always has a count > 0. When this situation arises then every single packet sent to the replica is delayed by 5 seconds. The solution here essentially is to eliminate the latch completely and use a condition/wait/notify pattern. > possible OOM in replication manager > --- > > Key: ARTEMIS-350 > URL: https://issues.apache.org/jira/browse/ARTEMIS-350 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.3.0 > > > This is becausee we have no flow control, we need to throttle back when the > channel is not writable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-350) possible OOM in replication manager
[ https://issues.apache.org/jira/browse/ARTEMIS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158932#comment-15158932 ] ASF GitHub Bot commented on ARTEMIS-350: GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/400 ARTEMIS-350 fix for potential race It's possible for the latch used for flow control here to get out of sync. In other words, multiple count-downs can occur between count-ups so that the latch always has a count > 0. When this situation arises then every single packet sent to the replica is delayed by 5 seconds. The solution here essentially is to reset the latch back to zero every time instead of decrementing it by one with a normal count-down. This should still maintain overall flow-control, but also avoid this race condition. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-350 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/400.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #400 commit 366316352f1e0169effb1b455832a9188aed671c Author: jbertram Date: 2016-02-16T16:45:25Z ARTEMIS-350 fix for potential race It's possible for the latch used for flow control here to get out of sync. In other words, multiple count-downs can occur between count-ups so that the latch always has a count > 0. When this situation arises then every single packet sent to the replica is delayed by 5 seconds. The solution here essentially is to reset the latch back to zero every time instead of decrementing it by one with a normal count-down. This should still maintain overall flow-control, but also avoid this race condition. > possible OOM in replication manager > --- > > Key: ARTEMIS-350 > URL: https://issues.apache.org/jira/browse/ARTEMIS-350 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.3.0 > > > This is becausee we have no flow control, we need to throttle back when the > channel is not writable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-350) possible OOM in replication manager
[ https://issues.apache.org/jira/browse/ARTEMIS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110388#comment-15110388 ] ASF GitHub Bot commented on ARTEMIS-350: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/334 > possible OOM in replication manager > --- > > Key: ARTEMIS-350 > URL: https://issues.apache.org/jira/browse/ARTEMIS-350 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.3.0 > > > This is becausee we have no flow control, we need to throttle back when the > channel is not writable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-350) possible OOM in replication manager
[ https://issues.apache.org/jira/browse/ARTEMIS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110386#comment-15110386 ] ASF subversion and git services commented on ARTEMIS-350: - Commit a24dc5b61aec4c0bf71173056915a09187c216ea in activemq-artemis's branch refs/heads/master from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=a24dc5b ] ARTEMIS-350 - add timeout to avoid deadlock https://issues.apache.org/jira/browse/ARTEMIS-350 > possible OOM in replication manager > --- > > Key: ARTEMIS-350 > URL: https://issues.apache.org/jira/browse/ARTEMIS-350 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.3.0 > > > This is becausee we have no flow control, we need to throttle back when the > channel is not writable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-350) possible OOM in replication manager
[ https://issues.apache.org/jira/browse/ARTEMIS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110387#comment-15110387 ] ASF subversion and git services commented on ARTEMIS-350: - Commit a24dc5b61aec4c0bf71173056915a09187c216ea in activemq-artemis's branch refs/heads/master from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=a24dc5b ] ARTEMIS-350 - add timeout to avoid deadlock https://issues.apache.org/jira/browse/ARTEMIS-350 > possible OOM in replication manager > --- > > Key: ARTEMIS-350 > URL: https://issues.apache.org/jira/browse/ARTEMIS-350 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.3.0 > > > This is becausee we have no flow control, we need to throttle back when the > channel is not writable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-350) possible OOM in replication manager
[ https://issues.apache.org/jira/browse/ARTEMIS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110368#comment-15110368 ] ASF GitHub Bot commented on ARTEMIS-350: GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/334 ARTEMIS-350 - add timeout to avoid deadlock https://issues.apache.org/jira/browse/ARTEMIS-350 You can merge this pull request into a Git repository by running: $ git pull https://github.com/andytaylor/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/334.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #334 commit a24dc5b61aec4c0bf71173056915a09187c216ea Author: Andy Taylor Date: 2016-01-21T10:02:24Z ARTEMIS-350 - add timeout to avoid deadlock https://issues.apache.org/jira/browse/ARTEMIS-350 > possible OOM in replication manager > --- > > Key: ARTEMIS-350 > URL: https://issues.apache.org/jira/browse/ARTEMIS-350 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > Fix For: 1.3.0 > > > This is becausee we have no flow control, we need to throttle back when the > channel is not writable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-350) possible OOM in replication manager
[ https://issues.apache.org/jira/browse/ARTEMIS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107089#comment-15107089 ] ASF subversion and git services commented on ARTEMIS-350: - Commit b7f0d14b18b98b6a989281a046f0117ab39f6f9c in activemq-artemis's branch refs/heads/master from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b7f0d14 ] ARTEMIS-350 - possible OOM in replication manager https://issues.apache.org/jira/browse/ARTEMIS-350 > possible OOM in replication manager > --- > > Key: ARTEMIS-350 > URL: https://issues.apache.org/jira/browse/ARTEMIS-350 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > > This is becausee we have no flow control, we need to throttle back when the > channel is not writable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-350) possible OOM in replication manager
[ https://issues.apache.org/jira/browse/ARTEMIS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107090#comment-15107090 ] ASF subversion and git services commented on ARTEMIS-350: - Commit 68faa1d25245c45c15cf79cdc0ef25e0881baa61 in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=68faa1d ] ARTEMIS-350 Small improvement on the replication stop > possible OOM in replication manager > --- > > Key: ARTEMIS-350 > URL: https://issues.apache.org/jira/browse/ARTEMIS-350 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > > This is becausee we have no flow control, we need to throttle back when the > channel is not writable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-350) possible OOM in replication manager
[ https://issues.apache.org/jira/browse/ARTEMIS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107088#comment-15107088 ] ASF subversion and git services commented on ARTEMIS-350: - Commit b7f0d14b18b98b6a989281a046f0117ab39f6f9c in activemq-artemis's branch refs/heads/master from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b7f0d14 ] ARTEMIS-350 - possible OOM in replication manager https://issues.apache.org/jira/browse/ARTEMIS-350 > possible OOM in replication manager > --- > > Key: ARTEMIS-350 > URL: https://issues.apache.org/jira/browse/ARTEMIS-350 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > > This is becausee we have no flow control, we need to throttle back when the > channel is not writable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-350) possible OOM in replication manager
[ https://issues.apache.org/jira/browse/ARTEMIS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107091#comment-15107091 ] ASF GitHub Bot commented on ARTEMIS-350: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/327 > possible OOM in replication manager > --- > > Key: ARTEMIS-350 > URL: https://issues.apache.org/jira/browse/ARTEMIS-350 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > > This is becausee we have no flow control, we need to throttle back when the > channel is not writable -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-350) possible OOM in replication manager
[ https://issues.apache.org/jira/browse/ARTEMIS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106649#comment-15106649 ] ASF GitHub Bot commented on ARTEMIS-350: GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/327 ARTEMIS-350 - possible OOM in replication manager https://issues.apache.org/jira/browse/ARTEMIS-350 You can merge this pull request into a Git repository by running: $ git pull https://github.com/andytaylor/activemq-artemis ARTEMIS-350 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/327.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #327 commit 285580b4cdeb18e87ddbabfe5ae9786c0792a92f Author: Andy Taylor Date: 2016-01-19T10:11:17Z ARTEMIS-350 - possible OOM in replication manager https://issues.apache.org/jira/browse/ARTEMIS-350 > possible OOM in replication manager > --- > > Key: ARTEMIS-350 > URL: https://issues.apache.org/jira/browse/ARTEMIS-350 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Andy Taylor >Assignee: Andy Taylor > > This is becausee we have no flow control, we need to throttle back when the > channel is not writable -- This message was sent by Atlassian JIRA (v6.3.4#6332)