[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546438#comment-15546438
 ] 

ASF subversion and git services commented on ARTEMIS-737:
-

Commit fe24c5e9a486c00154e92b7870f87e9b989a6073 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=fe24c5e ]

ARTEMIS-737 small improvements on junit tests


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
> Fix For: 1.5.0
>
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526218#comment-15526218
 ] 

ASF subversion and git services commented on ARTEMIS-737:
-

Commit f5456e760a6bc3f15e9797b6fd08318223e17b09 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=f5456e7 ]

ARTEMIS-737 fixing test


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
> Fix For: 1.5.0
>
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524428#comment-15524428
 ] 

ASF subversion and git services commented on ARTEMIS-737:
-

Commit 59489b4de0082bb2ef19b84dd75a4f1634058280 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=59489b4 ]

ARTEMIS-737 fixing test


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
> Fix For: 1.5.0
>
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524308#comment-15524308
 ] 

ASF GitHub Bot commented on ARTEMIS-737:


Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/789
  
@hqstevenson I merged it with an extra commit, and removed the example.. 
and added a doc chapter...Please take a look... Feel free to change anything 
with another PR.


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
> Fix For: 1.5.0
>
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524305#comment-15524305
 ] 

ASF subversion and git services commented on ARTEMIS-737:
-

Commit 03b3b9fa80028dcb736c33f6f8e41f22584aa3b9 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=03b3b9f ]

ARTEMIS-737 Improving Tests by checking thread leaks and Waiting condition, 
also adding docs


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524307#comment-15524307
 ] 

ASF GitHub Bot commented on ARTEMIS-737:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/789


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524304#comment-15524304
 ] 

ASF subversion and git services commented on ARTEMIS-737:
-

Commit 32b7c039d83a80339815378bf9b2ead4b63d in activemq-artemis's branch 
refs/heads/master from [~hqstevenson]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=32b7c03 ]

ARTEMIS-737 - added class javadoc to rules


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524303#comment-15524303
 ] 

ASF subversion and git services commented on ARTEMIS-737:
-

Commit db095926ed1ddb9f59c32650af42e4b19312e76a in activemq-artemis's branch 
refs/heads/master from [~hqstevenson]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=db09592 ]

ARTEMIS-737 - added JUnit rules for Artemis servers and clients


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523956#comment-15523956
 ] 

ASF GitHub Bot commented on ARTEMIS-737:


Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/789
  
@hqstevenson  I didn't mean an actual example.. just how someone would use 
this into their application. 

It looks great.. will merge this soon.


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[Quinn Stevenson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517904#comment-15517904
 ] 

Quinn Stevenson commented on ARTEMIS-737:
-

@clebertsuconic  -I had an idea - I noticed that none of the examples have a 
"unit test".  I know you can run them with some the maven infrastructure that 
is available in the examples, but I thought it would be nice to have a unit 
test for an individual example.  So I updated the "Bridge" example 
(examples/features/standard/bridge) and added a unit test using the 
EmbeddedJMSResource - can you give it a look?

Note that I had to change the broker.xml files to get rid of a security 
exception I was seeing with the test - not really sure what's going on there.  
But if you like the idea, I could update a few more of the examples to include 
this type of unit test.

> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517225#comment-15517225
 ] 

ASF GitHub Bot commented on ARTEMIS-737:


Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/789
  
@hqstevenson  I was looking more for a single example on how to use your 
annotations. Something we could add a chapter within the documentation.



> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516871#comment-15516871
 ] 

ASF GitHub Bot commented on ARTEMIS-737:


Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/789
  
@hqstevenson the idea here is to provide final users the capability of 
running junit tests with a messaging server, right?


It would be nice to have at least an example on how to do this.. can you 
add at least one test as an example?


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516885#comment-15516885
 ] 

ASF GitHub Bot commented on ARTEMIS-737:


Github user hqstevenson commented on the issue:

https://github.com/apache/activemq-artemis/pull/789
  
I'd be happy to add an example, but I'm not sure exactly what you're 
looking for.  All of the unit tests show the basics of how you embed a sever 
into your test, and how you use the server afterwards.

Is there a specific type of test you'd like to see?

BTW - once this is released, I'm going to contribute a 
"example-camel-artemis" to the Camel project - that will show how to use the 
embedded resources with Camel.


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516864#comment-15516864
 ] 

ASF GitHub Bot commented on ARTEMIS-737:


Github user hqstevenson commented on the issue:

https://github.com/apache/activemq-artemis/pull/789
  
I fixed the check style issues, and I also added constructors to the 
EmbeddedXXXResource rules to allow configuring the servers with configuration 
files.


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[Quinn Stevenson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511598#comment-15511598
 ] 

Quinn Stevenson commented on ARTEMIS-737:
-

@clebertsucconic - yes, I'm getting the notifications.  Sorry - I was away from 
my desk for a while.

I tried to answer all the questions so far.  I see I missed the checkstyle 
checks - I'll have to get those errors fixed and update the PR.

> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[Quinn Stevenson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511595#comment-15511595
 ] 

Quinn Stevenson commented on ARTEMIS-737:
-

Yes - these rules are primarily targeted for end-users.  The idea was to make 
it as simple as possible to write unit tests for applications that need a 
messaging back-end.

> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[Quinn Stevenson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511591#comment-15511591
 ] 

Quinn Stevenson commented on ARTEMIS-737:
-

I don't necessarily think this approach is "better" than the existing test 
suite.  I was looking for something simple for end-user testing - similar to 
what I contributed to ActiveMQ (activemq-junit) a while back.

I don't have any expectations on whether or not these rules would help with 
testing Artemis itself - I'm not familiar enough with Artemis yet to have an 
informed opinion on that.  So I wouldn't expect internal Artemis tests to use 
these Rules -but they could if it made sense.

And No - I didn't have any plans on converting the existing test cases.  Again, 
if the Rule looks like it would make sense for those tests, I'd be happy to try 
and convert some of them.  But these Rules were primarily targeted and 
end-users (like me) who want to easily test their applications (like my Camel 
routes).

> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[Quinn Stevenson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511580#comment-15511580
 ] 

Quinn Stevenson commented on ARTEMIS-737:
-

I'd be happy to put something in the user docs - but I don't know how you go 
about that :-).  I've edited the wiki pages for ActiveMQ and Camel before, but 
I don't know the documentation process for Artemis.


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511422#comment-15511422
 ] 

ASF GitHub Bot commented on ARTEMIS-737:


Github user johnament commented on the issue:

https://github.com/apache/activemq-artemis/pull/789
  
@clebertsuconic agreed.  This does look like an awesome idea though for end 
users trying to test with messaging systems.


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511350#comment-15511350
 ] 

ASF GitHub Bot commented on ARTEMIS-737:


Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/789
  
I guess this is intended for users to use on their tests?

What was the intention, to refactor Artemis' testsuite, or to provide rules 
for users running their own tests?



> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511334#comment-15511334
 ] 

ASF GitHub Bot commented on ARTEMIS-737:


Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/789
  
I think it would also be good to have a clear explanation of why this 
approach is superior to the approach already adopted in the test-suite.

Additional questions:

1. What expectation is there to adopt this style of testing?  Should all 
new tests use this style?
2. Do you plan on converting all existing test-cases to this style?  If 
not, I'd be concerned with having 2 methods of doing the same thing introducing 
confusion.


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511304#comment-15511304
 ] 

ASF GitHub Bot commented on ARTEMIS-737:


Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/789
  
This looks a great idea...


however.. there's no docs on how to use this. it would warrant a chapter on 
the user-docs..

and maybe examples on how to run tests with it?


> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511288#comment-15511288
 ] 

ASF GitHub Bot commented on ARTEMIS-737:


GitHub user hqstevenson opened a pull request:

https://github.com/apache/activemq-artemis/pull/789

ARTEMIS-737 - added JUnit rules for Artemis servers and clients



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hqstevenson/activemq-artemis ARTEMIS-737

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/789.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #789


commit c79d00b78c23f55af88c94507c0a5ec8325cf893
Author: Quinn Stevenson 
Date:   2016-09-21T21:45:05Z

ARTEMIS-737 - added JUnit rules for Artemis servers and clients




> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-737) Add JUnit Rules

[Quinn Stevenson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503787#comment-15503787
 ] 

Quinn Stevenson commented on ARTEMIS-737:
-

I've started working on porting the JUnit rules from ActiveMQ over.

> Add JUnit Rules
> ---
>
> Key: ARTEMIS-737
> URL: https://issues.apache.org/jira/browse/ARTEMIS-737
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Quinn Stevenson
>Priority: Minor
>
> ActiveMQ includes a JUnit rule for embedding a JMS Broker.  This would be a 
> nice feature to have for Artemis as well, along with the JUnit rules for JMS 
> Clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)