[jira] [Commented] (ARTEMIS-1645) Diverted messages cannot be retried from DLQ

2018-02-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364273#comment-16364273
 ] 

ASF GitHub Bot commented on ARTEMIS-1645:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1844


> Diverted messages cannot be retried from DLQ
> 
>
> Key: ARTEMIS-1645
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1645
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Niels Lippke
>Assignee: Justin Bertram
>Priority: Critical
> Fix For: 2.5.0
>
> Attachments: QueueControlTest.java
>
>
> Given a topic _SOURCE_ and a divert which forwards a message _M_ to a queue 
>  _TARGET_. Consumer fails to process _M_ and _M_ is being send to DLQ. 
>    
>  If you now retry _M_ from DLQ it is not send to _TARGET_ but you'll get 
>  {{AMQ222196: Could not find binding ...}}
>  instead.
>  And even worse the message is lost afterwards (removed from DLQ)! 
>    
>  My suspecion is, that the message properties are not correct regarding 
>  {{_AMQ_ORIG_ADDRESS}} and {{_AMQ_ORIG_QUEUE.}} 
>  Is: {{_AMQ_ORIG_ADDRESS=, _AMQ_ORIG_QUEUE=TARGET}} 
>  Should be:  {{_AMQ_ORIG_ADDRESS=, 
> _AMQ_ORIG_QUEUE=TARGET}} 
>    
>  Attached you'll find a testcase "testRetryDivertedMessage" which 
>  demonstrates the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1645) Diverted messages cannot be retried from DLQ

2018-02-14 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364272#comment-16364272
 ] 

ASF subversion and git services commented on ARTEMIS-1645:
--

Commit 8b64ca183ad1fead6e7d78bbd9d0b4935e0356d5 in activemq-artemis's branch 
refs/heads/master from [~jbertram]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=8b64ca1 ]

ARTEMIS-1645 fix typo in DivertTest


> Diverted messages cannot be retried from DLQ
> 
>
> Key: ARTEMIS-1645
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1645
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Niels Lippke
>Assignee: Justin Bertram
>Priority: Critical
> Fix For: 2.5.0
>
> Attachments: QueueControlTest.java
>
>
> Given a topic _SOURCE_ and a divert which forwards a message _M_ to a queue 
>  _TARGET_. Consumer fails to process _M_ and _M_ is being send to DLQ. 
>    
>  If you now retry _M_ from DLQ it is not send to _TARGET_ but you'll get 
>  {{AMQ222196: Could not find binding ...}}
>  instead.
>  And even worse the message is lost afterwards (removed from DLQ)! 
>    
>  My suspecion is, that the message properties are not correct regarding 
>  {{_AMQ_ORIG_ADDRESS}} and {{_AMQ_ORIG_QUEUE.}} 
>  Is: {{_AMQ_ORIG_ADDRESS=, _AMQ_ORIG_QUEUE=TARGET}} 
>  Should be:  {{_AMQ_ORIG_ADDRESS=, 
> _AMQ_ORIG_QUEUE=TARGET}} 
>    
>  Attached you'll find a testcase "testRetryDivertedMessage" which 
>  demonstrates the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1645) Diverted messages cannot be retried from DLQ

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350912#comment-16350912
 ] 

ASF GitHub Bot commented on ARTEMIS-1645:
-

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1844

ARTEMIS-1645 fix test



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1645

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1844.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1844


commit f68c5b8db86e1a105c260ef490692474b70c962f
Author: Justin Bertram 
Date:   2018-02-02T20:24:26Z

ARTEMIS-1645 fix test




> Diverted messages cannot be retried from DLQ
> 
>
> Key: ARTEMIS-1645
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1645
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Niels Lippke
>Assignee: Justin Bertram
>Priority: Critical
> Fix For: 2.5.0
>
> Attachments: QueueControlTest.java
>
>
> Given a topic _SOURCE_ and a divert which forwards a message _M_ to a queue 
>  _TARGET_. Consumer fails to process _M_ and _M_ is being send to DLQ. 
>    
>  If you now retry _M_ from DLQ it is not send to _TARGET_ but you'll get 
>  {{AMQ222196: Could not find binding ...}}
>  instead.
>  And even worse the message is lost afterwards (removed from DLQ)! 
>    
>  My suspecion is, that the message properties are not correct regarding 
>  {{_AMQ_ORIG_ADDRESS}} and {{_AMQ_ORIG_QUEUE.}} 
>  Is: {{_AMQ_ORIG_ADDRESS=, _AMQ_ORIG_QUEUE=TARGET}} 
>  Should be:  {{_AMQ_ORIG_ADDRESS=, 
> _AMQ_ORIG_QUEUE=TARGET}} 
>    
>  Attached you'll find a testcase "testRetryDivertedMessage" which 
>  demonstrates the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1645) Diverted messages cannot be retried from DLQ

2018-01-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347758#comment-16347758
 ] 

ASF GitHub Bot commented on ARTEMIS-1645:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1831


> Diverted messages cannot be retried from DLQ
> 
>
> Key: ARTEMIS-1645
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1645
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Niels Lippke
>Assignee: Justin Bertram
>Priority: Critical
> Attachments: QueueControlTest.java
>
>
> Given a topic _SOURCE_ and a divert which forwards a message _M_ to a queue 
>  _TARGET_. Consumer fails to process _M_ and _M_ is being send to DLQ. 
>    
>  If you now retry _M_ from DLQ it is not send to _TARGET_ but you'll get 
>  {{AMQ222196: Could not find binding ...}}
>  instead.
>  And even worse the message is lost afterwards (removed from DLQ)! 
>    
>  My suspecion is, that the message properties are not correct regarding 
>  {{_AMQ_ORIG_ADDRESS}} and {{_AMQ_ORIG_QUEUE.}} 
>  Is: {{_AMQ_ORIG_ADDRESS=, _AMQ_ORIG_QUEUE=TARGET}} 
>  Should be:  {{_AMQ_ORIG_ADDRESS=, 
> _AMQ_ORIG_QUEUE=TARGET}} 
>    
>  Attached you'll find a testcase "testRetryDivertedMessage" which 
>  demonstrates the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1645) Diverted messages cannot be retried from DLQ

2018-01-31 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347756#comment-16347756
 ] 

ASF subversion and git services commented on ARTEMIS-1645:
--

Commit 028d6f71efb4b43eb6c3c3b261ac48576237f2cb in activemq-artemis's branch 
refs/heads/master from [~jbertram]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=028d6f7 ]

ARTEMIS-1645 diverted msg can't be retried from DLQ


> Diverted messages cannot be retried from DLQ
> 
>
> Key: ARTEMIS-1645
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1645
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Niels Lippke
>Assignee: Justin Bertram
>Priority: Critical
> Attachments: QueueControlTest.java
>
>
> Given a topic _SOURCE_ and a divert which forwards a message _M_ to a queue 
>  _TARGET_. Consumer fails to process _M_ and _M_ is being send to DLQ. 
>    
>  If you now retry _M_ from DLQ it is not send to _TARGET_ but you'll get 
>  {{AMQ222196: Could not find binding ...}}
>  instead.
>  And even worse the message is lost afterwards (removed from DLQ)! 
>    
>  My suspecion is, that the message properties are not correct regarding 
>  {{_AMQ_ORIG_ADDRESS}} and {{_AMQ_ORIG_QUEUE.}} 
>  Is: {{_AMQ_ORIG_ADDRESS=, _AMQ_ORIG_QUEUE=TARGET}} 
>  Should be:  {{_AMQ_ORIG_ADDRESS=, 
> _AMQ_ORIG_QUEUE=TARGET}} 
>    
>  Attached you'll find a testcase "testRetryDivertedMessage" which 
>  demonstrates the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1645) Diverted messages cannot be retried from DLQ

2018-01-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347578#comment-16347578
 ] 

ASF GitHub Bot commented on ARTEMIS-1645:
-

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1831

ARTEMIS-1645 diverted msg can't be retried from DLQ



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1645

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1831.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1831


commit b16fe67eeefb1223039bd193a6ca1287776af8fa
Author: Justin Bertram 
Date:   2018-01-31T04:03:38Z

ARTEMIS-1645 diverted msg can't be retried from DLQ




> Diverted messages cannot be retried from DLQ
> 
>
> Key: ARTEMIS-1645
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1645
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Niels Lippke
>Assignee: Justin Bertram
>Priority: Critical
> Attachments: QueueControlTest.java
>
>
> Given a topic _SOURCE_ and a divert which forwards a message _M_ to a queue 
>  _TARGET_. Consumer fails to process _M_ and _M_ is being send to DLQ. 
>    
>  If you now retry _M_ from DLQ it is not send to _TARGET_ but you'll get 
>  {{AMQ222196: Could not find binding ...}}
>  instead.
>  And even worse the message is lost afterwards (removed from DLQ)! 
>    
>  My suspecion is, that the message properties are not correct regarding 
>  {{_AMQ_ORIG_ADDRESS}} and {{_AMQ_ORIG_QUEUE.}} 
>  Is: {{_AMQ_ORIG_ADDRESS=, _AMQ_ORIG_QUEUE=TARGET}} 
>  Should be:  {{_AMQ_ORIG_ADDRESS=, 
> _AMQ_ORIG_QUEUE=TARGET}} 
>    
>  Attached you'll find a testcase "testRetryDivertedMessage" which 
>  demonstrates the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)