[jira] [Commented] (ARTEMIS-1652) XmlDataImporter forgets delete tmp files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350666#comment-16350666
 ] 

ASF GitHub Bot commented on ARTEMIS-1652:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1836


> XmlDataImporter forgets delete tmp files
> 
>
> Key: ARTEMIS-1652
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1652
> Project: ActiveMQ Artemis
>  Issue Type: Task
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.0
>
>
> When using the tool to import more than one large messages from xml exported 
> file, this utility class will create some tmp files, each for one large 
> message. However it only delete one of the tmp files. All the rest of tmp 
> files won't get cleaned up.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1652) XmlDataImporter forgets delete tmp files

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350665#comment-16350665
 ] 

ASF subversion and git services commented on ARTEMIS-1652:
--

Commit b2a71d27301f30e15f39bf425346c9b134dc39f0 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b2a71d2 ]

ARTEMIS-1652 Improving delete logic on XmlDataImporter

Before this the test would use a string and a temporary file on the user's 
folder.
After this the test will use a temporary file with the proper 
File.createTemporaryFile method.


> XmlDataImporter forgets delete tmp files
> 
>
> Key: ARTEMIS-1652
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1652
> Project: ActiveMQ Artemis
>  Issue Type: Task
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.0
>
>
> When using the tool to import more than one large messages from xml exported 
> file, this utility class will create some tmp files, each for one large 
> message. However it only delete one of the tmp files. All the rest of tmp 
> files won't get cleaned up.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1652) XmlDataImporter forgets delete tmp files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350512#comment-16350512
 ] 

ASF GitHub Bot commented on ARTEMIS-1652:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1836
  
A.. that's why the compatibility tests are generating so many tmp 
files.. thanks!


> XmlDataImporter forgets delete tmp files
> 
>
> Key: ARTEMIS-1652
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1652
> Project: ActiveMQ Artemis
>  Issue Type: Task
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.0
>
>
> When using the tool to import more than one large messages from xml exported 
> file, this utility class will create some tmp files, each for one large 
> message. However it only delete one of the tmp files. All the rest of tmp 
> files won't get cleaned up.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1652) XmlDataImporter forgets delete tmp files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348652#comment-16348652
 ] 

ASF GitHub Bot commented on ARTEMIS-1652:
-

GitHub user gaohoward opened a pull request:

https://github.com/apache/activemq-artemis/pull/1836

ARTEMIS-1652 XmlDataImporter forgets delete tmp files

When using the tool to import more than one large messages
from xml exported file, this utility class will create some
tmp files, each for one large message. However it only delete
one of the tmp files. All the rest of tmp files won't get
cleaned up.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaohoward/activemq-artemis 
fxmlExporter_tmpfile

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1836.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1836


commit 54a70efd04c0694a2f94186777c8fd0c2b509901
Author: Howard Gao 
Date:   2018-02-01T14:36:57Z

ARTEMIS-1652 XmlDataImporter forgets delete tmp files

When using the tool to import more than one large messages
from xml exported file, this utility class will create some
tmp files, each for one large message. However it only delete
one of the tmp files. All the rest of tmp files won't get
cleaned up.




> XmlDataImporter forgets delete tmp files
> 
>
> Key: ARTEMIS-1652
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1652
> Project: ActiveMQ Artemis
>  Issue Type: Task
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.0
>
>
> When using the tool to import more than one large messages from xml exported 
> file, this utility class will create some tmp files, each for one large 
> message. However it only delete one of the tmp files. All the rest of tmp 
> files won't get cleaned up.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)