[jira] [Commented] (ARTEMIS-1654) Bridge reconnect broken

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350671#comment-16350671
 ] 

ASF subversion and git services commented on ARTEMIS-1654:
--

Commit 032210a7c692d26baa13a80f30a3cf62c5df594e in activemq-artemis's branch 
refs/heads/master from [~andytaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=032210a ]

ARTEMIS-1654 - fix brige reconnect logic

Make sure that if a bridge disconnects and there is no record in the topology 
that it uses the original bridge connector to reconnect.

Originally the live broker that disconnected was left in the Topology, thie 
broke quorum voting as when th evote happened all brokers when asked though th 
etarget broker was still alive.
The fix for this was to remove the target live broker from the Topology. Since 
the bridge reconnect logic relied on this in a non HA environment to reconnect 
this stopped working.
The fix now uses the original target connector (or backup) to reconnect in the 
case where the broker was actually removed from the cluster.

https://issues.apache.org/jira/browse/ARTEMIS-1654


> Bridge reconnect broken
> ---
>
> Key: ARTEMIS-1654
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1654
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>
> A quorum fix broker this. Originally we used to leave a node in th etopology 
> when it disconnected, this broke voting as all brokers thought a crashed live 
> was still around. The bridge reconnect logic relied on this so now it needs 
> to fall back to the originall connectors if no backup is available and the 
> live is lost.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1654) Bridge reconnect broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350673#comment-16350673
 ] 

ASF GitHub Bot commented on ARTEMIS-1654:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1838


> Bridge reconnect broken
> ---
>
> Key: ARTEMIS-1654
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1654
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>
> A quorum fix broker this. Originally we used to leave a node in th etopology 
> when it disconnected, this broke voting as all brokers thought a crashed live 
> was still around. The bridge reconnect logic relied on this so now it needs 
> to fall back to the originall connectors if no backup is available and the 
> live is lost.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1654) Bridge reconnect broken

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350672#comment-16350672
 ] 

ASF subversion and git services commented on ARTEMIS-1654:
--

Commit 032210a7c692d26baa13a80f30a3cf62c5df594e in activemq-artemis's branch 
refs/heads/master from [~andytaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=032210a ]

ARTEMIS-1654 - fix brige reconnect logic

Make sure that if a bridge disconnects and there is no record in the topology 
that it uses the original bridge connector to reconnect.

Originally the live broker that disconnected was left in the Topology, thie 
broke quorum voting as when th evote happened all brokers when asked though th 
etarget broker was still alive.
The fix for this was to remove the target live broker from the Topology. Since 
the bridge reconnect logic relied on this in a non HA environment to reconnect 
this stopped working.
The fix now uses the original target connector (or backup) to reconnect in the 
case where the broker was actually removed from the cluster.

https://issues.apache.org/jira/browse/ARTEMIS-1654


> Bridge reconnect broken
> ---
>
> Key: ARTEMIS-1654
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1654
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>
> A quorum fix broker this. Originally we used to leave a node in th etopology 
> when it disconnected, this broke voting as all brokers thought a crashed live 
> was still around. The bridge reconnect logic relied on this so now it needs 
> to fall back to the originall connectors if no backup is available and the 
> live is lost.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1654) Bridge reconnect broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349959#comment-16349959
 ] 

ASF GitHub Bot commented on ARTEMIS-1654:
-

Github user andytaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1838
  
@clebertsuconic  could you check this


> Bridge reconnect broken
> ---
>
> Key: ARTEMIS-1654
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1654
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>
> A quorum fix broker this. Originally we used to leave a node in th etopology 
> when it disconnected, this broke voting as all brokers thought a crashed live 
> was still around. The bridge reconnect logic relied on this so now it needs 
> to fall back to the originall connectors if no backup is available and the 
> live is lost.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1654) Bridge reconnect broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349958#comment-16349958
 ] 

ASF GitHub Bot commented on ARTEMIS-1654:
-

GitHub user andytaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/1838

ARTEMIS-1654 - fix bridge reconnect logic

Make sure that if a bridge disconnects and there is no record in the 
topology that it uses the original bridge connector to reconnect

https://issues.apache.org/jira/browse/ARTEMIS-1654

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andytaylor/activemq-artemis ARTEMIS-1654

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1838.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1838


commit 22311333dc19a6a76f377530b03f75eef5c186cc
Author: Andy Taylor 
Date:   2018-02-01T13:22:59Z

ARTEMIS-1654 - fix brige reconnect logic

Make sure that if a bridge disconnects and there is no record in the 
topology that it uses the original bridge connector to reconnect

https://issues.apache.org/jira/browse/ARTEMIS-1654




> Bridge reconnect broken
> ---
>
> Key: ARTEMIS-1654
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1654
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>
> A quorum fix broker this. Originally we used to leave a node in th etopology 
> when it disconnected, this broke voting as all brokers thought a crashed live 
> was still around. The bridge reconnect logic relied on this so now it needs 
> to fall back to the originall connectors if no backup is available and the 
> live is lost.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)